Bug 174590 - sysutils/bsdadminscripts : install broken
Summary: sysutils/bsdadminscripts : install broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-20 15:40 UTC by Olivier
Modified: 2013-03-05 07:50 UTC (History)
0 users

See Also:


Attachments
patch.txt (666 bytes, text/plain)
2013-01-15 11:23 UTC, Olivier
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier 2012-12-20 15:40:00 UTC
On a system with OPTIONS_UNSET=DOCS (or maybe with NOPORTDOCS=yes), the sysutils/bsdadminscripts port can't be installed.

From sysutils/bsdadminscripts/Makefile :
do-install:
        @cd ${WRKSRC}; ./install.sh \
                -prefix=${PREFIX} -ports=${PORTSDIR} -distdir=${DISTDIR}  \
                -datadir=${DATADIR} ${NOPORTDOCS}

# grep '^NOPORTDOCS' /etc/make.conf
# grep '^OPTIONS_UNSET' /etc/make.conf
OPTIONS_UNSET=DOCS EXAMPLES
# cd /usr/ports/sysutils/bsdadminscripts/
# make -VNOPORTDOCS
yes

On such a system, the following will be executed :

./install.sh -prefix=/usr/local -ports=/usr/ports -distdir=/usr/ports/distfiles -datadir=/usr/local/share/bsdadminscripts yes

See the "yes" at the end. It then results in the following error (see below) :

How-To-Repeat: # echo 'OPTIONS_UNSET=DOCS' >> /etc/make.conf
# cd /usr/ports/sysutils/bsdadminscripts
# make install
===>  Installing for bsdadminscripts-6.1.1_3
===>   Generating temporary packing list
===>  Checking if sysutils/bsdadminscripts already installed
Unknown parameter 'yes'.
installing: %%MAN%%/man1/bsdadminscripts.1.gz
eval: bsdadminscripts.1: not found
installing: %%DATADIR%%/buildflags.awk
eval: buildflags.awk: not found
installing: %%PREFIX%%/etc/buildflags.conf.sample
eval: buildflags.conf.sample: not found
installing: %%DATADIR%%/buildflags.mk
eval: buildflags.mk: not found
installing: %%MAN%%/man1/buildflags.awk.1.gz
eval: buildflags.awk.1: not found
installing: %%MAN%%/man1/buildflags.conf.1.gz
eval: buildflags.conf.1: not found
installing: %%MAN%%/man1/buildflags.mk.1.gz
eval: buildflags.mk.1: not found
installing: %%PREFIX%%/sbin/distviper
eval: distviper: not found
installing: %%MAN%%/man1/distviper.1.gz
eval: distviper.1: not found
installing: %%PREFIX%%/sbin/pkg_libchk
eval: pkg_libchk: not found
installing: %%MAN%%/man1/pkg_libchk.1.gz
eval: pkg_libchk.1: not found
installing: %%PREFIX%%/sbin/pkg_upgrade
eval: pkg_upgrade: not found
installing: %%MAN%%/man1/pkg_upgrade.1.gz
eval: pkg_upgrade.1: not found
installing: %%PREFIX%%/sbin/pkg_validate
eval: pkg_validate: not found
installing: %%MAN%%/man1/pkg_validate.1.gz
eval: pkg_validate.1: not found
installing: %%PREFIX%%/sbin/portconfig
eval: portconfig: not found
installing: %%MAN%%/man1/portconfig.1.gz
eval: portconfig.1: not found
installing: %%PREFIX%%/sbin/rcstart
eval: rcstart: not found
installing: %%MAN%%/man1/rcstart.1.gz
eval: rcstart.1: not found
installing: %%PREFIX%%/sbin/uma
eval: uma: not found
installing: %%MAN%%/man1/uma.1.gz
eval: uma.1: not found
installing: %%PREFIX%%/etc/uma.conf.sample
eval: uma.conf.sample: not found
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rcstatus
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rcstop
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rcrestart
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rconestart
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rconestatus
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rconestop
hardlinking: %%PREFIX%%/sbin/rcstart -> %%PREFIX%%/sbin/rconerestart
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portbuild
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portclean
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portfetch
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portpackage
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portconfig-recursive
hardlinking: %%PREFIX%%/sbin/portconfig -> %%PREFIX%%/sbin/portfetch-recursive
===>   Registering installation for bsdadminscripts-6.1.1_3
pkg: lstat(/usr/local/man/man1/bsdadminscripts.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/buildflags.mk.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/buildflags.conf.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/buildflags.awk.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/distviper.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/pkg_libchk.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/pkg_upgrade.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/pkg_validate.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/portconfig.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/rcstart.1.gz): No such file or directory
pkg: lstat(/usr/local/man/man1/uma.1.gz): No such file or directory
pkg: lstat(/usr/local/share/bsdadminscripts/buildflags.awk): No such file or directory
pkg: lstat(/usr/local/etc/buildflags.conf.sample): No such file or directory
pkg: lstat(/usr/local/share/bsdadminscripts/buildflags.mk): No such file or directory
pkg: lstat(/usr/local/sbin/distviper): No such file or directory
pkg: lstat(/usr/local/sbin/pkg_libchk): No such file or directory
pkg: lstat(/usr/local/sbin/pkg_upgrade): No such file or directory
pkg: lstat(/usr/local/sbin/pkg_validate): No such file or directory
pkg: lstat(/usr/local/sbin/portconfig): No such file or directory
pkg: lstat(/usr/local/sbin/rcstart): No such file or directory
pkg: lstat(/usr/local/sbin/uma): No such file or directory
pkg: lstat(/usr/local/etc/uma.conf.sample): No such file or directory
pkg: lstat(/usr/local/sbin/rcstatus): No such file or directory
pkg: lstat(/usr/local/sbin/rcstop): No such file or directory
pkg: lstat(/usr/local/sbin/rcrestart): No such file or directory
pkg: lstat(/usr/local/sbin/rconestart): No such file or directory
pkg: lstat(/usr/local/sbin/rconestatus): No such file or directory
pkg: lstat(/usr/local/sbin/rconestop): No such file or directory
pkg: lstat(/usr/local/sbin/rconerestart): No such file or directory
pkg: lstat(/usr/local/sbin/portbuild): No such file or directory
pkg: lstat(/usr/local/sbin/portclean): No such file or directory
pkg: lstat(/usr/local/sbin/portfetch): No such file or directory
pkg: lstat(/usr/local/sbin/portpackage): No such file or directory
pkg: lstat(/usr/local/sbin/portconfig-recursive): No such file or directory
pkg: lstat(/usr/local/sbin/portfetch-recursive): No such file or directory
pkg: lstat(/usr/local/share/bsdadminscripts/): No such file or directory
Installing bsdadminscripts-6.1.1_3... done
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-20 15:40:07 UTC
Maintainer of sysutils/bsdadminscripts,

Please note that PR ports/174590 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/174590

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-20 15:40:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Olivier 2013-01-15 11:23:39 UTC
The following patch can be applied, the "NOPORTDOCS" variable should
not be used for internal manipulation of arbitrary values in the
Makefile, another name should be used. The patch uses the "DOCS" name,
I don't know if that's the best choice.

-- 
Olivier Smedts                                                 _
                                        ASCII ribbon campaign ( )
e-mail: olivier@gid0.org        - against HTML email & vCards  X
www: http://www.gid0.org    - against proprietary attachments / \

  "Il y a seulement 10 sortes de gens dans le monde :
  ceux qui comprennent le binaire,
  et ceux qui ne le comprennent pas."
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2013-03-05 07:33:38 UTC
State Changed
From-To: feedback->open

feedback timeout, 2+ months 


Comment 5 Jason Helfman freebsd_committer freebsd_triage 2013-03-05 07:33:38 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jgh

feedback timeout, 2+ months
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-03-05 07:40:52 UTC
Author: jgh
Date: Tue Mar  5 07:40:45 2013
New Revision: 313441
URL: http://svnweb.freebsd.org/changeset/ports/313441

Log:
  - fix NOPORTDOCS installation
  - while here tighten COMMENT and adoption of optionsNG for DOCS
  
  PR:		174590
  PR:		170542
  Submitted by:	olivier@gid0.org
  Approved by:	maintainer timeout, kamikaze@bsdforen.de ( 75 days )

Modified:
  head/sysutils/bsdadminscripts/Makefile

Modified: head/sysutils/bsdadminscripts/Makefile
==============================================================================
--- head/sysutils/bsdadminscripts/Makefile	Tue Mar  5 07:26:03 2013	(r313440)
+++ head/sysutils/bsdadminscripts/Makefile	Tue Mar  5 07:40:45 2013	(r313441)
@@ -8,15 +8,15 @@ CATEGORIES=	sysutils ports-mgmt
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}
 
 MAINTAINER=	kamikaze@bsdforen.de
-COMMENT=	A collection of administration scripts
+COMMENT=	Collection of administration scripts
 
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}/src
 NO_BUILD=	yes
 MANCOMPRESSED=	yes
 
-.if defined(NOPORTDOCS)
-NOPORTDOCS=	-nodoc
-.else
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MDOCS}
 MAN1=		bsdadminscripts.1 \
 		buildflags.mk.1 buildflags.conf.1 buildflags.awk.1 \
 		distviper.1 \
@@ -32,6 +32,8 @@ PORT_SCRIPTS=	build clean fetch package 
 		config-recursive fetch-recursive
 MLINKS+=	${RC_SCRIPTS:S,^,rc,:S,$,.1,:S,^,rcstart.1 ,} \
 		${PORT_SCRIPTS:S,^,port,:S,$,.1,:S,^,portconfig.1 ,}
+.else
+EVALDOCS=           -nodoc
 .endif
 
 plist: patch
@@ -41,6 +43,6 @@ plist: patch
 do-install:
 	@cd ${WRKSRC}; ./install.sh \
 		-prefix=${PREFIX} -ports=${PORTSDIR} -distdir=${DISTDIR}  \
-		-datadir=${DATADIR} ${NOPORTDOCS}
+		-datadir=${DATADIR} ${EVALDOCS}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Jason Helfman freebsd_committer freebsd_triage 2013-03-05 07:41:15 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!