Bug 174842 - multimedia/mplayer2 fails to build
Summary: multimedia/mplayer2 fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-30 22:00 UTC by Chris
Modified: 2012-12-31 17:40 UTC (History)
0 users

See Also:

Attachments
options (1.03 KB, application/octet-stream)
2012-12-31 09:51 UTC, Chris 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2012-12-30 22:00:00 UTC 
An attempt to build multimedia/mplayer2 fails at:

libmpdemux/demux_gif.c: In function 'demux_gif_fill_buffer':
libmpdemux/demux_gif.c:96: error: implicit declaration of function 'PrintGifError'
gmake: *** [libmpdemux/demux_gif.o] Error 1
*** Error code 1

Stop in /usr/ports/multimedia/mplayer2.
*** Error code 1

Stop in /usr/ports/multimedia/mplayer2.

How-To-Repeat: attempt to build /usr/ports/multimedia/mplayer2
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-30 22:00:34 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gblach

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris 2012-12-31 09:51:18 UTC 
After filing this PR, it occurred to me that I neglected to attach the
make config options I used when attempting to build multimedia/mplayer2.
As such, I am attaching it with this email, in hopes you will find it
beneficial.

HTH

--Chris
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-12-31 17:32:28 UTC 
Author: gblach
Date: Mon Dec 31 17:32:16 2012
New Revision: 309768
URL: http://svnweb.freebsd.org/changeset/ports/309768

Log:
  - Fix linking with giflib
  - Fix linking with libbluray
  
  PR:		ports/174842
  Approved by:	crees (mentor)

Added:
  head/multimedia/mplayer2/files/patch-libmpdemux-demux_gif.c   (contents, props changed)
Modified:
  head/multimedia/mplayer2/Makefile

Modified: head/multimedia/mplayer2/Makefile
==============================================================================
--- head/multimedia/mplayer2/Makefile	Mon Dec 31 17:25:28 2012	(r309767)
+++ head/multimedia/mplayer2/Makefile	Mon Dec 31 17:32:16 2012	(r309768)
@@ -166,7 +166,6 @@ CONFIGURE_ARGS+=	--disable-portaudio
 
 .if ${PORT_OPTIONS:MLIBBLURAY}
 LIB_DEPENDS+=		bluray:${PORTSDIR}/multimedia/libbluray
-CONFIGURE_ARGS+=	--enable-bluray
 .else
 CONFIGURE_ARGS+=	--disable-bluray
 .endif

Added: head/multimedia/mplayer2/files/patch-libmpdemux-demux_gif.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/multimedia/mplayer2/files/patch-libmpdemux-demux_gif.c	Mon Dec 31 17:32:16 2012	(r309768)
@@ -0,0 +1,19 @@
+--- libmpdemux/demux_gif.c.orig	2012-12-31 00:26:50.000000000 +0100
++++ libmpdemux/demux_gif.c	2012-12-31 00:30:54.000000000 +0100
+@@ -44,6 +44,16 @@
+ 
+ #define GIF_SIGNATURE (('G' << 16) | ('I' << 8) | 'F')
+ 
++static void PrintGifError(void)
++{
++  char *Err = GifErrorString();
++
++  if (Err != NULL)
++    fprintf(stderr, "\nGIF-LIB error: %s.\n", Err);
++  else
++    fprintf(stderr, "\nGIF-LIB undefined error %d.\n", GifError());
++}
++
+ #ifndef CONFIG_GIF_TVT_HACK
+ // not supported by certain versions of the library
+ static int my_read_gif(GifFileType *gif, uint8_t *buf, int len)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Grzegorz Blach freebsd_committer freebsd_triage 2012-12-31 17:38:25 UTC 
State Changed
From-To: open->closed

Fixed, thanks