Bug 174869 - audio/mp3info does not save "config" settings
Summary: audio/mp3info does not save "config" settings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-31 20:30 UTC by Doug Penner
Modified: 2013-01-07 12:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Penner 2012-12-31 20:30:00 UTC
When running "make config" on audio/mp3info it gives 1 option (which is set by default) for GTK2. If you uncheck the option and select "OK", then run "make config" again, it is checked again.

When you run "make install", it again brings up the dialog and if you un-check GTK2 (again), it will install without building GTK2.


I ran across this when building an application which depends on audio/mp3info and was trying to prevent all the X libraries from installing. I ran "make config-recursive" in the parent package. When I then noticed that the X libraries will still listed in "make missing", I ran "make config-recursive" again and audio/mp3info is the only package who's dialog came up the second time (there were many the first time).

How-To-Repeat: $ cd /usr/ports/audio/mp3info
$ make config
uncheck "GTK2"
$ make config
notice that it is set again!
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-12-31 20:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-01-07 12:34:06 UTC
Author: sylvio
Date: Mon Jan  7 12:33:59 2013
New Revision: 310042
URL: http://svnweb.freebsd.org/changeset/ports/310042

Log:
  - Change OPTIONS to new format.
  
  PR:		ports/174869
  Submitted by:	Doug Penner <darwinsurvivor@gmail.com>

Modified:
  head/audio/mp3info/Makefile

Modified: head/audio/mp3info/Makefile
==============================================================================
--- head/audio/mp3info/Makefile	Mon Jan  7 12:16:45 2013	(r310041)
+++ head/audio/mp3info/Makefile	Mon Jan  7 12:33:59 2013	(r310042)
@@ -22,18 +22,20 @@ WANT_GNOME=	yes
 
 PORTDOCS=	ChangeLog README mp3info.txt
 
-OPTIONS=	"GTK2"	"Enable to have the gmp3info"	"off"
+OPTIONS_DEFINE=	GTK2
+GTK2_DESC=	Enable to have the gmp3info
 
 PLIST_FILES=	bin/mp3info \
 		%%WITH_GTK%%bin/gmp3info
 
 MAN1=		mp3info.1
 
-.include <bsd.port.pre.mk>
-
 ALL_TARGET=	doc mp3info
 
-.if defined (WITH_GTK2)
+.include <bsd.port.pre.mk>
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MGTK2}
 PKGNAMESUFFIX=	-gtk
 USE_GNOME+=	gtk20
 ALL_TARGET+=	gmp3info
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2013-01-07 12:34:46 UTC
State Changed
From-To: open->closed

Fixed problem with new OPTIONS.