Bug 175007 - [PATCH] graphics/xsane: OptionsNG, ajdust dependencies, take maintainership
Summary: [PATCH] graphics/xsane: OptionsNG, ajdust dependencies, take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-05 13:50 UTC by nemysis
Modified: 2013-02-04 03:00 UTC (History)
0 users

See Also:


Attachments
xsane-0.998_3.patch (3.29 KB, patch)
2013-01-05 13:50 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-01-05 13:50:00 UTC
- Take maintainership

Makefile changed:
-#SUB_FILES+=	pkg-message <-- removed not used sub files
+OPTIONS_DEFINE=	GTK2 GIMP
+.include <bsd.port.options.mk>

Changed and refined:
+LIB_DEPENDS=
+BUILD_DEPENDS=	scanimage:${PORTSDIR}/graphics/sane-backends
+RUN_DEPENDS:=	${BUILD_DEPENDS}
 post-install:
 files/pkg-message.in

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
Have used patch for graphics/sane-backends to clean install XSane
ports/174961: graphics/xsane fails to compile

portlint -A
WARN: Makefile: [65]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
0 fatal errors and 3 warnings found.

WARN: Makefile: [65]: because is used
		-i "" -e 's|\$$(DESTDIR)\$$(sbindir)||g'

port test: clean
Comment 1 Eric Kraußer 2013-01-05 21:39:59 UTC
Thank you, nemysis. The patch does work for me.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2013-02-01 17:57:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2013-02-04 02:58:17 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-02-04 02:58:20 UTC
Author: amdmi3
Date: Mon Feb  4 02:58:12 2013
New Revision: 311563
URL: http://svnweb.freebsd.org/changeset/ports/311563

Log:
  - Cleanups
  - Fix NLS option logic
  - Pass maintaindership to submitter
  - While here, substitude LOCALBASE in pkg-message
  
  PR:		175007
  Submitted by:	nemysis <nemysis@gmx.ch>

Modified:
  head/graphics/xsane/Makefile
  head/graphics/xsane/files/pkg-message.in

Modified: head/graphics/xsane/Makefile
==============================================================================
--- head/graphics/xsane/Makefile	Mon Feb  4 02:47:35 2013	(r311562)
+++ head/graphics/xsane/Makefile	Mon Feb  4 02:58:12 2013	(r311563)
@@ -3,50 +3,49 @@
 
 PORTNAME=	xsane
 PORTVERSION=	0.998
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	graphics
 MASTER_SITES=	http://www.xsane.org/download/ \
 		http://gd.tuwien.ac.at/hci/sane/xsane/ \
 		ftp://ftp.mostang.com/pub/sane/xsane/
 
-MAINTAINER=	ports@FreeBSD.org
+MAINTAINER=	nemysis@gmx.ch
 COMMENT=	Gtk-based X11 frontend for SANE (Scanner Access Now Easy)
 
 LIB_DEPENDS=	jpeg:${PORTSDIR}/graphics/jpeg \
 		png15:${PORTSDIR}/graphics/png \
-		tiff:${PORTSDIR}/graphics/tiff \
-		sane:${PORTSDIR}/graphics/sane-backends
+		tiff:${PORTSDIR}/graphics/tiff
+BUILD_DEPENDS=	scanimage:${PORTSDIR}/graphics/sane-backends
+RUN_DEPENDS:=	${BUILD_DEPENDS}
 
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-WANT_GNOME=	yes
 USE_GNOME=	gtk20
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 
 MAN1=		xsane.1
 
-#SUB_FILES+=	pkg-message
-
 OPTIONS_DEFINE=	GIMP NLS
 GIMP_DESC=	GIMP plugin support
 
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
-CONFIGURE_ARGS+=--disable-nls
-PLIST_SUB+=	NLS="@comment "
-.else
 USE_GETTEXT=	yes
-PLIST_SUB+=	NLS=""
 CONFIGURE_ENV+=	LIBS="-L${LOCALBASE}/lib -lintl"
+PLIST_SUB+=	NLS=""
+.else
+CONFIGURE_ARGS+=--disable-nls
+PLIST_SUB+=	NLS="@comment "
 .endif
 
 .if ${PORT_OPTIONS:MGIMP}
 SUB_FILES+=	pkg-message
 LIB_DEPENDS+=	gimp:${PORTSDIR}/graphics/gimp-app
+CONFIGURE_ARGS+=--enable-gimp2
 .else
-CONFIGURE_ARGS+=	--disable-gimp
+CONFIGURE_ARGS+=--disable-gimp
 .endif
 
 pre-patch:
@@ -55,7 +54,9 @@ pre-patch:
 
 post-install:
 .if ${PORT_OPTIONS:MGIMP}
+	@${ECHO_CMD}
 	@${CAT} ${PKGMESSAGE}
+	@${ECHO_CMD}
 .endif
 
 .include <bsd.port.mk>

Modified: head/graphics/xsane/files/pkg-message.in
==============================================================================
--- head/graphics/xsane/files/pkg-message.in	Mon Feb  4 02:47:35 2013	(r311562)
+++ head/graphics/xsane/files/pkg-message.in	Mon Feb  4 02:58:12 2013	(r311563)
@@ -1,10 +1,14 @@
-Congratulations, XSane is now installed.
+===============================================================================
+
+XSane has been installed.
 
 To install XSane as a GIMP plug-in, please type:
 
-ln -sf ${LOCALBASE}/bin/xsane ~/.gimp-n.n/plug-ins/xsane
+    ln -sf %%LOCALBASE%%/bin/xsane ~/.gimp-*/plug-ins/xsane
 
 Then run the GIMP, and a new "XSane" menu item should appear in the
-"File->Acquire" menu.  Use this to access your scanner.
+"File->Acquire" menu. Use this to access your scanner.
 
 Have fun!
+
+===============================================================================
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"