- Add license information. - Adopt OptionsNG. - Trim makefile header. - Update WWW url.
Responsible Changed From-To: freebsd-ports-bugs->clsung Over to maintainer (via the GNATS Auto Assign Tool)
"Created by:" header is added to Makefile. Please commit attached patch instead of previous ones. Regards.
WITH_CHARSET is OptionsNG-fied using OPTIONS_RADIO. So please commit attached patch instead of previous ones. Regards.
Hello, Would you please commit this PR? Best Regards. --- Yasuhiro KIMURA
New version 0.995 is released. So please commit attached patch instead of previous ones. Regards.
Description in pkg-descr is updated based on jgh's suggestion to updating pkg-descr of japanese/mecab-ipadic in ports/175195. Since his suggestion should be applied to japanese/mecab rather than japanese/mecab-ipadic, I updated pkg-descr of this port. So please commit attached patch instead of previous ones. Best regards.
Hi, Please consider this attached patch. - Fix typo in pkg-descr and cosmetic change - Fix syntax (- Make use of PORTDOCS) Inclusion of bsd.port.pre.mk can be used instead of bsd.port.options.mk, and is still widely used in ports written before the introduction of bsd.port.options.mk. http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#AEN2693 There is no need to add DOCS (, NLS, EXAMPLES and IPV6) to OPTIONS_DEFAULT. http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#AEN2760 And furthermore, you can test your ports on RedPorts before sending PRs. https://redports.org/ Check your related PRs (ports/175257, ports/175695, ports/175696) as well as this PR and improve them. Thanks, -- TAKATSU Tomonari
Hello Takatsu-san, From: TAKATSU Tomonari <tota@FreeBSD.org> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. Date: Sat, 16 Feb 2013 23:14:59 +0900 > Please consider this attached patch. > - Fix typo in pkg-descr and cosmetic change > - Fix syntax > (- Make use of PORTDOCS) Thank you for suggestion. I approve your patch. Please commit it instead of mine. > Check your related PRs (ports/175257, ports/175695, ports/175696) as > well as this PR > and improve them. I also submitted updated patches for these PR's. So please commit them together. > And furthermore, you can test your ports on RedPorts before sending PRs. > https://redports.org/ Unfortunately registration on redports.org is temporary disabled now. But I'll try it next time I submit PR. Best Regards. --- Yasuhiro KIMURA
2013/2/17 Yasuhiro KIMURA <yasu@utahime.org>: > Hello Takatsu-san, > > From: TAKATSU Tomonari <tota@FreeBSD.org> > Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. > Date: Sat, 16 Feb 2013 23:14:59 +0900 > >> Please consider this attached patch. >> - Fix typo in pkg-descr and cosmetic change >> - Fix syntax >> (- Make use of PORTDOCS) > > Thank you for suggestion. I approve your patch. Please commit it > instead of mine. I got it. >> Check your related PRs (ports/175257, ports/175695, ports/175696) as >> well as this PR >> and improve them. > > I also submitted updated patches for these PR's. So please commit them > together. I' ll take it. >> And furthermore, you can test your ports on RedPorts before sending PRs. >> https://redports.org/ > > Unfortunately registration on redports.org is temporary disabled > now. But I'll try it next time I submit PR. I'm sorry for my forgetting that ... > Registration on redports.org is temporary disabled. It will be reenabled in March. https://redports.org/blog/Ports-QAT-and-redports.org-are-back By the way, I have a question. Have you checked whether default charset option is available or not? As far as I read http://mecab.googlecode.com/svn/trunk/mecab/configure , the value of default charset is different from one written in /head/japanese/mecab/Makefile. Optional Packages: (snip) --with-charset=charset set default charset (euc/sjis/utf8)) (snip) # Check whether --with-charset was given. if test "${with_charset+set}" = set; then : withval=$with_charset; CHARSET=${withval} else CHARSET='euc' fi CHARSET=$CHARSET (snip) Do you know that we can specify euc-jp/shift_jis/utf-8 instead of euc/sjis/utf8, both are available or default charset option is obsoleted? Would you ask the MeCab project about default charset if you dont' know? Thanks, -- TAKATSU Tomonari
From: TAKATSU Tomonari <tota@FreeBSD.org> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. Date: Sun, 17 Feb 2013 18:10:58 +0900 > By the way, I have a question. > Have you checked whether default charset option is available or not? > (snip) > Do you know that we can specify euc-jp/shift_jis/utf-8 instead of euc/sjis/utf8, > both are available or default charset option is obsoleted? To tell the truth, I only checked if proper option arguments are passed to configure script, and didn't check if default charset of compiled binary is really same as the one passed to configure script. But there is a function named decode_charset() in https://code.google.com/p/mecab/source/browse/trunk/mecab/src/utils.cpp, and it interprets both euc-jp/shift_jis/utf-8 and euc/sjis/utf8 as is expected. So I guess both case of configure arguments work fine. Regards. --- Yasuhiro KIMURA
2013/2/17 Yasuhiro KIMURA <yasu@utahime.org>: > From: TAKATSU Tomonari <tota@FreeBSD.org> > Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. > Date: Sun, 17 Feb 2013 18:10:58 +0900 > >> By the way, I have a question. >> Have you checked whether default charset option is available or not? >> (snip) >> Do you know that we can specify euc-jp/shift_jis/utf-8 instead of euc/sjis/utf8, >> both are available or default charset option is obsoleted? > > To tell the truth, I only checked if proper option arguments are > passed to configure script, and didn't check if default charset of > compiled binary is really same as the one passed to configure script. > > But there is a function named decode_charset() in > https://code.google.com/p/mecab/source/browse/trunk/mecab/src/utils.cpp, > and it interprets both euc-jp/shift_jis/utf-8 and euc/sjis/utf8 as is > expected. So I guess both case of configure arguments work fine. > > Regards. > > --- > Yasuhiro KIMURA The value of --with-charset argument of configure script is set to CHARSET at last. https://code.google.com/p/mecab/source/browse/trunk/mecab/configure#18005 But it seems to me that CHARSET macro is never used in source codes. Further, the MeCab::decode_charset() function is called from https://code.google.com/p/mecab/source/browse/trunk/mecab/src/iconv_utils.cpp#29 if defined HAVE_ICONV. As far as I check build log on RedPorts, I find "./configure: AM_ICONV: not found" in make build stage of japanese/mecab. https://redports.org/buildarchive/20130216080300-62187/ https://redports.org/~tota/20130216080300-62187-104813/ja-mecab-0.995.log What do you think? -- TAKATSU Tomonari
From: TAKATSU Tomonari <tota@freebsd.org> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. Date: Mon, 18 Feb 2013 22:25:32 +0900 > The value of --with-charset argument of configure script is set to > CHARSET at last. > https://code.google.com/p/mecab/source/browse/trunk/mecab/configure#18005 > > But it seems to me that CHARSET macro is never used in source codes. > > Further, the MeCab::decode_charset() function is called from > https://code.google.com/p/mecab/source/browse/trunk/mecab/src/iconv_utils.cpp#29 > if defined HAVE_ICONV. > > As far as I check build log on RedPorts, I find "./configure: > AM_ICONV: not found" > in make build stage of japanese/mecab. > https://redports.org/buildarchive/20130216080300-62187/ > https://redports.org/~tota/20130216080300-62187-104813/ja-mecab-0.995.log > > What do you think? I investigated source code of 0.995 and agree with you now. the value of --with-charset argument doesn't affect default charset of compiled binaries at all. It is simply determined by following portion: https://code.google.com/p/mecab/source/browse/trunk/mecab/src/common.h#57 #ifdef MECAB_USE_UTF8_ONLY #define MECAB_DEFAULT_CHARSET "UTF-8" #endif #ifndef MECAB_DEFAULT_CHARSET #if defined(_WIN32) && !defined(__CYGWIN__) #define MECAB_DEFAULT_CHARSET "SHIFT-JIS" #else #define MECAB_DEFAULT_CHARSET "EUC-JP" #endif #endif So --with-charset is totally useless. --- Yasuhiro KIMURA
2013/02/19 20:54 "Yasuhiro KIMURA" <yasu@utahime.org>: > > From: TAKATSU Tomonari <tota@freebsd.org> > Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. > Date: Mon, 18 Feb 2013 22:25:32 +0900 > > > The value of --with-charset argument of configure script is set to > > CHARSET at last. > > https://code.google.com/p/mecab/source/browse/trunk/mecab/configure#18005 > > > > But it seems to me that CHARSET macro is never used in source codes. > > > > Further, the MeCab::decode_charset() function is called from > > https://code.google.com/p/mecab/source/browse/trunk/mecab/src/iconv_utils.cpp#29 > > if defined HAVE_ICONV. > > > > As far as I check build log on RedPorts, I find "./configure: > > AM_ICONV: not found" > > in make build stage of japanese/mecab. > > https://redports.org/buildarchive/20130216080300-62187/ > > https://redports.org/~tota/20130216080300-62187-104813/ja-mecab-0.995.log > > > > What do you think? > > I investigated source code of 0.995 and agree with you now. the value > of --with-charset argument doesn't affect default charset of compiled > binaries at all. It is simply determined by following portion: > > https://code.google.com/p/mecab/source/browse/trunk/mecab/src/common.h#57 > > #ifdef MECAB_USE_UTF8_ONLY > #define MECAB_DEFAULT_CHARSET "UTF-8" > #endif > > #ifndef MECAB_DEFAULT_CHARSET > #if defined(_WIN32) && !defined(__CYGWIN__) > #define MECAB_DEFAULT_CHARSET "SHIFT-JIS" > #else > #define MECAB_DEFAULT_CHARSET "EUC-JP" > #endif > #endif > > So --with-charset is totally useless. > > --- > Yasuhiro KIMURA Thank you for investigating. After getting the result, we can drop options about CHARSET from Makefile in japanese/mecab. Need we wait for the result of investigation about ruby-mecab issue ports/175257 to update this port? -- TAKATSU Tomonari
From: TAKATSU Tomonari <tota@FreeBSD.org> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. Date: Wed, 20 Feb 2013 08:01:18 +0900 > Need we wait for the result of investigation about > ruby-mecab issue ports/175257 to update this port? Yes. I investigated the issue and reported it to MeCab ML, but there is no response until now. Regards. --- Yasuhiro KIMURA
2013/2/20 TAKATSU Tomonari <tota@freebsd.org>: > 2013/02/19 20:54 "Yasuhiro KIMURA" <yasu@utahime.org>: > > >> >> From: TAKATSU Tomonari <tota@freebsd.org> >> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information >> etc. >> Date: Mon, 18 Feb 2013 22:25:32 +0900 >> >> > The value of --with-charset argument of configure script is set to >> > CHARSET at last. >> > >> > https://code.google.com/p/mecab/source/browse/trunk/mecab/configure#18005 >> > >> > But it seems to me that CHARSET macro is never used in source codes. >> > >> > Further, the MeCab::decode_charset() function is called from >> > >> > https://code.google.com/p/mecab/source/browse/trunk/mecab/src/iconv_utils.cpp#29 >> > if defined HAVE_ICONV. >> > >> > As far as I check build log on RedPorts, I find "./configure: >> > AM_ICONV: not found" >> > in make build stage of japanese/mecab. >> > https://redports.org/buildarchive/20130216080300-62187/ >> > >> > https://redports.org/~tota/20130216080300-62187-104813/ja-mecab-0.995.log >> > >> > What do you think? >> >> I investigated source code of 0.995 and agree with you now. the value >> of --with-charset argument doesn't affect default charset of compiled >> binaries at all. It is simply determined by following portion: >> >> https://code.google.com/p/mecab/source/browse/trunk/mecab/src/common.h#57 >> >> #ifdef MECAB_USE_UTF8_ONLY >> #define MECAB_DEFAULT_CHARSET "UTF-8" >> #endif >> >> #ifndef MECAB_DEFAULT_CHARSET >> #if defined(_WIN32) && !defined(__CYGWIN__) >> #define MECAB_DEFAULT_CHARSET "SHIFT-JIS" >> #else >> #define MECAB_DEFAULT_CHARSET "EUC-JP" >> #endif >> #endif >> >> So --with-charset is totally useless. >> >> --- >> Yasuhiro KIMURA > > Thank you for investigating. > > After getting the result, we can drop options about > CHARSET from Makefile in japanese/mecab. > > Need we wait for the result of investigation about > ruby-mecab issue ports/175257 to update this port? > > -- > TAKATSU Tomonari I dropped OPTIONS for CHARSET. At last, we get japanese/mecab for version 0.995 as following. https://redports.org/browser/tota/japanese/mecab Please check it. Thanks, -- TAKATSU Tomonari
From: TAKATSU Tomonari <tota@FreeBSD.org> Subject: Re: ports/175258: [PATCH] japanese/mecab: add license information etc. Date: Wed, 20 Mar 2013 16:14:06 +0900 > I dropped OPTIONS for CHARSET. > At last, we get japanese/mecab for version 0.995 as following. > https://redports.org/browser/tota/japanese/mecab > Please check it. I checked out https://svn.redports.org/tota/japanese/mecab and tried instralltion. it worked fine. So please commit. Best Regards. --- Yasuhiro KIMURA
Author: tota Date: Wed Mar 20 12:38:23 2013 New Revision: 314725 URL: http://svnweb.freebsd.org/changeset/ports/314725 Log: - Update to 0.995 - Add LICENSE section - Adopt OptionsNG - Drop CONFIGURE_ARGS because --with-charset is not available any longer - Make use of PORTDOCS - Trim Makefile header - Update pkg-descr PR: ports/175258 Submitted by: Yasuhiro KIMURA <yasu_AT_utahime_DOT_org> Modified: head/japanese/mecab/Makefile head/japanese/mecab/distinfo head/japanese/mecab/pkg-descr head/japanese/mecab/pkg-plist Modified: head/japanese/mecab/Makefile ============================================================================== --- head/japanese/mecab/Makefile Wed Mar 20 11:35:01 2013 (r314724) +++ head/japanese/mecab/Makefile Wed Mar 20 12:38:23 2013 (r314725) @@ -1,18 +1,20 @@ -# New ports collection makefile for: mecab -# Date created: 2 April 2003 -# Whom: Akinori MUSHA aka knu <knu@idaemons.org> -# +# Created by: Akinori MUSHA aka knu <knu@idaemons.org> # $FreeBSD$ -# PORTNAME= mecab -PORTVERSION= 0.994 +PORTVERSION= 0.995 CATEGORIES= japanese textproc -MASTER_SITES= ${MASTER_SITE_GOOGLE_CODE} +MASTER_SITES= GOOGLE_CODE MAINTAINER= clsung@FreeBSD.org COMMENT= Yet Another Part-of-Speech and Morphological Analyzer +LICENSE= BSD GPLv2 LGPL21 +LICENSE_COMB= dual +LICENSE_FILE_BSD= ${WRKSRC}/BSD +LICENSE_FILE_GPLv2= ${WRKSRC}/GPL +LICENSE_FILE_LGPL21= ${WRKSRC}/LGPL + USE_AUTOTOOLS= libtool USE_ICONV= yes USE_PERL5_BUILD= yes @@ -22,16 +24,13 @@ USE_LDCONFIG= yes CPPFLAGS+= ${PTHREAD_CFLAGS} -I ${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib -# Default charset (euc-jp/shift_jis/utf-8) -.if defined(WITH_CHARSET) -CONFIGURE_ARGS+= --with-charset=${WITH_CHARSET} -.endif - MAN1= mecab.1 -DOCS= AUTHORS README doc/*.html +PORTDOCS= AUTHORS README *.html + +OPTIONS_DEFINE= DOCS -.include <bsd.port.pre.mk> +.include <bsd.port.options.mk> post-patch: ${REINPLACE_CMD} -e 's/-lpthread/${PTHREAD_LIBS}/g' \ @@ -48,12 +47,13 @@ post-install: @if [ ! -f ${PREFIX}/etc/mecabrc ]; then \ ${INSTALL_DATA} ${PREFIX}/etc/mecabrc.dist ${PREFIX}/etc/mecabrc; \ fi -.if !defined(NOPORTDOCS) +.if ${PORT_OPTIONS:MDOCS} ${MKDIR} ${DOCSDIR} -.for f in ${DOCS} +.for f in ${PORTDOCS:N*.html} ${INSTALL_DATA} ${WRKSRC}/${f} ${DOCSDIR}/ .endfor + ${INSTALL_DATA} ${WRKSRC}/doc/*.html ${DOCSDIR}/ .endif @${CAT} ${PKGMESSAGE} -.include <bsd.port.post.mk> +.include <bsd.port.mk> Modified: head/japanese/mecab/distinfo ============================================================================== --- head/japanese/mecab/distinfo Wed Mar 20 11:35:01 2013 (r314724) +++ head/japanese/mecab/distinfo Wed Mar 20 12:38:23 2013 (r314725) @@ -1,2 +1,2 @@ -SHA256 (mecab-0.994.tar.gz) = d271a0b91e0cda09f13f62a6b28367648afb9b4dcb68178ea1fb0af4c0c866bc -SIZE (mecab-0.994.tar.gz) = 1387966 +SHA256 (mecab-0.995.tar.gz) = a281cac1a7053c9d16e3885a677398566923d7e4c5fc34654d4ebc6c3b3aa520 +SIZE (mecab-0.995.tar.gz) = 1377686 Modified: head/japanese/mecab/pkg-descr ============================================================================== --- head/japanese/mecab/pkg-descr Wed Mar 20 11:35:01 2013 (r314724) +++ head/japanese/mecab/pkg-descr Wed Mar 20 12:38:23 2013 (r314725) @@ -1,4 +1,13 @@ -MeCab: Yet Another Part-of-Speech and Morphological Analyzer +MeCab is open source Japanese dependency structure analyzer developed +through the joint research project between Graduate School of Informatics +Kyoto University and NTT (Nippon Telegraph and Telephone) +Communication Science Laboratories. It has following featers: -Author: Taku Kudo <taku@chasen.org> -WWW: http://mecab.sourceforge.net/ +* General-purpose design independent from language, dictionary and + corpus. +* High precision of analysis based on Conditional Random Fields. +* Faster than ChaSen, Juman and KAKASI. +* Library is reentrant. +* Scripting language bindings such as Perl/Ruby/Python/Java/C#. + +WWW: https://code.google.com/p/mecab/ Modified: head/japanese/mecab/pkg-plist ============================================================================== --- head/japanese/mecab/pkg-plist Wed Mar 20 11:35:01 2013 (r314724) +++ head/japanese/mecab/pkg-plist Wed Mar 20 12:38:23 2013 (r314725) @@ -14,19 +14,3 @@ libexec/mecab/mecab-test-gen @unexec if cmp -s %D/etc/mecabrc.dist %D/etc/mecabrc; then rm -f %D/etc/mecabrc; else true; fi etc/mecabrc.dist @exec if [ ! -f %D/etc/mecabrc ]; then cp -p %D/%F %B/mecabrc; fi -%%PORTDOCS%%%%DOCSDIR%%/AUTHORS -%%PORTDOCS%%%%DOCSDIR%%/README -%%PORTDOCS%%%%DOCSDIR%%/bindings.html -%%PORTDOCS%%%%DOCSDIR%%/dic-detail.html -%%PORTDOCS%%%%DOCSDIR%%/dic.html -%%PORTDOCS%%%%DOCSDIR%%/feature.html -%%PORTDOCS%%%%DOCSDIR%%/format.html -%%PORTDOCS%%%%DOCSDIR%%/index.html -%%PORTDOCS%%%%DOCSDIR%%/learn.html -%%PORTDOCS%%%%DOCSDIR%%/libmecab.html -%%PORTDOCS%%%%DOCSDIR%%/mecab.html -%%PORTDOCS%%%%DOCSDIR%%/partial.html -%%PORTDOCS%%%%DOCSDIR%%/posid.html -%%PORTDOCS%%%%DOCSDIR%%/soft.html -%%PORTDOCS%%%%DOCSDIR%%/unk.html -%%PORTDOCS%%@dirrm %%DOCSDIR%% _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!