Bug 175262 - [MAINTAINER] audio/portaudio2: Changed UNIQUENAME to portaudio2
Summary: [MAINTAINER] audio/portaudio2: Changed UNIQUENAME to portaudio2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-13 14:30 UTC by nemysis
Modified: 2013-01-17 13:10 UTC (History)
0 users

See Also:


Attachments
portaudio2-19.20111121.patch (1.03 KB, patch)
2013-01-13 14:30 UTC, nemysis
no flags Details | Diff
portaudio2.diff (812 bytes, patch)
2013-01-16 01:05 UTC, nemysis
no flags Details | Diff
portaudio.diff (566 bytes, patch)
2013-01-16 23:34 UTC, Max Brazhnikov
no flags Details | Diff
portaudio2.diff (933 bytes, patch)
2013-01-17 02:38 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-01-13 14:30:00 UTC
Changed UNIQUENAME to portaudio2
-PORTNAME=	portaudio
+PORTNAME=	portaudio2

+WRKSRC=		${WRKDIR}/portaudio
-DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}2


Have changed UNIQUENAME, because is needed to have difference with audio/portaudio

and because this test

http://93.62.141.59/tb/errors/9.1-amd64-x11/vlc-2.0.5,3.log

I have not used because UNIQUENAME changes

-USE_LDCONFIG=	yes
+USE_LDCONFIG=	${PREFIX}/lib/${PORTNAME}2

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
portlint -A
looks usual.

port test: clean
Comment 1 Max Brazhnikov freebsd_committer freebsd_triage 2013-01-15 23:27:20 UTC
State Changed
From-To: open->feedback

Why do you change PORTNAME, when you can directly set UNIQUENAME?
Comment 2 nemysis 2013-01-16 01:05:28 UTC
> Why do you change PORTNAME, when you can directly set UNIQUENAME?

> http://www.freebsd.org/cgi/query-pr.cgi?pr=175262

audio/portaudio and audio/portaudio2 have the same

PORTNAME=       portaudio

I can't use for portaudio2 as usually

port diff

must use always

/usr/local/ports/local/commited/audio/portaudio2/ > diff -ruN /usr/ports/audio/portaudio2 ./portaudio2 > portaudio2.diff


Package name is

portaudio-19.20111121

not

portaudio2-19.20111121


Ok i have changed now only this in Makefile

Adedd
+UNIQUENAME=    ${PORTNAME}2

and changed all

${PORTNAME}2 --> ${UNIQUENAME}


Is this better or to change PORTNAME and have clean port diff and right package name?




Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2013-01-16 11:45:01 UTC
Responsible Changed
From-To: freebsd-ports-bugs->makc

I'll take it.
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2013-01-16 23:34:56 UTC
On Wed, 16 Jan 2013 02:05:28 +0100, nemysis wrote:
> Is this better or to change PORTNAME and have clean port diff and right package name?

PORTNAME can be shared by ports, usually when you have several versions of
software. But in this case ports should set different LATEST_LINK [*].
I suggest to set LATEST_LINK for audio/portaudio2 and leave audio/portaudio as
is (see attached patch).

[*] http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#AEN656
Comment 5 nemysis 2013-01-17 02:38:08 UTC
Here is newest diff which works good.

Have reverted

-USE_LDCONFIG=  yes
+USE_LDCONFIG=  ${PREFIX}/lib/${PORTNAME}2

ldconfig -r | grep portaudio
        search directories: /lib:/usr/lib:/usr/lib/compat:/usr/local/lib:/usr/local/lib/compat/pkg:/usr/local/kde4/lib:/usr/local/lib/Tclxml3.2:/usr/local/lib/compat:/usr/local/lib/event2:/usr/local/lib/gcc46:/usr/local/lib/graphviz:/usr/local/lib/libxul:/usr/local/lib/mysql:/usr/local/lib/nss:/usr/local/lib/pth:/usr/local/lib/qt4:/usr/local/lib/portaudio2
        724:-lportaudio.0 => /usr/local/lib/libportaudio.so.0
        1127:-lportaudio.2 => /usr/local/lib/portaudio2/libportaudio.so.2
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-01-17 13:01:37 UTC
Author: makc
Date: Thu Jan 17 13:01:25 2013
New Revision: 310549
URL: http://svnweb.freebsd.org/changeset/ports/310549

Log:
  Set LATEST_LINK to differ from audio/portaudio
  Fix USE_LDCONFIG
  Use DISTVERSION
  
  PR:		based on ports/175262
  Submitted by:	maintainer

Modified:
  head/audio/portaudio2/Makefile

Modified: head/audio/portaudio2/Makefile
==============================================================================
--- head/audio/portaudio2/Makefile	Thu Jan 17 11:28:48 2013	(r310548)
+++ head/audio/portaudio2/Makefile	Thu Jan 17 13:01:25 2013	(r310549)
@@ -2,10 +2,11 @@
 # $FreeBSD$
 
 PORTNAME=	portaudio
-PORTVERSION=	19.20111121
+DISTVERSION=	19_20111121
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	http://www.portaudio.com/archives/
-DISTNAME=	pa_stable_v${DISTVERSION:S/./_/}
+DISTNAME=	pa_stable_v${DISTVERSION}
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	nemysis@gmx.ch
@@ -13,6 +14,7 @@ COMMENT=	Portable cross-platform Audio A
 
 LICENSE=	MIT
 
+LATEST_LINK=	${PORTNAME}19
 WRKSRC=		${WRKDIR}/${PORTNAME}
 
 GNU_CONFIGURE=	yes
@@ -24,7 +26,7 @@ CONFIGURE_ARGS+=PKG_CONFIG_LIBDIR=${PREF
 USE_GMAKE=	yes
 USE_DOS2UNIX=	yes
 USE_PKGCONFIG=	build
-USE_LDCONFIG=	yes
+USE_LDCONFIG=	${PREFIX}/lib/${PORTNAME}2
 
 CPPFLAGS+=	-I${LOCALBASE}/include ${PTHREAD_CFLAGS}
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2013-01-17 13:02:05 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!