Bug 175513 - [patch] graphics/zathura: update to 0.2.2
Summary: [patch] graphics/zathura: update to 0.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-22 17:30 UTC by Quentin Stievenart
Modified: 2013-01-23 19:32 UTC (History)
0 users

See Also:

Attachments
file.diff (2.33 KB, patch)
2013-01-22 17:30 UTC, Quentin Stievenart 		no flags Details | Diff
zathura.diff (3.20 KB, patch)
2013-01-22 20:37 UTC, Guido Falsi 		no flags Details | Diff
zathura.diff (4.06 KB, patch)
2013-01-23 13:34 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Quentin Stievenart 2013-01-22 17:30:02 UTC 
Updated to 0.2.2. A patch is needed to use the old static mutexes of glib (deprecated since 2.32, but only glib 2.28 is available in the ports tree).

Fix: Patch attached with submission follows:
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2013-01-22 19:16:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->madpilot

I'll take it.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2013-01-22 20:37:32 UTC 
Hi,

Thanks for your patches.

I am attaching a revised patch.

Please note that when updating PORTVERSION, PORTREVISION should be reset.

Also, I noticed that the "FETCH_ARGS=-Fpr" is not needed anymore. The 
port fetches successfully also without it.

While here I also updated the port to use the new options framework.

I added explicit options for DOCS and NLS, since the port has support 
for them.

Thanks again for your time and work.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2013-01-23 13:34:09 UTC 
I just noticed another detail which needs to be fixed in the port.

The pkg-message makes a reference to the dead port 
graphics/zathura-pdf-mupdf. I removed such reference.

Attaching a revised patch.

Thanks.

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 4 Quentin Stievenart 2013-01-23 14:54:10 UTC 
Right, this port never existed. The last line should be "install the
graphics/zathura-pdf-poppler port." though (the word 'port' is
missing), or the 'the' should be removed. And thanks for the other
improvements, I totally forgot to update PORTREVISION and didn't know
about the new options framework.

On 23 January 2013 14:34, Guido Falsi <madpilot@freebsd.org> wrote:
> I just noticed another detail which needs to be fixed in the port.
>
> The pkg-message makes a reference to the dead port
> graphics/zathura-pdf-mupdf. I removed such reference.
>
> Attaching a revised patch.
>
> Thanks.
>
> --
> Guido Falsi <madpilot@FreeBSD.org>
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2013-01-23 16:10:58 UTC 
On 01/23/13 15:54, Quentin Stievenart wrote:
> Right, this port never existed. The last line should be "install the
> graphics/zathura-pdf-poppler port." though (the word 'port' is
> missing), or the 'the' should be removed. And thanks for the other
> improvements, I totally forgot to update PORTREVISION and didn't know
> about the new options framework.

Correct, I'll commit my patch with the fixed pkg-message as you noticed.

Thanks!

-- 
Guido Falsi <madpilot@FreeBSD.org>
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2013-01-23 19:32:45 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!