Bug 175684 - [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation
Summary: [patch] emulators/virtualbox-ose-kmod: Fix KMODDIR installation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Glen Barber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-29 22:00 UTC by Glen Barber
Modified: 2013-03-21 13:20 UTC (History)
0 users

See Also:


Attachments
file.diff (460 bytes, patch)
2013-01-29 22:00 UTC, Glen Barber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Glen Barber freebsd_committer freebsd_triage 2013-01-29 22:00:00 UTC
emulators/virtualbox-ose-kmod/Makefile sets KMODDIR to /boot/modules if not set:

 root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # grep ^KMODDIR Makefile
 KMODDIR?=       /boot/modules

However, KMODDIR is always set, even if not explicitly set by the user:

 root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -V KMODDIR
 /boot/kernel
 root@nucleus:/usr/ports/emulators/virtualbox-ose-kmod # make -C ../qemu -V KMODDIR
 /boot/kernel

Fix: The attached patch sets KMODDIR=/boot/modules instead of attempting to set to /boot/modules if not set, otherwise users will experience pain when vbox*.ko disappear after a kernel upgrade.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-01-29 22:00:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vbox

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 vsityz 2013-03-13 08:08:19 UTC
I have same error

cat messages| grep vboxnetflt

Mar 13 09:51:23 admin root: /etc/rc: WARNING: Can't load vboxnetflt module.


FreeBSD admin.local 9.1-STABLE FreeBSD 9.1-STABLE #0 r248202: Tue Mar 12
18:50:08 EET 2013     root@admin.local:/usr/obj/usr/src/sys/Kernel  amd64
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-03-21 01:59:30 UTC
Author: gjb
Date: Thu Mar 21 01:59:22 2013
New Revision: 314795
URL: http://svnweb.freebsd.org/changeset/ports/314795

Log:
  Set KMODDIR to /boot/modules, since it is always defined to
  /boot/kernel otherwise.
  
  PR:		ports/175684, ports/176288
  Approved by:	vbox (maintainer timeout, nearly 2 months)

Modified:
  head/emulators/virtualbox-ose-kmod/Makefile

Modified: head/emulators/virtualbox-ose-kmod/Makefile
==============================================================================
--- head/emulators/virtualbox-ose-kmod/Makefile	Thu Mar 21 01:24:26 2013	(r314794)
+++ head/emulators/virtualbox-ose-kmod/Makefile	Thu Mar 21 01:59:22 2013	(r314795)
@@ -45,7 +45,7 @@ VIMAGE_DESC=	VIMAGE virtual networking s
 
 PLIST_SUB+=	KMODDIR=${KMODDIR:C,^/,,}
 
-KMODDIR?=	/boot/modules
+KMODDIR=	/boot/modules
 SRC_BASE?=	/usr/src
 
 VBOX_BIN=	${WRKSRC}/out/${KMK_ARCH}/${KMK_BUILDTYPE}/bin/src
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Glen Barber freebsd_committer freebsd_triage 2013-03-21 01:59:49 UTC
State Changed
From-To: open->closed

I closed it. 



Comment 5 Glen Barber freebsd_committer freebsd_triage 2013-03-21 01:59:49 UTC
Responsible Changed
From-To: vbox->gjb

Track
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-03-21 13:16:10 UTC
Author: gjb
Date: Thu Mar 21 13:15:57 2013
New Revision: 314842
URL: http://svnweb.freebsd.org/changeset/ports/314842

Log:
  Set KMODDIR to /boot/modules, since it is always defined to
  /boot/kernel otherwise.
  
  PR:		ports/175684, ports/176288 (related to)
  Prodded by:	Nikolai Lifanov <lifanov@mail.lifanov.com>
  Approved by:	vbox (maintainer timeout, nearly 2 months)

Modified:
  head/emulators/virtualbox-ose/Makefile

Modified: head/emulators/virtualbox-ose/Makefile
==============================================================================
--- head/emulators/virtualbox-ose/Makefile	Thu Mar 21 13:03:07 2013	(r314841)
+++ head/emulators/virtualbox-ose/Makefile	Thu Mar 21 13:15:57 2013	(r314842)
@@ -70,7 +70,7 @@ WEBSERVICE_DESC=	Build Webservice
 
 .include <bsd.port.options.mk>
 
-KMODDIR?=	/boot/modules
+KMODDIR=	/boot/modules
 
 PLIST_SUB+=	PYTHON_VER=${PYTHON_VER} \
 		PYTHON_VERU=${PYTHON_VER:S/./_/} \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"