Bug 175785 - [patch] graphics/renrot remove SITE_PERL from RUN_DEPENDS
Summary: [patch] graphics/renrot remove SITE_PERL from RUN_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-02 20:30 UTC by Alex Kozlov
Modified: 2013-02-17 11:30 UTC (History)
0 users

See Also:


Attachments
file.diff (629 bytes, patch)
2013-02-02 20:30 UTC, Alex Kozlov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Kozlov 2013-02-02 20:30:00 UTC
- remove SITE_PERL from RUN_DEPENDS
  (see https://wiki.freebsd.org/PortsLongtermTargets#Use_of_SITE_PERL_in_dependencies)
- use ETCDIR

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-02 20:30:06 UTC
Maintainer of graphics/renrot,

Please note that PR ports/175785 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/175785

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-02 20:30:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Alex Kozlov freebsd_committer freebsd_triage 2013-02-02 20:31:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-02-17 11:27:15 UTC
Author: ak
Date: Sun Feb 17 11:27:07 2013
New Revision: 312411
URL: http://svnweb.freebsd.org/changeset/ports/312411

Log:
  - Remove SITE_PERL from RUN_DEPENDS; don't rely on ImageMagick package name, it can be changed via PKGNAMESUFFIX
  - Use ETCDIR
  
  PR:	ports/175785
  Approved by:	maintainer timeout (2 weeks)

Modified:
  head/graphics/renrot/Makefile   (contents, props changed)

Modified: head/graphics/renrot/Makefile
==============================================================================
--- head/graphics/renrot/Makefile	Sun Feb 17 10:43:22 2013	(r312410)
+++ head/graphics/renrot/Makefile	Sun Feb 17 11:27:07 2013	(r312411)
@@ -25,14 +25,13 @@ PORTDOCS=	AUTHORS README ChangeLog NEWS 
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MIMAGEMAGICK}
-RUN_DEPENDS+=	${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm:${PORTSDIR}/graphics/ImageMagick
+RUN_DEPENDS+=	convert:${PORTSDIR}/graphics/ImageMagick
 .endif
 
 post-install:
-	@${MKDIR} ${PREFIX}/etc/${PORTNAME}
+	@${MKDIR} ${ETCDIR}
 .for conf in colors.conf copyright.tag renrot.conf tags.conf
-	${INSTALL_DATA} ${WRKSRC}/etc/${conf} \
-		${PREFIX}/etc/${PORTNAME}/${conf}.sample
+	${INSTALL_DATA} ${WRKSRC}/etc/${conf} ${ETCDIR}/${conf}.sample
 .endfor
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Alex Kozlov freebsd_committer freebsd_triage 2013-02-17 11:28:35 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!