Bug 176140 - [patch] comms/minicom: Correct Previous NOPORTDOCS Logic
Summary: [patch] comms/minicom: Correct Previous NOPORTDOCS Logic
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 10:20 UTC by jarrod
Modified: 2013-02-16 16:50 UTC (History)
0 users

See Also:


Attachments
comms-minicom-PORT_OPTIONS.diff (575 bytes, patch)
2013-02-14 10:20 UTC, jarrod
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jarrod 2013-02-14 10:20:00 UTC
The recent commit to comms/minicom r311786 appears to have slightly incorrect
logic around the change from NOPORTDOCS to PORT_OPTIONS:MDOCS.  If true, the
former prevents port documentation from being installed however the latter
allows the documentation to be installed.

The condition on line 63 was not changed resulting in the evaluation being
the inverse, i.e. port documentation being installed when explicitly told
not to, and not being installed when told to.

Attach patch drops the wayward ! symbol.

Fix: Patch can also be downloaded from:
http://www.downtools.com.au/~jarrod/FreeBSD/comms-minicom-PORT_OPTIONS.diff
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-14 10:20:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->johans

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-02-16 16:47:57 UTC
Author: johans
Date: Sat Feb 16 16:47:45 2013
New Revision: 312375
URL: http://svnweb.freebsd.org/changeset/ports/312375

Log:
  Correct Previous NOPORTDOCS Logic
  
  PR:		ports/176140
  Submitted by:	Jarrod Sayers <jarrod@downtools.com.au>

Modified:
  head/comms/minicom/Makefile

Modified: head/comms/minicom/Makefile
==============================================================================
--- head/comms/minicom/Makefile	Sat Feb 16 16:43:41 2013	(r312374)
+++ head/comms/minicom/Makefile	Sat Feb 16 16:47:45 2013	(r312375)
@@ -60,7 +60,7 @@ post-install:
 	${CHMOD} 4511 ${PREFIX}/bin/minicom
 	${INSTALL} -d -o root -g wheel -m 0755 ${PREFIX}/etc/minicom
 	${CHOWN} uucp ${PREFIX}/etc/minicom
-.if !${PORT_OPTIONS:MDOCS}
+.if ${PORT_OPTIONS:MDOCS}
 	${INSTALL} -d -o root -g wheel -m 0755 ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/AUTHORS ${DOCSDIR}/
 	${INSTALL_DATA} ${WRKSRC}/COPYING ${DOCSDIR}/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Johan van Selst freebsd_committer freebsd_triage 2013-02-16 16:48:07 UTC
State Changed
From-To: open->closed

That was a silly mistake. Thanks for the report. Patch committed.