Bug 176395 - deskutils/dailystrips port update appears to be a downgrade
Summary: deskutils/dailystrips port update appears to be a downgrade
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-24 15:40 UTC by kritek
Modified: 2013-02-25 00:40 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kritek 2013-02-24 15:40:01 UTC 
deskutils/dailystrips port was recently updated to port version 1.1.0 from 1.0.28.

In port and dailystrips version 1.0.28, the main program was dailystrips.pl.

In port and dailystrips version 1.1.0, that program does not exist.

If the port versions are supposed to reflect the dailystrips versions, then the port upgrade is actually a downgrade to a version two years older than the current version available, 1.0.28.

As shown on http://dailystrips.sourceforge.net/download.html, 1.1.0 is a devel release from April 2001, 1.0.28 is the current release, from August 2003.

Also, the documentation put into /usr/local/share/doc/dailystrips makes reference to dailystrips.pl, which doesn't exist in port and dailystrips version 1.1.0.

Fix: 

Revert back to dailystrips version 1.0.28.
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2013-02-24 15:48:08 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jgh

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-02-25 00:38:25 UTC 
Author: jgh
Date: Mon Feb 25 00:38:18 2013
New Revision: 312895
URL: http://svnweb.freebsd.org/changeset/ports/312895

Log:
  - revert downgrade in r312750, add PORTEPOCH
  - while here convert to optionsNG for DOCS, add LICENSE
  - add portscout limitation for production version
  
  PR:		176395
  Submitted by:	kritek@gmail.com

Modified:
  head/deskutils/dailystrips/Makefile
  head/deskutils/dailystrips/distinfo

Modified: head/deskutils/dailystrips/Makefile
==============================================================================
--- head/deskutils/dailystrips/Makefile	Mon Feb 25 00:07:56 2013	(r312894)
+++ head/deskutils/dailystrips/Makefile	Mon Feb 25 00:38:18 2013	(r312895)
@@ -2,7 +2,8 @@
 # $FreeBSD$
 
 PORTNAME=	dailystrips
-PORTVERSION=	1.1.0
+PORTVERSION=	1.0.28
+PORTEPOCH=	1
 CATEGORIES=	deskutils www
 MASTER_SITES=	SF
 
@@ -18,29 +19,32 @@ NO_BUILD=	yes
 USE_PERL5=	yes
 
 PORTDOCS=	*
-PLIST_FILES=	bin/getstrips.pl \
-		bin/makepage.pl \
-		bin/shared_functions.pl \
+PLIST_FILES=	bin/dailystrips \
+		bin/dailystrips-clean \
+		bin/dailystrips-update \
 		share/dailystrips/strips.def
 PLIST_DIRS=	share/dailystrips
 
-post-patch-script:
+PORTSCOUT=	limit:1.0.*$$
+
+post-patch:
 	@${REINPLACE_CMD} 's|^#!/usr/bin/perl|#!${PERL}|; \
-		s!strips.def!${DATADIR}/strips.def!; \
-		s!robotman!!; \
-		s!shared_functions.pl!${PREFIX}/bin/shared_functions.pl!' \
-		${WRKSRC}/getstrips.pl ${WRKSRC}/makepage.pl \
-		${WRKSRC}/strips.def
+		s!/usr/share/dailystrips/strips.def!${DATADIR}/strips.def!' \
+		${WRKSRC}/dailystrips ${WRKSRC}/dailystrips-clean \
+		${WRKSRC}/dailystrips-update
 
 .include <bsd.port.options.mk>
 
 do-install:
-	${INSTALL_SCRIPT} ${WRKSRC}/*.pl ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKSRC}/dailystrips ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKSRC}/dailystrips-clean ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKSRC}/dailystrips-update ${PREFIX}/bin
 	@${MKDIR} ${DATADIR}
 	${INSTALL_SCRIPT} ${WRKSRC}/strips.def ${DATADIR}
 .if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
-.for file in README README.DEFS README.LOCAL archive.html
+.for file in README README.DEFS README.LOCAL README.dailystrips-clean \
+    README.dailystrips-update
 	${INSTALL_DATA} ${WRKSRC}/${file} ${DOCSDIR}
 .endfor
 .endif

Modified: head/deskutils/dailystrips/distinfo
==============================================================================
--- head/deskutils/dailystrips/distinfo	Mon Feb 25 00:07:56 2013	(r312894)
+++ head/deskutils/dailystrips/distinfo	Mon Feb 25 00:38:18 2013	(r312895)
@@ -1,2 +1,2 @@
-SHA256 (dailystrips-1.1.0.tar.gz) = 4de31c6e7e9fecd634f35a5a407dbc266f0f29cf79e391459697bea8e4751631
-SIZE (dailystrips-1.1.0.tar.gz) = 29740
+SHA256 (dailystrips-1.0.28.tar.gz) = dc54d8559d378fb4115a5605cff5d0e45a69f6ed1539f4aa31d6e13231c362ca
+SIZE (dailystrips-1.0.28.tar.gz) = 58713
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2013-02-25 00:38:35 UTC 
State Changed
From-To: open->closed

Committed. Thanks!