Bug 176459 - [patch] Update COMMENT and pkg-descr for devel/astyle
Summary: [patch] Update COMMENT and pkg-descr for devel/astyle
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-27 00:30 UTC by Kevin Zheng
Modified: 2013-04-19 04:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.60 KB, patch)
2013-02-27 00:30 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2013-02-27 00:30:00 UTC
Update COMMENT and pkg-descr for devel/astyle. While here,
 - Trim Makefile header.
 - Eradicate evil NOPORTDOCS in favor of OptionsNG.

Also, I was wondering whether it was possible to make GCC just a BUILD_DEPENDS. Right now astyle pulls in a bunch of GCC-related dependencies even when I install it from a binary package.

Does Clang fix the UTF-8 compile issue as well?

Fix: Apply the attached patch (generated by `svn diff`).

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-02-27 00:30:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lme

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Kevin Zheng 2013-04-16 22:44:54 UTC
Greetings,

I'm just looking for a quick status update on this PR. No major changes
were made with this patch, just some descriptive changes and an update
to use the new options framework. I know things are pretty busy
considering the recent ports slush; I'd just like to make sure I didn't
fall through a crack somewhere.

Thanks,
Kevin Zheng
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-04-19 03:54:17 UTC
Author: eadler
Date: Fri Apr 19 02:54:09 2013
New Revision: 316082
URL: http://svnweb.freebsd.org/changeset/ports/316082

Log:
  - Convert to OptionsNG
  - Strip header
  - Remove leading article
  - Better pkg-descr
  
  PR:		ports/176459
  Submitted by:	Kevin Zheng <kevinz5000@gmail.com>
  Approved by:	maintainer timeout (> 1 month)
  Feature safe:	yes

Modified:
  head/devel/astyle/Makefile
  head/devel/astyle/pkg-descr

Modified: head/devel/astyle/Makefile
==============================================================================
--- head/devel/astyle/Makefile	Thu Apr 18 23:40:38 2013	(r316081)
+++ head/devel/astyle/Makefile	Fri Apr 19 02:54:09 2013	(r316082)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	astyle
-# Date created:		31 Jan 1999
-# Whom:			Don Croyle <croyle@gelemna.org>
-#
+# Created by: Don Croyle <croyle@gelemna.org>
 # $FreeBSD$
-#
 
 PORTNAME=	astyle
 PORTVERSION=	2.02.1
@@ -12,7 +8,7 @@ MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}
 DISTNAME=	${PORTNAME}_${PORTVERSION}_linux
 
 MAINTAINER=	lme@FreeBSD.org
-COMMENT=	A reindenter and reformatter of C, C++, C\#, and Java source code
+COMMENT=	Source code indenter and formatter for C, C++, C\#, and Java
 
 ALL_TARGET=	astyle
 CFLAGS+=	-W -Wall -fno-rtti -fno-exceptions
@@ -26,14 +22,16 @@ WRKSRC=		${WRKDIR}/astyle/build/gcc
 pre-patch:
 	@${REINPLACE_CMD} -e 's,^CFLAGS,#CFLAGS,; s,g++,${CXX},;' ${WRKSRC}/Makefile
 
+.include <bsd.port.options.mk>
+
 PLIST_FILES=	bin/astyle
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 PORTDOCS=	*
 .endif
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/bin/astyle ${PREFIX}/bin
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKDIR}/astyle/doc/*.html ${DOCSDIR}
 .endif

Modified: head/devel/astyle/pkg-descr
==============================================================================
--- head/devel/astyle/pkg-descr	Thu Apr 18 23:40:38 2013	(r316081)
+++ head/devel/astyle/pkg-descr	Fri Apr 19 02:54:09 2013	(r316082)
@@ -1,3 +1,5 @@
-Artistic Style is a variant on indent that can handle C, C++ and Java source.
+Artistic Style is a source code indenter, formatter, and beautifier for the C,
+C++, C# and Java programming languages. It automatically re-indents and
+re-formats source files and can be used from a command line.
 
 WWW: http://astyle.sourceforge.net/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2013-04-19 03:54:48 UTC
State Changed
From-To: open->closed

Committed. Thanks!