Bug 176587 - [PATCH] mail/dcc-dccd: syntax error in makefile; breaks bmake
Summary: [PATCH] mail/dcc-dccd: syntax error in makefile; breaks bmake
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Eitan Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-01 15:20 UTC by John Marino
Modified: 2013-03-21 16:10 UTC (History)
0 users

See Also:

Attachments
file.diff (357 bytes, patch)
2013-03-01 15:20 UTC, John Marino 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2013-03-01 15:20:00 UTC 
In mail/dcc-dccd, there is a syntax error in the Makefile on line 180.  Three single quotes are used in an echo statement.

legacy make tolerates it; bmake does not.
Patch attached.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-01 15:20:07 UTC 
Maintainer of mail/dcc-dccd,

Please note that PR ports/176587 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176587

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-01 15:20:08 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Eitan Adler freebsd_committer freebsd_triage 2013-03-21 15:58:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->eadler

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-03-21 16:02:11 UTC 
Author: eadler
Date: Thu Mar 21 16:02:03 2013
New Revision: 314852
URL: http://svnweb.freebsd.org/changeset/ports/314852

Log:
  Fix tripple quoting that will cause problems when the ports tree is switched to bmake
  
  PR:		ports/176587
  Submitted by:	John Marino <draco@marino.st>

Modified:
  head/mail/dcc-dccd/Makefile

Modified: head/mail/dcc-dccd/Makefile
==============================================================================
--- head/mail/dcc-dccd/Makefile	Thu Mar 21 15:45:59 2013	(r314851)
+++ head/mail/dcc-dccd/Makefile	Thu Mar 21 16:02:03 2013	(r314852)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	mail/dcc-dccd
-# Date created:		Wed Oct 9 19:30:00 WST 2002
-# Whom:			Dean Hollister <dean@odyssey.apana.org.au>
-#
+# Created by: Dean Hollister <dean@odyssey.apana.org.au>
 # $FreeBSD$
-#
 
 PORTNAME=	dcc-dccd
 PORTVERSION=	1.3.141
@@ -177,7 +173,7 @@ PLIST_SUB+=	WITH_DCCGREY="@comment "
 
 pre-everything::
 	@${ECHO_MSG} ' '
-	@${ECHO_MSG} 'A description of ALT_HOME may be found in the port's Makefile.'
+	@${ECHO_MSG} "A description of ALT_HOME may be found in the port's Makefile."
 	@${ECHO_MSG} ' '
 
 post-install:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2013-03-21 16:02:24 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!