Bug 176618 - [PATCH] print/hplip: support for lj.so plugin
Summary: [PATCH] print/hplip: support for lj.so plugin
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-03 16:20 UTC by Thomas Quinot
Modified: 2013-07-14 20:40 UTC (History)
0 users

See Also:


Attachments
file.diff (1.28 KB, patch)
2013-03-03 16:20 UTC, Thomas Quinot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Quinot freebsd_committer freebsd_triage 2013-03-03 16:20:01 UTC
	This is a proposal to introduce a change in the hpijs driver
	to allow loading a binary-only plugin provided by HP allowing
	to print to a variety of consumer-grade printers.

	The plugin is a Linux shared object, but it depends on few enough
	interfaces that it can actually run unmodified on a FreeBSD system,
	provided that symbol "stderr" is made available.

Fix: Add the following patch to port print/hplib:
Comment 1 Thomas Quinot freebsd_committer freebsd_triage 2013-03-03 16:58:32 UTC
Responsible Changed
From-To: freebsd-ports-bugs->makc

Over to port maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-07-12 17:37:03 UTC
Author: makc
Date: Fri Jul 12 16:36:50 2013
New Revision: 322855
URL: http://svnweb.freebsd.org/changeset/ports/322855

Log:
  Add support for HPLIP binary plugins.
  
  The plugin is a Linux shared object, but it depends on few enough
  interfaces that it can actually run unmodified on a FreeBSD system.
  
  PR:		ports/176618
  Submitted by:	thomas

Added:
  head/print/hplip/files/patch-hplip-plugin   (contents, props changed)
Modified:
  head/print/hplip/Makefile

Modified: head/print/hplip/Makefile
==============================================================================
--- head/print/hplip/Makefile	Fri Jul 12 16:35:01 2013	(r322854)
+++ head/print/hplip/Makefile	Fri Jul 12 16:36:50 2013	(r322855)
@@ -3,7 +3,7 @@
 
 PORTNAME=	hplip
 PORTVERSION=	3.13.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	print
 MASTER_SITES=	SF
 

Added: head/print/hplip/files/patch-hplip-plugin
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/print/hplip/files/patch-hplip-plugin	Fri Jul 12 16:36:50 2013	(r322855)
@@ -0,0 +1,35 @@
+diff -ru hplip-3.11.12.DIST/Makefile.in hplip-3.11.12/Makefile.in
+--- Makefile.in	2011-12-09 12:23:55.000000000 +0100
++++ Makefile.in	2011-12-30 16:28:26.255313535 +0100
+@@ -503,7 +503,7 @@
+ @HPIJS_INSTALL_TRUE@@HPLIP_BUILD_TRUE@	$(am__DEPENDENCIES_1)
+ hpijs_LINK = $(LIBTOOL) --tag=CXX $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) \
+ 	--mode=link $(CXXLD) $(hpijs_CXXFLAGS) $(CXXFLAGS) \
+-	$(AM_LDFLAGS) $(LDFLAGS) -o $@
++	$(AM_LDFLAGS) $(LDFLAGS) -Wl,--export-dynamic -o $@
+ am__hplipjs_SOURCES_DIST = prnt/filters/hplipjs.c
+ @FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE@am_hplipjs_OBJECTS =  \
+ @FULL_BUILD_TRUE@@HPLIP_BUILD_TRUE@	hplipjs.$(OBJEXT)
+Only in hplip-3.11.12: dd
+diff -ru hplip-3.11.12.DIST/prnt/hpijs/hpijs.cpp hplip-3.11.12/prnt/hpijs/hpijs.cpp
+--- prnt/hpijs/hpijs.cpp	2011-12-09 12:18:33.000000000 +0100
++++ prnt/hpijs/hpijs.cpp	2011-12-30 16:27:10.976752128 +0100
+@@ -43,6 +43,9 @@
+ #include "hpijs.h"
+ #include "services.h"
+ 
++#undef stderr;
++FILE *stderr;
++
+ extern void SendDbusMessage (const char *dev, const char *printer, int code, 
+                              const char *username, const int jobid, const char *title);
+ 
+@@ -586,6 +589,7 @@
+    int status = EXIT_FAILURE;
+    int ret, n, i, kn=0, width, k_width;
+ 
++   stderr = __stderrp;
+    openlog("hpijs", LOG_PID,  LOG_DAEMON);
+ 
+    if (argc > 1)
+
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2013-07-12 17:38:05 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 Mark Linimon 2013-07-14 20:30:09 UTC
----- Forwarded message from Max Brazhnikov <makc@freebsd.org> -----

Date: Sun, 14 Jul 2013 17:24:24 +0000
From: Max Brazhnikov <makc@freebsd.org>
To: Thomas Quinot <thomas@freebsd.org>
Cc: freebsd-ports-bugs@freebsd.org
Subject: Re: ports/176618: [PATCH] print/hplip: support for lj.so plugin
User-Agent: KMail/4.10.5 (FreeBSD/9.1-STABLE; KDE/4.10.5; amd64; ; )

On Sun, 07 Apr 2013 16:29:12 +0200 Thomas Quinot wrote:
> * Max Brazhnikov, 2013-03-04 :
> 
> > I've got a port for hplip-plugin [1], but I don't have a printer to test it.
> > Could you give it a try?
> 
> Max,
> 
> I at last got time to try your hplip-plugin port, in conjunction with my
> patch, and I am happy to report success!

Thanks Thomas!

Sorry it it took so long from side to commit the port and your patch.

Btw, does hplip-plugin need linux compatibility enabled, and if so, does it work
on amd64 systems?

Max
_______________________________________________
freebsd-ports-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"

----- End forwarded message -----