Bug 176725 - devel/doxygen: rename and disable options
Summary: devel/doxygen: rename and disable options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 12:10 UTC by Max Brazhnikov
Modified: 2013-03-07 19:30 UTC (History)
0 users

See Also:


Attachments
file.diff (3.01 KB, patch)
2013-03-07 12:10 UTC, Max Brazhnikov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Brazhnikov freebsd_committer freebsd_triage 2013-03-07 12:10:00 UTC
doxygen is widely used to generate documentation, with all options enabled it's
too heavy and maintainers avoid using it. To make doxygen more attractive I propose to rename and disable all options by default.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-07 12:10:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-07 12:10:08 UTC
Maintainer of devel/doxygen,

Please note that PR ports/176725 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176725

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Naram Qashat 2013-03-07 18:21:01 UTC
On 03/07/13 07:10, Edwin Groothuis wrote:
> Maintainer of devel/doxygen,
>
> Please note that PR ports/176725 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>      http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176725
>

I approve of this.

Naram Qashat
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2013-03-07 18:55:39 UTC
State Changed
From-To: feedback->open

Maintainer approved 


Comment 5 Beech Rintoul freebsd_committer freebsd_triage 2013-03-07 18:55:39 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-03-07 19:05:02 UTC
Author: makc
Date: Thu Mar  7 19:04:54 2013
New Revision: 313602
URL: http://svnweb.freebsd.org/changeset/ports/313602

Log:
  - Rename options: DOCS -> HTMLDOCS, LATEX -> PDFDOCS, DOXYWIZARD -> QT4
  - Disable all options by default
  
  PR:		ports/176725
  Approved by:	Naram Qashat (maintainer)

Modified:
  head/devel/doxygen/Makefile   (contents, props changed)

Modified: head/devel/doxygen/Makefile
==============================================================================
--- head/devel/doxygen/Makefile	Thu Mar  7 18:31:55 2013	(r313601)
+++ head/devel/doxygen/Makefile	Thu Mar  7 19:04:54 2013	(r313602)
@@ -3,6 +3,7 @@
 
 PORTNAME=	doxygen
 PORTVERSION=	1.8.3.1
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	ftp://ftp.stack.nl/pub/users/dimitri/ \
 		http://ftp.stack.nl/pub/users/dimitri/
@@ -39,41 +40,42 @@ TMPDOCDEST=	${WRKDIR}/tmpdocdest
 
 PLIST_FILES=	bin/doxygen
 
-OPTIONS_DEFINE=	DOCS DOXYWIZARD LATEX
-OPTIONS_DEFAULT=DOCS DOXYWIZARD LATEX
-DOXYWIZARD_DESC=	Doxywizard support (requires Qt4)
+OPTIONS_DEFINE=	HTMLDOCS QT4 PDFDOCS
+QT4_DESC=	Install Doxywizard GUI
+HTMLDOCS_DESC=	Install documentation in HTML format
+PDFDOCS_DESC=	Install documentation in PDF format
 
 .include <bsd.port.options.mk>
 
-.if ${PORT_OPTIONS:MDOCS}
+.if ${PORT_OPTIONS:MHTMLDOCS}
 ALL_TARGET+=	docs
 USE_PYTHON_BUILD=	yes
 BUILD_DEPENDS+=	dot:${PORTSDIR}/graphics/graphviz
 
-.if ${PORT_OPTIONS:MLATEX}
+.if ${PORT_OPTIONS:MPDFDOCS}
 ALL_TARGET+=	pdf
 BUILD_DEPENDS+=	latex:${PORTSDIR}/print/teTeX
 USE_GHOSTSCRIPT_BUILD=	yes
-MAKE_ARGS+=	HAVE_LATEX=yes
-.endif # LATEX
-.endif # DOCS
+MAKE_ARGS+=	HAVE_PDFDOCS=yes
+.endif # PDFDOCS
+.endif # HTMLDOCS
 
-.if ${PORT_OPTIONS:MDOXYWIZARD}
+.if ${PORT_OPTIONS:MQT4}
 USE_QT4=	corelib gui xml qmake_build moc_build rcc_build
 
 # Need this in env for build
 QTDIR?=		${QT_PREFIX}
 CONFIGURE_ENV=	QTDIR="${QTDIR}"
 CONFIGURE_ARGS+=--with-doxywizard
-.endif # DOXYWIZARD
+.endif # QT4
 
 .if ${MACHINE_ARCH:L} == alpha
 CONFIGURE_ARGS+=	--enable-langs no
 .endif
 
-.if ${PORT_OPTIONS:MDOXYWIZARD}
+.if ${PORT_OPTIONS:MQT4}
 PLIST_FILES+=	bin/doxywizard
-.endif # DOXYWIZARD
+.endif # QT4
 
 pre-configure:
 	@cd ${WRKSRC};for pro in src/*.pro.in addon/doxywizard/doxywizard.pro.in;do \
@@ -93,7 +95,7 @@ post-build:
 pre-install:
 	${RM} -rf ${TMPDOCDEST} ${PLIST}
 	${TOUCH} ${PLIST}
-.if ${PORT_OPTIONS:MDOCS}
+.if ${PORT_OPTIONS:MHTMLDOCS}
 	${MKDIR} ${TMPDOCDEST}/doxygen
 	${RM} -f ${WRKSRC}/examples/diagrams/html/*.md5 \
 		 ${WRKSRC}/examples/diagrams/html/*.map
@@ -102,27 +104,27 @@ pre-install:
 	${TAR} -C ${WRKSRC} --exclude '*/Makefile*' --exclude '*.dot' \
 		-cf - examples \
 		| ${TAR} -C ${TMPDOCDEST}/doxygen --unlink -xf -
-.if ${PORT_OPTIONS:MLATEX}
+.if ${PORT_OPTIONS:MPDFDOCS}
 	${INSTALL_DATA} ${WRKSRC}/latex/doxygen_manual.pdf \
 			${WRKSRC}/latex/archoverview.eps \
 			${TMPDOCDEST}/doxygen
-.endif # LATEX
+.endif # PDFDOCS
 	@cd ${TMPDOCDEST} \
 	&& ${FIND} -s * -type f -o -type l \
 		| ${SED} -e 's|^|share/doc/|' >> ${PLIST} \
 	&& ${FIND} -d * -type d \
 		| ${SED} -e 's|^|@dirrm share/doc/|' >> ${PLIST}
-.endif # DOCS
+.endif # HTMLDOCS
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/bin/doxygen ${PREFIX}/bin/
-.if ${PORT_OPTIONS:MDOXYWIZARD}
+.if ${PORT_OPTIONS:MQT4}
 	${INSTALL_PROGRAM} ${WRKSRC}/bin/doxywizard ${PREFIX}/bin/
-.endif # DOXYWIZARD
-.if ${PORT_OPTIONS:MDOCS}
+.endif # QT4
+.if ${PORT_OPTIONS:MHTMLDOCS}
 	${MKDIR} ${PREFIX}/share/doc/doxygen
 	${TAR} -C ${TMPDOCDEST} -cf - doxygen \
 		| ${TAR} -C ${PREFIX}/share/doc --unlink -xf -
-.endif # DOCS
+.endif # HTMLDOCS
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2013-03-07 19:06:29 UTC
State Changed
From-To: open->closed

Committed.