Simple clang build fix Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Maintainer of audio/dvda-author, Please note that PR ports/176766 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/176766 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
results in "cc -std=gnu99 -std=gnu89 ..." but seems no problem
Responsible Changed From-To: miwi->pawel submitter is committer.
>results in "cc -std=gnu99 -std=gnu89 ..." >but seems no problem Hmm right, didn't look at buildlogs close enough. Here's improved version which cleanups build flags for entire build and uses USE_CSTD macro as it supposed to in the first place. While here I also allowed myself to convert option check to new options framework. Do you approve? -- pozdrawiam / with regards Pawe³ Pêkala
now it's "cc -std=gnu89 -O2 -pipe -fno-strict-aliasing -std=gnu89 ..." but I wouldn't care ...
Author: pawel Date: Wed Mar 13 15:31:03 2013 New Revision: 314091 URL: http://svnweb.freebsd.org/changeset/ports/314091 Log: - Respect CFLAGS - Fix build with clang - Convert to OptionsNG - Trim Makefile header PR: ports/176766 Submitted by: myself Approved by: Martin Dieringer <martin.dieringer@gmx.de> (maintainer) Modified: head/audio/dvda-author/Makefile (contents, props changed) Modified: head/audio/dvda-author/Makefile ============================================================================== --- head/audio/dvda-author/Makefile Wed Mar 13 15:29:55 2013 (r314090) +++ head/audio/dvda-author/Makefile Wed Mar 13 15:31:03 2013 (r314091) @@ -1,9 +1,5 @@ -# New ports collection makefile for: dvda-author -# Date created: 9 October 2007 -# Whom: dieringe@zedat.fu-berlin.de -# +# Created by: dieringe@zedat.fu-berlin.de # $FreeBSD$ -# PORTNAME= dvda-author PORTVERSION= 09.05 @@ -34,8 +30,19 @@ GNU_CONFIGURE= yes CONFIGURE_ARGS= --with-flac=${LOCALBASE}/lib/libFLAC.so \ --with-ogg=${LOCALBASE}/lib/libogg.so \ --enable-glibc -.if defined(NOPORTDOCS) +USE_CSTD= gnu89 + +.include <bsd.port.options.mk> + +.if ! ${PORT_OPTIONS:MDOCS} CONFIGURE_ARGS+= --docdir=${WRKDIR}/doc .endif +post-patch: + @${REINPLACE_CMD} 's|-std=c99||g' \ + ${WRKSRC}/configure \ + ${WRKSRC}/libats2wav/Makefile.in + @${REINPLACE_CMD} 's|-std=c99 -O3||' \ + ${WRKSRC}/fixwav/src/Makefile.in + .include <bsd.port.mk> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!