Bug 177322 - [PATCH] graphics/imageindex: Convert to OptionsNG
Summary: [PATCH] graphics/imageindex: Convert to OptionsNG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-23 22:40 UTC by nemysis
Modified: 2014-03-03 16:40 UTC (History)
1 user (show)

See Also:


Attachments
imageindex-1.1_5.patch (1.64 KB, patch)
2013-03-23 22:40 UTC, nemysis
no flags Details | Diff
imageindex.diff (1.71 KB, patch)
2013-04-30 12:49 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-03-23 22:40:00 UTC
- Shorten header
- Convert to OptionsNG

Port maintainer (johnjen@reynoldsnet.org) is cc'd.

Generated and tested manually, tested with port test, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 22:40:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 22:40:09 UTC
Maintainer of graphics/imageindex,

Please note that PR ports/177322 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/177322

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-23 22:40:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2013-04-28 19:49:35 UTC
Does not build with new ImageMagick.

-- 
--------------------------------------------------------------------------------------- 
Beech Rintoul - Committer / Developer - beech@FreeBSD.org 
/"\ ASCII Ribbon Campaign | FreeBSD Since 4.x 
\ / - NO HTML/RTF in e-mail | http://www.freebsd.org 
 X  - NO Word docs in e-mail | Latest Release: 
/ \ - http://www.freebsd.org/releases/9.1R/announce.html
---------------------------------------------------------------------------------------
Comment 5 nemysis 2013-04-30 12:49:45 UTC
graphics/imageindex

https://redports.org/buildarchive/20130430104301-50294/

- Shorten header
- Trim comment
- Trim dependencies
- Convert to OptionsNG
Comment 6 Thomas Abthorpe freebsd_committer freebsd_triage 2014-01-10 03:32:22 UTC
Responsible Changed
From-To: beech->nemysis

Submitter is committer
Comment 7 Rusmir Dusko freebsd_committer freebsd_triage 2014-03-03 16:17:36 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 8 dfilter service freebsd_committer freebsd_triage 2014-03-03 16:37:11 UTC
Author: nemysis
Date: Mon Mar  3 16:37:04 2014
New Revision: 346929
URL: http://svnweb.freebsd.org/changeset/ports/346929
QAT: https://qat.redports.org/buildarchive/r346929/

Log:
  - Remove leading article from COMMENT
  - Use LIB_DEPENDS for graphics/jpeg
  - Change RUN_DEPENDS for graphics/ImageMagick and multimedia/mplayer
  - Support STAGEDIR
  - Add DOCS Option
  - Change typo | ;' to |'
  
  PR:		ports/177322
  Submitted by:	nemysis (self)
  Approved by:	maintainer timeout (11 months)

Modified:
  head/graphics/imageindex/Makefile

Modified: head/graphics/imageindex/Makefile
==============================================================================
--- head/graphics/imageindex/Makefile	Mon Mar  3 16:36:37 2014	(r346928)
+++ head/graphics/imageindex/Makefile	Mon Mar  3 16:37:04 2014	(r346929)
@@ -9,31 +9,27 @@ MASTER_SITES=	http://www.edwinh.org/imag
 		http://www.reynoldsnet.org/imageindex/release/
 
 MAINTAINER=	johnjen@reynoldsnet.org
-COMMENT=	A digital photo gallery tool
+COMMENT=	Digital photo gallery tool
 
-RUN_DEPENDS=	\
-	${LOCALBASE}/bin/Magick-config:${PORTSDIR}/graphics/ImageMagick \
-	${LOCALBASE}/bin/wrjpgcom:${PORTSDIR}/graphics/jpeg \
-	${LOCALBASE}/bin/mplayer:${PORTSDIR}/multimedia/mplayer \
-	p5-Image-Info>=0:${PORTSDIR}/graphics/p5-Image-Info
+LIB_DEPENDS=	libjpeg.so:${PORTSDIR}/graphics/jpeg
+RUN_DEPENDS=	convert:${PORTSDIR}/graphics/ImageMagick \
+		mplayer:${PORTSDIR}/multimedia/mplayer \
+		p5-Image-Info>=0:${PORTSDIR}/graphics/p5-Image-Info
 
 USES=		perl5
 USE_PERL5=	run
-MAKE_ARGS+=	PERLPATH=${PERL}
+MAKE_ARGS+=	PERLPATH=${PERL} PREFIX=${STAGEDIR}${PREFIX}
 
-PLIST_FILES=	bin/imageindex bin/autocaption
+PLIST_FILES=	bin/imageindex bin/autocaption \
+		man/man1/imageindex.1.gz
 PORTDOCS=	README
+OPTIONS_DEFINE=	DOCS
 
-MAN1=	imageindex.1
-
-NO_STAGE=	yes
 post-patch:
-	${REINPLACE_CMD} -e 's|share/man|man| ;' ${WRKSRC}/Makefile
+	${REINPLACE_CMD} -e 's|share/man|man|' ${WRKSRC}/Makefile
 
 post-install:
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
-.endif
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"