Bug 177481 - ftp/pure-ftpd start error when lang/perl5.14 has unset USE_PERL
Summary: ftp/pure-ftpd start error when lang/perl5.14 has unset USE_PERL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-29 17:00 UTC by Lukasz Wasikowski
Modified: 2013-05-06 18:20 UTC (History)
0 users

See Also:

Attachments
file.diff (431 bytes, patch)
2013-03-29 17:00 UTC, Lukasz Wasikowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Wasikowski 2013-03-29 17:00:00 UTC 
When lang/perl5.14 is installed without USE_PERL knob then perl binaries are at:

/usr/local/bin/perl
/usr/local/bin/perl5

and there's no symlinks to those in /usr/bin

ftp/pure-ftpd's config parser /usr/local/sbin/pure-config.pl use /usr/bin/env perl as shebang.

When pure-ftpd is started by invoking /usr/local/etc/rc.d/pure-ftpd script everything works ok, as /usr/bin/env perl is expanded to /usr/local/bin/perl

But when pure-ftpd is started by invoking service pure-ftpd start /usr/local/bin is not searched and startup fails.

Fix: Attached patch should help.

Patch attached with submission follows:
How-To-Repeat: Install lang/perl5.14 with OPTIONS_FILE_UNSET+=USE_PERL

# /usr/local/etc/rc.d/pure-ftpd start
Starting pureftpd.

This worked. Stop the daemon:

# /usr/local/etc/rc.d/pure-ftpd stop
Stopping pureftpd.
Waiting for PIDS: 45876.

Start it via service:

# service pure-ftpd start
Starting pureftpd.
env: perl: No such file or directory
/usr/local/etc/rc.d/pure-ftpd: WARNING: failed to start pureftpd
Comment 1 Lukasz Wasikowski 2013-03-29 22:03:53 UTC 
Wrong category, please move it to ports-bugs. Sorry for the trouble,
thank you in advance.

-- 
best regards,
Lukasz Wasikowski
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2013-03-29 22:32:15 UTC 
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

ports PR.
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-03-29 22:32:32 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->sunpoet

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-05-06 18:16:17 UTC 
Author: sunpoet
Date: Mon May  6 17:16:05 2013
New Revision: 317533
URL: http://svnweb.freebsd.org/changeset/ports/317533

Log:
  - Fix shebang line for users without USE_PERL=yes
  
  PR:		ports/177481
  Submitted by:	Lukasz Wasikowski <lukasz@wasikowski.net>

Modified:
  head/ftp/pure-ftpd/Makefile

Modified: head/ftp/pure-ftpd/Makefile
==============================================================================
--- head/ftp/pure-ftpd/Makefile	Mon May  6 16:57:13 2013	(r317532)
+++ head/ftp/pure-ftpd/Makefile	Mon May  6 17:16:05 2013	(r317533)
@@ -167,8 +167,7 @@ pre-fetch:
 	@${ECHO_MSG} ""
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|$${exec_prefix}|${PREFIX}|g' \
-		${WRKSRC}/configuration-file/pure-config.pl.in
+	@${REINPLACE_CMD} -e 's|@PERL@|${PERL}|; s|$${exec_prefix}|${PREFIX}|g' ${WRKSRC}/configuration-file/pure-config.pl.in
 
 post-install:
 	${INSTALL_DATA} ${WRKSRC}/pureftpd-ldap.conf ${PREFIX}/etc/pureftpd-ldap.conf.sample
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2013-05-06 18:19:29 UTC 
State Changed
From-To: open->closed

Committed. Thanks!