When installing the unix2dos port, clang warns on implicit declaration of the exit function. clang -O2 -pipe -o unix2dos unix2dos.c unix2dos.c:59:5: warning: implicitly declaring library function 'exit' with t exit(1); ^ unix2dos.c:59:5: note: please include the header <stdlib.h> or explicitly pro 1 warning generated. ln -f unix2dos dos2unix Fix: Trivial fix is to simply add #include <stdlib.h> to unix2dos.c. Do not know who owns upstream. Patch attached with submission follows: How-To-Repeat: Using clang as the compiler, install the converters/unix2dos port.
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Maintainer of converters/unix2dos, Please note that PR ports/178251 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178251 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: feedback->closed Committed, thanks!
Responsible Changed From-To: freebsd-ports-bugs->thierry Take it.
Author: thierry Date: Mon Jan 27 21:46:48 2014 New Revision: 341459 URL: http://svnweb.freebsd.org/changeset/ports/341459 QAT: https://qat.redports.org/buildarchive/r341459/ Log: Fix an implicit declaration of the exit function. PR: ports/178251 Submitted by: Chad Slater <chad.slater (at) gmail.com> Approved by: maintainer time-out (8 months) Added: head/converters/unix2dos/files/ head/converters/unix2dos/files/patch-unix2dos.c (contents, props changed) Added: head/converters/unix2dos/files/patch-unix2dos.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/converters/unix2dos/files/patch-unix2dos.c Mon Jan 27 21:46:48 2014 (r341459) @@ -0,0 +1,8 @@ +--- unix2dos.c.orig 2001-05-23 01:58:39.000000000 +0200 ++++ unix2dos.c 2014-01-27 22:41:13.000000000 +0100 +@@ -1,4 +1,5 @@ + #include <stdio.h> ++#include <stdlib.h> + #include <string.h> + #include <unistd.h> + #include <sys/types.h> _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"