Bug 178274 - [patch] audio/musicpd : add MDNSRESDPONDER port option
Summary: [patch] audio/musicpd : add MDNSRESDPONDER port option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-01 07:40 UTC by Matthieu Volat
Modified: 2013-05-04 16:50 UTC (History)
0 users

See Also:


Attachments
file.diff (955 bytes, patch)
2013-05-01 07:40 UTC, Matthieu Volat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2013-05-01 07:40:00 UTC
audio/musicpd port is only allowing to enable Avahi support while mDNSResponder support is possible in mpd, and only one option away.

Could it be added? I've attached a patch for the port Makefile.

Fix: apply/adapt provided patch to provide a radio choice for zeroconf support and allows to use mDNSResponder as choice of implementation.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/audio/musicpd && make config
-> only avahi option
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-01 07:40:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees freebsd_committer freebsd_triage 2013-05-04 16:41:46 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-05-04 16:41:49 UTC
Author: crees
Date: Sat May  4 15:41:40 2013
New Revision: 317325
URL: http://svnweb.freebsd.org/changeset/ports/317325

Log:
  audio/musicpd: Add support for bonjour/mDNSResponder
  
  PR:		ports/178274
  Submitted by:	Matthieu Volat <mazhe@alkumuna.eu>

Modified:
  head/audio/musicpd/Makefile

Modified: head/audio/musicpd/Makefile
==============================================================================
--- head/audio/musicpd/Makefile	Sat May  4 14:56:12 2013	(r317324)
+++ head/audio/musicpd/Makefile	Sat May  4 15:41:40 2013	(r317325)
@@ -34,9 +34,11 @@ PORTDOCS=	AUTHORS README COPYING NEWS UP
 
 SUB_FILES=	pkg-message
 
-OPTIONS_DEFINE=	ID3TAG IPV6 AVAHI FLAC VORBIS WAV FFMPEG TREMOR AAC \
+OPTIONS_DEFINE=	ID3TAG IPV6 FLAC VORBIS WAV FFMPEG TREMOR AAC \
 		MUSEPACK MIKMOD MODPLUG ARCHIVE MMS LASTFM AO PULSEAUDIO \
 		JACK SHOUTCAST SNDFILE LAME HTTPD SAMPLERATE CUE
+OPTIONS_RADIO=	ZEROCONF
+OPTIONS_RADIO_ZEROCONF=	AVAHI MDNSRESPONDER
 
 OPTIONS_DEFAULT=ID3TAG IPV6 FLAC VORBIS WAV FFMPEG SNDFILE 
 LAME_DESC=	Support for MP3 Icecast Streams
@@ -179,6 +181,13 @@ LIB_DEPENDS+=	avahi-client.3:${PORTSDIR}
 CONFIGURE_ARGS+=--with-zeroconf=no
 .endif
 
+.if ${PORT_OPTIONS:MMDNSRESPONDER}
+CONFIGURE_ARGS+=--with-zeroconf=bonjour
+LIB_DEPENDS+=	dns_sd:${PORTSDIR}/net/mDNSResponder
+.else
+CONFIGURE_ARGS+=--with-zeroconf=no
+.endif
+
 .if ${PORT_OPTIONS:MAO}
 CONFIGURE_ARGS+=--enable-ao
 LIB_DEPENDS+=	ao.4:${PORTSDIR}/audio/libao
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"