Bug 178501 - games/iceicepenguin: Needs different distfile subdir
Summary: games/iceicepenguin: Needs different distfile subdir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-11 08:30 UTC by John Marino
Modified: 2013-07-22 12:46 UTC (History)
0 users

See Also:


Attachments
iceicepenguin.diff (3.33 KB, patch)
2013-05-11 12:34 UTC, nemysis
no flags Details | Diff
iceicepenguin.diff (3.29 KB, patch)
2013-07-22 00:45 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2013-05-11 08:30:00 UTC
The latest update of games/iceicepenguin featured a re-rolling of "python/iceicepenguin_icons.zip".

This causes a fetch to fail if a previous version is there.  When this happens, a unique subdir for fetching is required.

Fix: 

It's unfortunate that upstream is re-using a filename
Change the subdir from "python" to something using a version number so python/iceicepenguin_icons.zip always goes in different directory when the game is updated.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-11 08:30:07 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-11 08:30:07 UTC
Maintainer of games/iceicepenguin,

Please note that PR ports/178501 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178501

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 nemysis 2013-05-11 12:34:40 UTC
games/iceicepenguin

https://redports.org/buildarchive/20130511101100-65232/

- Bump portrevision
- Fix download
- Trim desktop entry
- Cleanup Makefile
- Trim pkg-plist
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2013-05-12 23:28:31 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

- I'll take it
Comment 5 John Marino 2013-06-18 09:25:07 UTC
This port is now unfetchable and thus unbuildable.
Please mark it broken or update it.

I'm seeing the same fetch errors as shown in portsmon:
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.9.20130610065028.pointyhat/iceicepenguin-1.5.1_1.log
Comment 6 John Marino freebsd_committer freebsd_triage 2013-07-22 00:42:05 UTC
Responsible Changed
From-To: beech->marino

The submitted patch needs to be committed before it bitrots.
Comment 7 nemysis 2013-07-22 00:45:57 UTC
- Bump portrevision
- Fix download
- Trim desktop entry
- Cleanup Makefile
- Trim pkg-plist
Comment 8 dfilter service freebsd_committer freebsd_triage 2013-07-22 12:36:04 UTC
Author: marino
Date: Mon Jul 22 11:35:56 2013
New Revision: 323439
URL: http://svnweb.freebsd.org/changeset/ports/323439

Log:
  games/iceicepenguin: Fix fetching due to frequent rerolls
  
  The maintainer has proposed the following changes:
    1) Unique name for iceicepenguins_icons
    2) Trimmed desktop entry
    3) Updated the pkg-plist
    4) general cleanup
  
  PR:		ports/178501
  Submitted by:	marino
  Approved by:	bapt (mentor)

Modified:
  head/games/iceicepenguin/Makefile
  head/games/iceicepenguin/distinfo
  head/games/iceicepenguin/pkg-plist

Modified: head/games/iceicepenguin/Makefile
==============================================================================
--- head/games/iceicepenguin/Makefile	Mon Jul 22 09:24:01 2013	(r323438)
+++ head/games/iceicepenguin/Makefile	Mon Jul 22 11:35:56 2013	(r323439)
@@ -3,12 +3,12 @@
 
 PORTNAME=	iceicepenguin
 PORTVERSION=	1.5.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	games python
 MASTER_SITES=	SF/${PORTNAME}/Default/Ice%20Ice%20Penguin/ \
 		SF/nemysisfreebsdp/:icons
 DISTFILES=	iip.${DISTVERSION}-final${EXTRACT_SUFX} \
-		${PORTNAME}_icons${EXTRACT_SUFX}:icons
+		${PORTNAME}_icons_1${EXTRACT_SUFX}:icons
 DIST_SUBDIR=	python
 
 MAINTAINER=	nemysis@gmx.ch
@@ -31,22 +31,18 @@ ICON_SIZES=	32x32 48x48 64x64 72x72 96x9
 
 SUB_FILES=	${PORTNAME}
 
-DESKTOP_ENTRIES="Ice Ice Penguin" "${COMMENT}" \
-		"${PREFIX}/share/pixmaps/${PORTNAME}" \
+DESKTOP_ENTRIES="Ice Ice Penguin" "${COMMENT}" "${PORTNAME}" \
 		"${PORTNAME}" "Game;ArcadeGame;" false
 
 .include <bsd.port.options.mk>
 
 do-install:
-	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin/
+	${INSTALL_SCRIPT} ${WRKDIR}/${PORTNAME} ${PREFIX}/bin
 
-	${MKDIR} ${DATADIR}
-	${INSTALL_SCRIPT} ${WRKSRC}/*.py ${DATADIR}
-
-	${MKDIR} ${DATADIR}
 .for d in fonts gfx lvls menu sfx
 	@(cd ${WRKSRC} && ${COPYTREE_SHARE} ${d} ${DATADIR})
 .endfor
+	${INSTALL_SCRIPT} ${WRKSRC}/*.py ${DATADIR}
 
 post-install:
 .for s in ${ICON_SIZES}
@@ -54,10 +50,10 @@ post-install:
 	${INSTALL_DATA} ${WRKDIR}/${PORTNAME}_${s}.png \
 		${PREFIX}/share/icons/hicolor/${s}/apps/${PORTNAME}.png
 .endfor
-	${LN} -sf ${PREFIX}/share/icons/hicolor/48x48/apps/${PORTNAME}.png ${PREFIX}/share/pixmaps/
+	${LN} -sf ${PREFIX}/share/icons/hicolor/48x48/apps/${PORTNAME}.png ${PREFIX}/share/pixmaps
 
 .if ${PORT_OPTIONS:MDOCS}
-	${MKDIR} ${DOCSDIR}
+	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 

Modified: head/games/iceicepenguin/distinfo
==============================================================================
--- head/games/iceicepenguin/distinfo	Mon Jul 22 09:24:01 2013	(r323438)
+++ head/games/iceicepenguin/distinfo	Mon Jul 22 11:35:56 2013	(r323439)
@@ -1,4 +1,4 @@
 SHA256 (python/iip.1.5.1-final.zip) = 6fde1fc6b432951ed73c0f75c769d4550e5b4a014783bf49aaef24e904b7910e
 SIZE (python/iip.1.5.1-final.zip) = 17948605
-SHA256 (python/iceicepenguin_icons.zip) = 219aa78dec602446931d08c0461c65f18fa37526667713e58601741179d7123f
-SIZE (python/iceicepenguin_icons.zip) = 50315
+SHA256 (python/iceicepenguin_icons_1.zip) = 219aa78dec602446931d08c0461c65f18fa37526667713e58601741179d7123f
+SIZE (python/iceicepenguin_icons_1.zip) = 50315

Modified: head/games/iceicepenguin/pkg-plist
==============================================================================
--- head/games/iceicepenguin/pkg-plist	Mon Jul 22 09:24:01 2013	(r323438)
+++ head/games/iceicepenguin/pkg-plist	Mon Jul 22 11:35:56 2013	(r323439)
@@ -150,18 +150,6 @@ share/icons/hicolor/64x64/apps/iceicepen
 share/icons/hicolor/72x72/apps/iceicepenguin.png
 share/icons/hicolor/96x96/apps/iceicepenguin.png
 share/pixmaps/iceicepenguin.png
-@dirrmtry share/icons/hicolor/96x96/apps
-@dirrmtry share/icons/hicolor/96x96
-@dirrmtry share/icons/hicolor/72x72/apps
-@dirrmtry share/icons/hicolor/72x72
-@dirrmtry share/icons/hicolor/64x64/apps
-@dirrmtry share/icons/hicolor/64x64
-@dirrmtry share/icons/hicolor/48x48/apps
-@dirrmtry share/icons/hicolor/48x48
-@dirrmtry share/icons/hicolor/32x32/apps
-@dirrmtry share/icons/hicolor/32x32
-@dirrmtry share/icons/hicolor
-@dirrmtry share/icons
 @dirrm %%DATADIR%%/sfx/music
 @dirrm %%DATADIR%%/sfx
 @dirrm %%DATADIR%%/menu/fr
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 9 John Marino freebsd_committer freebsd_triage 2013-07-22 12:45:59 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!