>Number: 178525 >Category: ports >Synopsis: sysutils/less: correct the build option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 12 06:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Norihiko Murase >Release: >Organization: >Environment: >Description: Hey! Quick fix, please. I would like you to fix the bug related to the build option that resides in the port sysutils/less. This bug did slip into this port at SVN Revision 317890 (related PR: ports/178261) for the port update (451->458). Well, the bug is (probably) simple; the line .if ${PORT_OPTIONS:MCOLOUR_LESS} should be .if ${PORT_OPTIONS:MCOLOR_LESS} because the option named "COLOR_LESS" (NOT COLO*U*R_LESS) is defined as follows: OPTIONS_DEFINE= COLOR_LESS COLOR_LESS_DESC=Enables color support via escape sequence >How-To-Repeat: >Fix: diff -U 11 -r less_317890/Makefile less_cur/Makefile --- less_317890/Makefile 2013-05-12 14:35:43.000000000 +0900 +++ less_cur/Makefile 2013-05-12 14:38:54.000000000 +0900 @@ -15,19 +15,19 @@ OPTIONS_DEFINE= COLOR_LESS COLOR_LESS_DESC=Enables color support via escape sequence PLIST_FILES= bin/less bin/lesskey bin/lessecho .include <bsd.port.options.mk> GNU_CONFIGURE= yes MAN1= less.1 lesskey.1 lessecho.1 -.if ${PORT_OPTIONS:MCOLOUR_LESS} +.if ${PORT_OPTIONS:MCOLOR_LESS} CPPFLAGS+= -DCOLOR_LESS pre-fetch: @${ECHO_MSG} "Making a color version of less." .endif .include <bsd.port.mk> >Release-Note: >Audit-Trail: >Unformatted: _______________________________________________ freebsd-ports-bugs@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
Hey! Quick fix, please. I would like you to fix the bug related to the build option that resides in the port sysutils/less. This bug did slip into this port at SVN Revision 317890 (related PR: ports/178261) for the port update (451->458). Well, the bug is (probably) simple; the line .if ${PORT_OPTIONS:MCOLOUR_LESS} should be .if ${PORT_OPTIONS:MCOLOR_LESS} because the option named "COLOR_LESS" (NOT COLO*U*R_LESS) is defined as follows: OPTIONS_DEFINE= COLOR_LESS COLOR_LESS_DESC=Enables color support via escape sequence Fix: Patch attached with submission follows:
Maintainer of sysutils/less, Please note that PR ports/178525 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178525 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Responsible Changed From-To: freebsd-ports-bugs->wg I'll take it.
Author: wg Date: Sun Jun 9 13:07:03 2013 New Revision: 320332 URL: http://svnweb.freebsd.org/changeset/ports/320332 Log: - Fix typo in OptionsNG conversion PR: ports/178525 Submitted by: Norihiko Murase <mur1080224@inter7.jp> Approved by: culot / jpaetzel (mentors, implicit), maintainer (timeout) Modified: head/sysutils/less/Makefile Modified: head/sysutils/less/Makefile ============================================================================== --- head/sysutils/less/Makefile Sun Jun 9 13:01:20 2013 (r320331) +++ head/sysutils/less/Makefile Sun Jun 9 13:07:03 2013 (r320332) @@ -23,7 +23,7 @@ PLIST_FILES= bin/less bin/lesskey bin/le GNU_CONFIGURE= yes MAN1= less.1 lesskey.1 lessecho.1 -.if ${PORT_OPTIONS:MCOLOUR_LESS} +.if ${PORT_OPTIONS:MCOLOR_LESS} CPPFLAGS+= -DCOLOR_LESS pre-fetch: _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!