Bug 178636 - [PATCH] mark games/viruskiller broken on amd64
Summary: [PATCH] mark games/viruskiller broken on amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-14 17:50 UTC by Chris Petrik
Modified: 2013-05-16 15:00 UTC (History)
0 users

See Also:


Attachments
file.diff (716 bytes, patch)
2013-05-14 17:50 UTC, Chris Petrik
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Petrik 2013-05-14 17:50:00 UTC

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-14 17:50:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bdrewery

bdrewery@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2013-05-16 14:55:03 UTC
Including bsd.port.pre.mk requires changing the bsd.port.mk line to be
bsd.port.post.mk. Otherwise it breaks the i386 build:

> viruskiller-1.03_3: Makefile error: you cannot include bsd.port[.pre].mk twice



Another option is to use bsd.port.options.mk instead of bsd.port.pre.mk,
which does not require using bsd.port.post.mk.

I'll commit it with bsd.options.mk.

Also, DOCS is already default so it's not needed to add to OPTIONS_DEFAULT.

Bryan
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-05-16 14:55:58 UTC
Author: bdrewery
Date: Thu May 16 13:55:51 2013
New Revision: 318316
URL: http://svnweb.freebsd.org/changeset/ports/318316

Log:
  - Mark broken on amd64
  - Convert to new options framework
  
  PR:		ports/178636
  Submitted by:	Chris Petrik <c.petrik.sosa@gmail.com> (maintainer)

Modified:
  head/games/viruskiller/Makefile

Modified: head/games/viruskiller/Makefile
==============================================================================
--- head/games/viruskiller/Makefile	Thu May 16 13:53:13 2013	(r318315)
+++ head/games/viruskiller/Makefile	Thu May 16 13:55:51 2013	(r318316)
@@ -13,6 +13,8 @@ COMMENT=	Arcade game that relies on quic
 
 LICENSE=	GPLv2
 
+OPTIONS_DEFINE=	DOCS
+
 USE_SDL=	mixer image ttf net
 USE_GMAKE=	yes
 
@@ -22,11 +24,17 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVER
 
 MAKEFILE=	makefile
 
+.include <bsd.port.options.mk>
+
+.if ${ARCH} == "amd64"
+BROKEN=	Does not build with new libz
+.endif
+
 post-patch:
 	# Remove non-free restricted files:
 	${RM} -f ${WRKSRC}/music/* ${WRKSRC}/sound/*
 
-.if defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${REINPLACE_CMD} -e "s|^.*install.*DOCS.*||g" \
 		-e "s|^.*mkdir.*DOCDIR.*||g" \
 		${WRKSRC}/makefile
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2013-05-16 14:56:04 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!