Bug 178668 - [PATCH] www/mod_xsendfile: Fix extracting Last-Modified info
Summary: [PATCH] www/mod_xsendfile: Fix extracting Last-Modified info
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-apache (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 19:30 UTC by Hung-Yi Chen
Modified: 2013-06-22 21:30 UTC (History)
0 users

See Also:


Attachments
mod_xsendfile.diff (1.11 KB, patch)
2013-05-15 19:30 UTC, Hung-Yi Chen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hung-Yi Chen 2013-05-15 19:30:00 UTC
	Extract Last-Modified from the right place.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-15 19:30:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->apache

apache@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-15 19:30:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-15 19:30:10 UTC
Maintainer of www/mod_xsendfile,

Please note that PR ports/178668 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178668

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 4 Andrew Bennett 2013-05-18 18:18:47 UTC
The patch looks good.

Andrew Bennett
potatosaladx@gmail.com


On Wed, May 15, 2013 at 12:30 PM, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of www/mod_xsendfile,
>
> Please note that PR ports/178668 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178668
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-06-22 21:25:04 UTC
Author: ohauer
Date: Sat Jun 22 20:24:57 2013
New Revision: 321590
URL: http://svnweb.freebsd.org/changeset/ports/321590

Log:
  - Extract Last-Modified from the right place
  
  PR:		ports/178668
  Submitted by:	Hung-Yi Chen <gaod@hychen.org>
  Approved by:	Andrew Bennet <potatosaladx@gmail.com> (maintainer)

Added:
  head/www/mod_xsendfile/files/
  head/www/mod_xsendfile/files/patch-mod_xsendfile.c   (contents, props changed)
Modified:
  head/www/mod_xsendfile/Makefile

Modified: head/www/mod_xsendfile/Makefile
==============================================================================
--- head/www/mod_xsendfile/Makefile	Sat Jun 22 20:18:50 2013	(r321589)
+++ head/www/mod_xsendfile/Makefile	Sat Jun 22 20:24:57 2013	(r321590)
@@ -1,13 +1,9 @@
-# New ports collection makefile for:	mod_xsendfile Apache module
-# Date created:			2006-11-23
-# Whom:				Andrew T. Bennett <potatosaladx@gmail.com>
-#
+# Created by: Andrew T. Bennett <potatosaladx@gmail.com>
 # $FreeBSD$
-#
 
 PORTNAME=	mod_xsendfile
 PORTVERSION=	0.12
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	www
 MASTER_SITES=	https://tn123.org/mod_xsendfile/ \
 		http://cloud.github.com/downloads/potatosalad/mod_xsendfile/

Added: head/www/mod_xsendfile/files/patch-mod_xsendfile.c
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/mod_xsendfile/files/patch-mod_xsendfile.c	Sat Jun 22 20:24:57 2013	(r321590)
@@ -0,0 +1,11 @@
+--- mod_xsendfile.c.orig	2013-05-16 02:15:41.000000000 +0800
++++ mod_xsendfile.c	2013-05-16 02:15:48.000000000 +0800
+@@ -439,7 +439,7 @@
+     conf->ignoreLM == XSENDFILE_ENABLED
+     || (
+       !apr_table_get(r->headers_out, "last-modified")
+-      && !apr_table_get(r->headers_out, "last-modified")
++      && !apr_table_get(r->err_headers_out, "last-modified")
+     )
+   ) {
+     apr_table_unset(r->err_headers_out, "last-modified");
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Olli Hauer freebsd_committer freebsd_triage 2013-06-22 21:25:50 UTC
State Changed
From-To: feedback->closed

Committed, 
Thanks!