Bug 178954 - converters/iconv fails to build with perl5.16
Summary: converters/iconv fails to build with perl5.16
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alexander Nedotsukov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 18:00 UTC by Dan McGregor
Modified: 2013-05-26 17:10 UTC (History)
0 users

See Also:


Attachments
file.diff (842 bytes, patch)
2013-05-24 18:00 UTC, Dan McGregor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan McGregor 2013-05-24 18:00:00 UTC
The port converters/iconv fails to build using perl 5.16. The reason is that perl5.16 removed the getopts.pl file from perl4, after having been deprecated in 5.14.

Fix: The included patch for converters/iconv/files fixes the problem by patching the affected files to use Getopts::Std instead of getopts.pl.

Patch attached with submission follows:
How-To-Repeat: Switch to perl 5.16, and try to build converters/iconv. You will see output like this:

cat /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../ccs/charset.aliases /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../ces/charset.aliases | /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../iconv_builtin    PIC  > aliases.h
Can't locate getopts.pl in @INC (@INC contains: /usr/local/lib/perl5/5.16.2/BSDPAN /usr/local/lib/perl5/site_perl/5.16.2/mach /usr/local/lib/perl5/site_perl/5.16.2 /usr/local/lib/perl5/5.16.2/mach /usr/local/lib/perl5/5.16.2 .) at /wrkdirs/usr/ports/converters/iconv/work/iconv-2.0/lib/../iconv_builtin line 34.
*** [aliases.h] Error code 2
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-24 18:00:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bland

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-05-26 17:00:07 UTC
Author: bland
Date: Sun May 26 15:59:54 2013
New Revision: 319116
URL: http://svnweb.freebsd.org/changeset/ports/319116

Log:
  Fix build with perl 5.16.
  
  PR:	178954

Added:
  head/converters/iconv/files/patch-iconv_builtin   (contents, props changed)

Added: head/converters/iconv/files/patch-iconv_builtin
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/converters/iconv/files/patch-iconv_builtin	Sun May 26 15:59:54 2013	(r319116)
@@ -0,0 +1,34 @@
+--- iconv_builtin.orig	2000-11-20 16:07:41.000000000 -0600
++++ iconv_builtin	2013-05-24 10:19:34.765696802 -0600
+@@ -31,9 +31,9 @@
+ #       iconv (Charset Conversion Library) v2.0
+ #
+ 
+-require 'getopts.pl';
++use Getopt::Std;
+ 
+-&Getopts('mno:s:');
++getopts('mno:s:');
+ 
+ if ($opt_o) {
+         open(STDOUT, ">$opt_o");
+--- ccs/iconv_mktbl.orig	2000-11-18 15:44:27.000000000 -0600
++++ ccs/iconv_mktbl	2013-05-24 10:43:06.598689960 -0600
+@@ -31,7 +31,7 @@
+ # 	iconv (Charset Conversion Library) v2.0
+ #
+ 
+-require 'getopts.pl';
++use Getopt::Std;
+ use integer;
+ 
+ sub pack_hex {
+@@ -144,7 +144,7 @@
+ $opt_p = '0x';
+ $opt_u = 1;
+ 
+-&Getopts('aCc:Mm:o:p:u:');
++getopts('aCc:Mm:o:p:u:');
+ #         ||| || | | +- u N:	field number for Unicode character codes
+ #         ||| || | +--- p str:	prefix
+ #         ||| || +----- o file:	output file name
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Alexander Nedotsukov freebsd_committer freebsd_triage 2013-05-26 17:01:27 UTC
State Changed
From-To: open->closed

Committed, thanks!