Bug 178979 - [patch] Clean up dns/inadyn
Summary: [patch] Clean up dns/inadyn
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-25 20:20 UTC by Kevin Zheng
Modified: 2013-06-17 07:30 UTC (History)
0 users

See Also:


Attachments
file.diff (2.42 KB, patch)
2013-05-25 20:20 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2013-05-25 20:20:00 UTC
Do some cleanup work on dns/inadyn. This means:
 - Trim Makefile header
 - Improve COMMENT and pkg-descr
 - Remove obsolete knob NO_INSTALL_MANPAGES
 - Quit using NOPORTDOCS by adopting OptionsNG

Fix: Apply the attached patch: IMPORTANT: using `svn patch <file>`.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-25 20:20:07 UTC
Maintainer of dns/inadyn,

Please note that PR ports/178979 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/178979

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-25 20:20:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Kevin Zheng 2013-06-11 03:21:14 UTC
Hi there,

Somebody should mark this as "maintainer timed out."

Thanks,
Kevin Zheng
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-06-17 07:22:28 UTC
Author: az
Date: Mon Jun 17 06:22:19 2013
New Revision: 321086
URL: http://svnweb.freebsd.org/changeset/ports/321086

Log:
  - Trim Makefile header
  - Improve COMMENT and pkg-descr
  - Remove obsolete knob NO_INSTALL_MANPAGES
  - NOPORTDOCS -> PORT_OPTIONS:MDOCS
  
  PR:		ports/178979
  Submitted by: 	Kevin Zheng <kevinz5000@gmail.com>
  Approved by:	maintainer (timeout)

Modified:
  head/dns/inadyn/Makefile
  head/dns/inadyn/pkg-descr

Modified: head/dns/inadyn/Makefile
==============================================================================
--- head/dns/inadyn/Makefile	Mon Jun 17 05:38:19 2013	(r321085)
+++ head/dns/inadyn/Makefile	Mon Jun 17 06:22:19 2013	(r321086)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:   inadyn
-# Date created:        9 September 2005
-# Whom:                Alex Samorukov <samm@os2.kiev.ua>
-#
+# Created by: Alex Samorukov <samm@os2.kiev.ua>
 # $FreeBSD$
-#
 
 PORTNAME=	inadyn
 PORTVERSION=	1.96.2
@@ -15,7 +11,7 @@ MASTER_SITE_SUBDIR=	dhn
 DISTNAME=	${PORTNAME}.v${PORTVERSION}
 
 MAINTAINER=	samm@os2.kiev.ua
-COMMENT=	INADYN - Simple DYNAMIC DNS client
+COMMENT=	Dynamic DNS update client
 
 USE_RC_SUBR=	inadyn
 USE_ZIP=	yes
@@ -23,14 +19,16 @@ USE_DOS2UNIX=	yes
 USE_GMAKE=	yes
 MAKEFILE=	makefile
 
-.if !defined(NO_INSTALL_MANPAGES)
-MAN8=		inadyn.8
 MAN5=		inadyn.conf.5
-.endif
+MAN8=		inadyn.8
 
 PORTDOCS=	readme.html
 PLIST_FILES=	bin/inadyn
 
+OPTIONS_DEFINE=	DOCS
+
+.include <bsd.port.options.mk>
+
 post-extract:
 	@${MV} ${WRKDIR}/${PORTNAME} ${WRKSRC}
 
@@ -41,14 +39,12 @@ post-patch:
 		${WRKSRC}/src/dyndns.h
 
 do-install:
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} -p ${WRKSRC}/${PORTDOCS} ${DOCSDIR}
 .endif
 	${INSTALL_PROGRAM} ${WRKSRC}/bin/linux/inadyn ${PREFIX}/bin
-.if !defined(NO_INSTALL_MANPAGES)
 	${INSTALL_MAN} ${WRKSRC}/man/inadyn.8 ${MANPREFIX}/man/man8
 	${INSTALL_MAN} ${WRKSRC}/man/inadyn.conf.5 ${MANPREFIX}/man/man5
-.endif
 
 .include <bsd.port.mk>

Modified: head/dns/inadyn/pkg-descr
==============================================================================
--- head/dns/inadyn/pkg-descr	Mon Jun 17 05:38:19 2013	(r321085)
+++ head/dns/inadyn/pkg-descr	Mon Jun 17 06:22:19 2013	(r321086)
@@ -1,8 +1,13 @@
-INADYN is a dynamic DNS client, it maintains the IP address of a host name by 
-periodically checking whether the IP address stored by the DNS server is the 
-real current address of the machine that is running INADYN.
+INADYN is a free, multi-platform dynamic DNS update client. It gives the
+possibility to have your own fixed hostname registered on the Internet,
+although your IP might be changing. It checks periodically whether the IP
+address stored by the DNS server is the real current IP address of the machine
+that is running INADYN.
+
+INADYN supports the following dynamic DNS services:
+ - dyndns.org (in all three flavors: dynamic, static, custom)
+ - freedns.afraid.org
+ - no-ip.com
+ - zoneedit.com
 
-Supported dynamic DNS services are: dyndns.org (in all three flavors: dynamic, 
-static, custom), freedns.afraid.org, zoneedit.com, no-ip.com 
- 
 WWW: http://www.inatech.eu/inadyn/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Andrej Zverev freebsd_committer freebsd_triage 2013-06-17 07:22:45 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!