Bug 179042 - print/scribus: runscriptdialog.cpp:13:43: error: addition of default argument on redeclaration makes this constructor a default constructor
Summary: print/scribus: runscriptdialog.cpp:13:43: error: addition of default argument...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 08:30 UTC by O. Hartmann
Modified: 2013-06-19 22:40 UTC (History)
0 users

See Also:


Attachments
scribus.diff (1.34 KB, patch)
2013-06-18 22:44 UTC, Boris Samorodov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2013-05-28 08:30:00 UTC
Updating of print/scribus fails on most recent ports (Revision: 319293) with the following compiler error message:


[...]

[ 90%] Building CXX object scribus/plugins/scriptplugin/CMakeFiles/scriptplugin.dir/pconsole.cpp.o
[ 91%] Building CXX object scribus/plugins/scriptplugin/CMakeFiles/scriptplugin.dir/runscriptdialog.cpp.o
/usr/ports/print/scribus/work/scribus-1.4.2/scribus/plugins/scriptplugin/runscriptdialog.cpp:13:43: error: addition of default argument on redeclaration
      makes this constructor a default constructor
RunScriptDialog::RunScriptDialog(QWidget* parent = 0, bool extEnable = false) :
                                          ^        ~
/usr/ports/print/scribus/work/scribus-1.4.2/scribus/plugins/scriptplugin/runscriptdialog.h:24:3: note: previous declaration is here
                RunScriptDialog(QWidget* parent, bool extEnable);
                ^
1 error generated.
*** Error code 1

Stop.
make: stopped in /usr/ports/print/scribus/work/scribus-1.4.2
*** Error code 1

Stop.
make: stopped in /usr/ports/print/scribus/work/scribus-1.4.2
*** Error code 1

Stop.
make: stopped in /usr/ports/print/scribus/work/scribus-1.4.2
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-28 08:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Boris Samorodov 2013-06-18 22:44:55 UTC
Please, try the following patch:
# patch -d /usr/ports/print/scribus -p0 < <patch_to_the_patch>

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Comment 3 O. Hartmann 2013-06-19 10:09:15 UTC
On Wed, 19 Jun 2013 01:44:55 +0400
Boris Samorodov <bsam@passap.ru> wrote:

> Please, try the following patch:
> # patch -d /usr/ports/print/scribus -p0 < <patch_to_the_patch>
> 



Great, works for me.

Regards,

Oliver
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-06-19 22:37:37 UTC
Author: bsam
Date: Wed Jun 19 21:37:29 2013
New Revision: 321333
URL: http://svnweb.freebsd.org/changeset/ports/321333

Log:
  Fix build with latest clang:
  -----
  /usr/ports/print/scribus/work/scribus-1.4.2/scribus/plugins/scriptplugin/runscriptdialog.cpp:13:43: error: addition of default argument on redeclaration
  makes this constructor a default constructor
  RunScriptDialog::RunScriptDialog(QWidget* parent = 0, bool extEnable = false) :
  ^ ~
  /usr/ports/print/scribus/work/scribus-1.4.2/scribus/plugins/scriptplugin/runscriptdialog.h:24:3: note: previous declaration is here
  RunScriptDialog(QWidget* parent, bool extEnable);
  ^
  1 error generated.
  *** Error code 1
  -----
  
  PR:		ports/179042
  Submitted by:	"O. Hartmann" <ohartman@zedat.fu-berlin.de>
  Patch by:	bsam (me)
  Tested by:	"O. Hartmann" <ohartman@zedat.fu-berlin.de>
  Approved by:	sylvio (maintainer, timeout 3+ weeks)

Added:
  head/print/scribus/files/patch-scribus_plugins_scriptplugin_runscriptdialog.cpp   (contents, props changed)
Modified:
  head/print/scribus/Makefile

Modified: head/print/scribus/Makefile
==============================================================================
--- head/print/scribus/Makefile	Wed Jun 19 21:33:59 2013	(r321332)
+++ head/print/scribus/Makefile	Wed Jun 19 21:37:29 2013	(r321333)
@@ -34,7 +34,7 @@ USE_PYTHON=	yes
 USES=		cmake desktop-file-utils pkgconfig shared-mime-info
 USE_LDCONFIG=	yes
 
-CMAKE_ARGS+=	-DWITH_ASPELL=NO -DWANT_HUNSPELL=YES
+CMAKE_ARGS+=	-DWITH_ASPELL=NO -DWANT_HUNSPELL=YES -Wno-ferror-limit
 
 MAN1=		scribus.1
 MANLANG=	"" pl de

Added: head/print/scribus/files/patch-scribus_plugins_scriptplugin_runscriptdialog.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/print/scribus/files/patch-scribus_plugins_scriptplugin_runscriptdialog.cpp	Wed Jun 19 21:37:29 2013	(r321333)
@@ -0,0 +1,14 @@
+--- scribus/plugins/scriptplugin/runscriptdialog.cpp.orig	2008-03-15 04:36:48.000000000 +0400
++++ scribus/plugins/scriptplugin/runscriptdialog.cpp	2013-06-20 00:15:32.226597355 +0400
+@@ -10,9 +10,10 @@ for which a new license (GPL+exception) 
+ 
+ QString RunScriptDialog::m_lastScriptDir;
+ 
+-RunScriptDialog::RunScriptDialog(QWidget* parent = 0, bool extEnable = false) :
++RunScriptDialog::RunScriptDialog(QWidget* parent, bool extEnable = false) :
+ 	QDialog(parent)
+ {
++	parent=0;
+ 	setupUi(this);
+ 
+ 	m_extEnable = extEnable;
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Boris Samorodov freebsd_committer freebsd_triage 2013-06-19 22:39:13 UTC
State Changed
From-To: open->closed

A patch is committed, thanks!