Bug 179046 - fixing graphics/pngcrush
Summary: fixing graphics/pngcrush
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joseph S. Atkinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-28 12:10 UTC by Gordon Shumway
Modified: 2013-06-08 18:20 UTC (History)
0 users

See Also:


Attachments
file.diff (1.24 KB, patch)
2013-05-28 12:10 UTC, Gordon Shumway
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gordon Shumway 2013-05-28 12:10:00 UTC
graphics/pngcrush is marked as BROKEN=Does not fetch

Fix: apply the attached patch to graphics/pngcrush -- fixes this problem class for good by adding MASTER_SITE locations for not-so-current pngcrush releases plus updates port to the current (as of this writing) version.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/graphics/pngcrush && sudo make fetch
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-28 12:10:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jsa

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Matthias Andree freebsd_committer freebsd_triage 2013-06-08 18:08:27 UTC
State Changed
From-To: open->closed

superseded by ports/179197
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-06-08 18:18:42 UTC
Author: mandree
Date: Sat Jun  8 17:18:33 2013
New Revision: 320275
URL: http://svnweb.freebsd.org/changeset/ports/320275

Log:
  Update to 1.7.59, unbreaking the fetch.
  
  PR:		ports/179351
  PR:		ports/177629
  PR:		ports/178806
  PR:		ports/179046
  PR:		ports/179197 [1]
  PR:		ports/179351
  Submitted by:	Sayetsky Anton <vsjcfm@gmail.com> [1] and others
  Approved by:	jsa (maintainer timeout, 9 weeks on PR 177629)

Added:
  head/graphics/pngcrush/files/
  head/graphics/pngcrush/files/patch-Makefile   (contents, props changed)
Modified:
  head/graphics/pngcrush/Makefile   (contents, props changed)
  head/graphics/pngcrush/distinfo   (contents, props changed)

Modified: head/graphics/pngcrush/Makefile
==============================================================================
--- head/graphics/pngcrush/Makefile	Sat Jun  8 17:13:09 2013	(r320274)
+++ head/graphics/pngcrush/Makefile	Sat Jun  8 17:18:33 2013	(r320275)
@@ -2,9 +2,9 @@
 # $FreeBSD$
 
 PORTNAME=	pngcrush
-PORTVERSION=	1.7.51
+PORTVERSION=	1.7.59
 CATEGORIES=	graphics
-MASTER_SITES=	SF/pmt/${PORTNAME}/old-versions/1.7/${PORTVERSION}/
+MASTER_SITES=	SF/pmt/${PORTNAME}/${PORTVERSION}/
 DISTNAME=	${PORTNAME}-${PORTVERSION}-nolib
 
 MAINTAINER=	jsa@FreeBSD.org
@@ -13,7 +13,6 @@ COMMENT=	Optimizer for PNG files
 LIB_DEPENDS=	png15:${PORTSDIR}/graphics/png
 
 USE_XZ=		yes
-USE_GMAKE=	yes
 CFLAGS+=	-DPNGCRUSH_COUNT_COLORS -I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
 MAKE_ARGS+=	CC="${CC}" CFLAGS="${CFLAGS}" LD="${CC}" LDFLAGS="${LDFLAGS}"

Modified: head/graphics/pngcrush/distinfo
==============================================================================
--- head/graphics/pngcrush/distinfo	Sat Jun  8 17:13:09 2013	(r320274)
+++ head/graphics/pngcrush/distinfo	Sat Jun  8 17:18:33 2013	(r320275)
@@ -1,2 +1,2 @@
-SHA256 (pngcrush-1.7.51-nolib.tar.xz) = 78df26dd2c6fdb09e55078d173350bef62abb2ba51ccfe352f4be6f6b8cf7762
-SIZE (pngcrush-1.7.51-nolib.tar.xz) = 53912
+SHA256 (pngcrush-1.7.59-nolib.tar.xz) = 0dd7b7d0fb73e8ce9ada44ab1690613dc58c0800806bf3b06a411d69ffd37eb0
+SIZE (pngcrush-1.7.59-nolib.tar.xz) = 56532

Added: head/graphics/pngcrush/files/patch-Makefile
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/graphics/pngcrush/files/patch-Makefile	Sat Jun  8 17:18:33 2013	(r320275)
@@ -0,0 +1,29 @@
+--- ./Makefile.orig	2013-06-02 13:08:48.000000000 +0300
++++ ./Makefile	2013-06-02 13:10:53.000000000 +0300
+@@ -11,11 +11,11 @@
+ # macros --------------------------------------------------------------------
+ 
+ # uncomment these 2 lines only if you are using an external copy of libpng:
+-PNGINC = ${HOME}/include
+-PNGLIB = ${HOME}/lib
++#PNGINC = ${HOME}/include
++#PNGLIB = ${HOME}/lib
+ # uncomment these 2 lines only if you are using an external copy of zlib:
+-ZINC = ${HOME}/include
+-ZLIB = ${HOME}/lib
++#ZINC = ${HOME}/include
++#ZLIB = ${HOME}/lib
+ 
+ CC = gcc
+ LD = gcc
+@@ -31,8 +31,8 @@
+ PNGCRUSH  = pngcrush
+ 
+ # LIBS = -lm
+-LIBS = -L$(PNGLIB) -lpng -lz -lm
+-# LIBS = -lpng -lz -lm
++#LIBS = -L$(PNGLIB) -lpng -lz -lm
++LIBS = -lpng -lz -lm
+ #LIBS = ${ZLIB}/libz.a -lm
+ 
+ # uncomment these 4 lines only if you are NOT using an external copy of zlib:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"