Bug 179149 - [PATCH] multimedia/mkxvcd: Trim docs, add license
Summary: [PATCH] multimedia/mkxvcd: Trim docs, add license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rusmir Dusko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-31 18:50 UTC by nemysis
Modified: 2014-04-21 13:40 UTC (History)
1 user (show)

See Also:


Attachments
mkxvcd-2.0.2_9.patch (1.60 KB, patch)
2013-05-31 18:50 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-05-31 18:50:00 UTC
- Shorten header
- Add license
- Trim docs
- Comply with OptionsNG
- Cleanup Makefile

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130530225801-47927/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-31 18:50:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 Thomas Abthorpe freebsd_committer freebsd_triage 2014-01-10 03:35:59 UTC
Responsible Changed
From-To: beech->nemysis

Submitter is committer
Comment 3 Rusmir Dusko freebsd_committer freebsd_triage 2014-04-21 13:28:47 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2014-04-21 13:34:50 UTC
Author: nemysis
Date: Mon Apr 21 12:34:46 2014
New Revision: 351678
URL: http://svnweb.freebsd.org/changeset/ports/351678
QAT: https://qat.redports.org/buildarchive/r351678/

Log:
  - Bump PORTREVISION for LICENSE  adding
  - Add USES shebangfix and SHEBANG_FILES, remove obsolete REINPLACE
  - Remove INSTALL and TODO from DOCS
  - Support STAGEDIR
  - Add DOCS Option
  - Change pkg-descr, cosmetical changes
  
  PR:		ports/179149
  Submitted by:	nemysis (self)

Modified:
  head/multimedia/mkxvcd/Makefile
  head/multimedia/mkxvcd/pkg-descr

Modified: head/multimedia/mkxvcd/Makefile
==============================================================================
--- head/multimedia/mkxvcd/Makefile	Mon Apr 21 12:29:40 2014	(r351677)
+++ head/multimedia/mkxvcd/Makefile	Mon Apr 21 12:34:46 2014	(r351678)
@@ -3,37 +3,34 @@
 
 PORTNAME=	mkxvcd
 PORTVERSION=	2.0.2
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	multimedia
-MASTER_SITES=	SF/kvcd4nix/${PORTNAME}/${PORTNAME}-${PORTVERSION}
+MASTER_SITES=	SF/kvcd4nix/${PORTNAME}/${PORTNAME}-${PORTVERSION}/
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Makes high quality X/K/S/VCD movies from many formats
 
+LICENSE=	GPLv2
+
 RUN_DEPENDS=	mpeg2enc:${PORTSDIR}/multimedia/mjpegtools \
 		bash:${PORTSDIR}/shells/bash \
 		mplayer:${PORTSDIR}/multimedia/mplayer \
 		transcode:${PORTSDIR}/multimedia/transcode
 
+USES=		shebangfix
+SHEBANG_FILES=	${PORTNAME}.sh
 NO_BUILD=	yes
-PLIST_FILES=	bin/mkxvcd
-
-PORTDOCS=	AUTHORS Changelog INSTALL README TODO
 
-NO_STAGE=	yes
-.include <bsd.port.pre.mk>
+PLIST_FILES=	bin/${PORTNAME}
 
-post-patch:
-	@${REINPLACE_CMD} -e 's|#!/bin/bash|#!${LOCALBASE}/bin/bash|' \
-		${WRKSRC}/mkxvcd.sh
+PORTDOCS=	AUTHORS Changelog README
+OPTIONS_DEFINE=	DOCS
 
 do-install:
-	@${INSTALL_SCRIPT} ${WRKSRC}/mkxvcd.sh ${PREFIX}/bin/mkxvcd
-.if !defined(NOPORTDOCS)
-	@${MKDIR} ${DOCSDIR}
-.for docfile in ${PORTDOCS}
-	@${INSTALL_DATA} ${WRKSRC}/${docfile} ${DOCSDIR}
-.endfor
-.endif
+	@${INSTALL_SCRIPT} ${WRKSRC}/${PORTNAME}.sh \
+		${STAGEDIR}${PREFIX}/bin/${PORTNAME}
+
+	@${MKDIR} ${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

Modified: head/multimedia/mkxvcd/pkg-descr
==============================================================================
--- head/multimedia/mkxvcd/pkg-descr	Mon Apr 21 12:29:40 2014	(r351677)
+++ head/multimedia/mkxvcd/pkg-descr	Mon Apr 21 12:34:46 2014	(r351678)
@@ -3,7 +3,7 @@ Makes high quality X/K/S/VCD movies from
 From README:
 GOAL
         Make a 2 hour vcd with good quality.
-        
+
 USAGE
         mkxvcd.sh yourmovie.whateverextensionmplayercanplay
         mkxvcd.sh /dev/dvd (or whatever device your dvd drive is using)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"