Bug 179156 - [PATCH] net/tcptrace: Add license, trim docs, fix pkg-descr, comply with OptionsNG
Summary: [PATCH] net/tcptrace: Add license, trim docs, fix pkg-descr, comply with Opti...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-31 20:50 UTC by nemysis
Modified: 2013-06-17 14:40 UTC (History)
1 user (show)

See Also:


Attachments
tcptrace-6.6.7.patch (4.34 KB, patch)
2013-05-31 20:50 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-05-31 20:50:02 UTC
- Shorten header
- Trim comment
- Add license
- Comply with OptionsNG
- Trim docs
- Fix pkg-descr
- Remove pkg-plist
- Make portlint happy
- Cleanup port

Removed file(s):
- pkg-plist

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130531184401-40307/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-05-31 20:50:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this submitter's PRs (via the GNATS Auto Assign Tool)
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-06-17 14:28:10 UTC
Responsible Changed
From-To: beech->wg

I'll take it.
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-06-17 14:30:56 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-06-17 14:31:10 UTC
Author: wg
Date: Mon Jun 17 13:30:52 2013
New Revision: 321108
URL: http://svnweb.freebsd.org/changeset/ports/321108

Log:
  net/tcptrace: minor Makefile fixes
  
  - Trim Makefile header
  - Remove leading article from COMMENT
  - Add LICENSE (GPLv2)
  - Use PLIST_FILES instead of pkg-plist
  - NOPORTDOCS -> PORT_OPTIONS:MDOCS
  - Rework pkg-descr
  
  PR:		ports/179156
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	culot / jpaetzel (mentors, implicit)

Deleted:
  head/net/tcptrace/pkg-plist
Modified:
  head/net/tcptrace/Makefile
  head/net/tcptrace/pkg-descr

Modified: head/net/tcptrace/Makefile
==============================================================================
--- head/net/tcptrace/Makefile	Mon Jun 17 13:17:03 2013	(r321107)
+++ head/net/tcptrace/Makefile	Mon Jun 17 13:30:52 2013	(r321108)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	tcptrace
-# Date created:		3 March 1997
-# Whom:			fenner
-#
+# Created by: fenner
 # $FreeBSD$
-#
 
 PORTNAME=	tcptrace
 PORTVERSION=	6.6.7
@@ -11,31 +7,35 @@ CATEGORIES=	net ipv6
 MASTER_SITES=	http://www.tcptrace.org/download/
 
 MAINTAINER=	ports@FreeBSD.org
-COMMENT=	A TCP dump file analysis tool
+COMMENT=	TCP dump file analysis tool
 
-MAKE_JOBS_SAFE=  yes
+LICENSE=	GPLv2
 
 GNU_CONFIGURE=	yes
 ALL_TARGET=	tcptrace
+MAKE_JOBS_SAFE=	yes
+
+PLIST_FILES=	bin/${PORTNAME} \
+		bin/xpl2gpl
 
 MAN1=		tcptrace.1
 
-DOCFILES=	ARGS CHANGES COPYING COPYRIGHT FAQ README README.mailing_list \
+PORTDOCS=	ARGS CHANGES FAQ README README.mailing_list \
 		README.modules README.tline_graphs README.tput_graphs \
-		README.version README.xpl2gpl THANKS WWW \
-		dot_tcptracerc
+		README.version README.xpl2gpl THANKS dot_tcptracerc
+
+.include <bsd.port.options.mk>
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/tcptrace ${PREFIX}/bin
 	${INSTALL_SCRIPT} ${WRKSRC}/xpl2gpl ${PREFIX}/bin
-	${INSTALL_MAN} ${WRKSRC}/tcptrace.man ${PREFIX}/man/man1/tcptrace.1
 
 post-install:
-.if !defined(NOPORTDOCS)
-	${MKDIR} ${DOCSDIR}
-.for file in ${DOCFILES}
-	${INSTALL_MAN} ${WRKSRC}/${file} ${DOCSDIR}
-.endfor
+	${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.man ${MAN1PREFIX}/man/man1/${PORTNAME}.1
+
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>

Modified: head/net/tcptrace/pkg-descr
==============================================================================
--- head/net/tcptrace/pkg-descr	Mon Jun 17 13:17:03 2013	(r321107)
+++ head/net/tcptrace/pkg-descr	Mon Jun 17 13:30:52 2013	(r321108)
@@ -1,28 +1,15 @@
-tcptrace a TCP dump file analysis tool written by Shawn Ostermann
-at Ohio University. It is NOT a packet capture program. It reads
-output dump files in the formats of several popular packet capturing
-programs: tcpdump, snoop, etherpeek, and netm.  It can also output
-(ie, convert thus converting to) tcpdump format files.
+tcptrace is a TCP connection analysis tool. It can tell you detailed
+information about TCP connections by sifting through dump files.
+The dump file formats supported are:
+   Standard tcpdump format (you need the pcap library)
+   Sun's snoop format
+   Macintosh Etherpeek format
+   HP/NetMetrix protocol analysis format
+   NS simulator output format
+   NetScout
+   NLANR Tsh Format
 
-For each connection, it keeps track of elapsed time, bytes/segments
-sent and received, retransmissions, round trip times, window
-advertisements, throughput, etc.  Its output format ranges from
-Simple to Long to Very Detailed.
-
-It can also produce three different types of graphs, as follows: 
-
-   Time Sequence Graph 
-     This is the format that Tim Shepard started using at MIT some
-     years ago. It shows segments sent and ACKs returned as a
-     function of time.
-   Instantaneous Throughput 
-     This format shows the instantaneous (averaged over a few
-     segments) throughput of the connection as a function of time.
-   Round Trip Times 
-     This format shows the round trip times for the ACKs as a
-     function of time.
-
-The graphs produced are viewable only by Tim Shepard's wonderful
-xplot program (in math/xplot).
+To see the graphs, you'll also need Tim Shepard's xplot program,
+available at http://www.xplot.org
 
 WWW: http://www.tcptrace.org/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"