Bug 179180 - devel/freeocl: Minor changes regarding upcoming POCL port and ICD loader
Summary: devel/freeocl: Minor changes regarding upcoming POCL port and ICD loader
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-01 20:50 UTC by O. Hartmann
Modified: 2014-11-16 19:18 UTC (History)
0 users

See Also:


Attachments
file.diff (21.57 KB, patch)
2013-06-01 20:50 UTC, O. Hartmann
no flags Details | Diff
Fix some bugs and prepare for future port conflicts. (6.98 KB, patch)
2014-10-04 20:01 UTC, O. Hartmann
no flags Details | Diff
patch for freeocl (1.60 KB, patch)
2014-10-12 14:02 UTC, Rodrigo Osorio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2013-06-01 20:50:00 UTC
Changed some minorities regarding upcoming new OpenCL ICD loader ports and POCL, the POrtable OpenCL port.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-01 20:50:09 UTC
Class Changed
From-To: change-request->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2014-02-13 12:45:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rodrigo

I'll take it.
Comment 3 Rodrigo Osorio freebsd_committer freebsd_triage 2014-09-27 11:18:16 UTC
Using your patch port doesn't compile any more.
Please next time do a svn diff to avoid svn junk
files in your diff.
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2014-10-03 22:03:44 UTC
If the changes you plan remain current, please submit a new PR with a usable patch. You can find all the details in the porter handbook[1].
If you have any question don't hesitate to ask me.

regards
- rodrigo

[1] https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html
Comment 5 O. Hartmann 2014-10-04 20:01:07 UTC
Created attachment 147984 [details]
Fix some bugs and prepare for future port conflicts.

Hopefully this also cleans up some mess.
Comment 6 Rodrigo Osorio freebsd_committer freebsd_triage 2014-10-12 14:02:09 UTC
Created attachment 148213 [details]
patch for freeocl

I'm sorry but the patch you submit :
- doesn't apply cleanly
- breaks the port

I attach a subset of your patch who does exactly what your PR says, no more, no less. Please test it, and if it's OK I will commit it.

Regards
- rodrigo
Comment 7 O. Hartmann 2014-10-25 18:53:39 UTC
All right.
Comment 8 O. Hartmann 2014-10-25 18:54:32 UTC
My applied patch worked cleanly for me, I have no idea why not at your site. But commit your changes, they seem all right.
Comment 9 commit-hook freebsd_committer freebsd_triage 2014-11-16 19:15:14 UTC
A commit references this bug:

Author: rodrigo
Date: Sun Nov 16 19:14:46 UTC 2014
New revision: 372647
URL: https://svnweb.freebsd.org/changeset/ports/372647

Log:
  - fix compiler settings and flags
  - define conflicts regarding other ocl, openocl and pocl ports
  - add license
  - extend pkg-descr and add WWW link

  PR:		ports/179180
  Submitted by:	ohartman@zedat.fu-berlin.de
  Approved by:	mentors (implicit)

Changes:
  head/devel/freeocl/Makefile
  head/devel/freeocl/pkg-descr
Comment 10 Rodrigo Osorio freebsd_committer freebsd_triage 2014-11-16 19:18:16 UTC
committed, thanks

If you found this commit doesn't cover all fields you expected,
you can submit an additional PR.