Bug 179278 - [PATCH] devel/p5-Goo-Canvas: Fix port, add license, add missing dependencies
Summary: [PATCH] devel/p5-Goo-Canvas: Fix port, add license, add missing dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-03 23:20 UTC by nemysis
Modified: 2013-08-22 00:30 UTC (History)
1 user (show)

See Also:


Attachments
p5-Goo-Canvas-0.06_2.patch (2.53 KB, patch)
2013-06-03 23:20 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-03 23:20:01 UTC
- Shorten header
- Fix port
- Add license
- Add dependencies for devel/p5-ExtUtils-Depends and devel/p5-ExtUtils-PkgConfig
- Trim pkg-plist

Port maintainer (sylvio@FreeBSD.org) is cc'd.

Generated and tested manually, tested with port test and with RedPorts, sent with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130603162000-65191/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-03 23:20:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 William Grzybowski freebsd_committer freebsd_triage 2013-08-22 00:21:39 UTC
Responsible Changed
From-To: sylvio->wg

I'll take it.
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-08-22 00:21:57 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-08-22 00:21:59 UTC
Author: wg
Date: Wed Aug 21 23:21:46 2013
New Revision: 325171
URL: http://svnweb.freebsd.org/changeset/ports/325171

Log:
  devel/p5-Goo-Canvas: fix build
  
  - Fix build
  - Add LICENSE (GPLv2)
  - Trim Makefile header
  - Use new perl5 framework
  - Use only one space for WWW:
  
  PR:		ports/179278
  Submitted by:	nemysis <nemysis gmx.ch>
  Approved by:	maintainer (timeout)

Modified:
  head/devel/p5-Goo-Canvas/Makefile
  head/devel/p5-Goo-Canvas/pkg-descr
  head/devel/p5-Goo-Canvas/pkg-plist

Modified: head/devel/p5-Goo-Canvas/Makefile
==============================================================================
--- head/devel/p5-Goo-Canvas/Makefile	Wed Aug 21 23:07:33 2013	(r325170)
+++ head/devel/p5-Goo-Canvas/Makefile	Wed Aug 21 23:21:46 2013	(r325171)
@@ -1,13 +1,9 @@
-# New ports collection makefile for:	p5-Goo-Canvas
-# Date created:		2010-03-10
-# Whom:			Sylvio Cesar Teixeira <sylvio@FreeBSD.org>
-#
+# Created by: Sylvio Cesar Teixeira <sylvio@FreeBSD.org>
 # $FreeBSD$
-#
 
 PORTNAME=	Goo-Canvas
 PORTVERSION=	0.06
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	devel perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-
@@ -15,18 +11,23 @@ PKGNAMEPREFIX=	p5-
 MAINTAINER=	sylvio@FreeBSD.org
 COMMENT=	Perl interface to the GooCanvas
 
+LICENSE=	GPLv2
+
 BUILD_DEPENDS=	p5-Cairo>=0:${PORTSDIR}/graphics/p5-Cairo \
+		p5-ExtUtils-Depends>=0:${PORTSDIR}/devel/p5-ExtUtils-Depends \
+		p5-ExtUtils-PkgConfig>=1:${PORTSDIR}/devel/p5-ExtUtils-PkgConfig \
 		p5-Glib2>=0:${PORTSDIR}/devel/p5-Glib2 \
 		p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
-LIB_DEPENDS=	goocanvas.3:${PORTSDIR}/graphics/goocanvas \
-		gdk_pixbuf_xlib.2:${PORTSDIR}/graphics/gdk-pixbuf
+LIB_DEPENDS=	goocanvas:${PORTSDIR}/graphics/goocanvas
 RUN_DEPENDS=	p5-Cairo>=0:${PORTSDIR}/graphics/p5-Cairo \
 		p5-Glib2>=0:${PORTSDIR}/devel/p5-Glib2 \
 		p5-Gtk2>=0:${PORTSDIR}/x11-toolkits/p5-Gtk2
 
-MAKE_JOBS_UNSAFE=	yes
+USE_GNOME=	gdkpixbuf
+USE_PERL5=	configure build run
+USES=		perl5
 
-BROKEN=		fails to build
+MAKE_JOBS_UNSAFE=	yes
 
 MAN1=		perltetris.pl.1 perlmine.pl.1
 MAN3=		Goo::Canvas::Item.3 \
@@ -58,6 +59,4 @@ MAN3=		Goo::Canvas::Item.3 \
 		Goo::Canvas::Points.3 \
 		Goo::Canvas::ItemSimple.3
 
-PERL_CONFIGURE=	yes
-
 .include <bsd.port.mk>

Modified: head/devel/p5-Goo-Canvas/pkg-descr
==============================================================================
--- head/devel/p5-Goo-Canvas/pkg-descr	Wed Aug 21 23:07:33 2013	(r325170)
+++ head/devel/p5-Goo-Canvas/pkg-descr	Wed Aug 21 23:21:46 2013	(r325171)
@@ -1,3 +1,3 @@
 Perl interface to the GooCanvas
 
-WWW:	http://search.cpan.org/dist/Goo-Canvas/
+WWW: http://search.cpan.org/dist/Goo-Canvas/

Modified: head/devel/p5-Goo-Canvas/pkg-plist
==============================================================================
--- head/devel/p5-Goo-Canvas/pkg-plist	Wed Aug 21 23:07:33 2013	(r325170)
+++ head/devel/p5-Goo-Canvas/pkg-plist	Wed Aug 21 23:21:46 2013	(r325171)
@@ -38,9 +38,9 @@ bin/perltetris.pl
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/.packlist
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/Canvas.bs
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas/Canvas.so
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo/Canvas
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Goo
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Cairo
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas/Install
-@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas/Install
+@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/Goo/Canvas
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Goo
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"