Bug 179328 - devel/p5-Devel-Global-Destruction is broken
Summary: devel/p5-Devel-Global-Destruction is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frederic Culot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 12:20 UTC by Evgeniy Kosov
Modified: 2013-07-01 15:20 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Kosov 2013-06-05 12:20:00 UTC 
Port devel/p5-Devel-GlobalDestruction seems to be broken (since 0.10), as the XS part of the of the module has been moved to a separate Devel::GlobalDestruction::XS, but the port still references it in the plist:

  # cat pkg-plist 
  %%PP%%%%SITE_PERL%%/Devel/GlobalDestruction.pm
  %%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm
  %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/.packlist
  %%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs
  %%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so
  @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction
  @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel
  %%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction
  %%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel
  %%PP%%@dirrmtry %%SITE_PERL%%/

Fix: 

One (obvious) solutions might be:

1. Create new port: devel/p5-Devel-GlobalDestruction-XS
2. Remove XS-part from the plist
3. Add optional dependency to devel/p5-Devel-GlobalDestruction-XS (if $PERL_LEVEL < 501400?)
How-To-Repeat: Try to make package:

  # make package
  [...]
  ===>  Building package for p5-Devel-GlobalDestruction-0.11
  tar: lib/perl5/site_perl/5.12.4/mach/Devel/GlobalDestruction.pm: Cannot stat: No such file or directory
  tar: lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.bs: Cannot stat: No such file or directory
  tar: lib/perl5/site_perl/5.12.4/mach/auto/Devel/GlobalDestruction/GlobalDestruction.so: Cannot stat: No such file or directory
  tar: Error exit delayed from previous errors.
  pkg_create: make_dist: tar command failed with code 256
  *** Error code 1

  Stop in /usr/ports/devel/p5-Devel-GlobalDestruction.
Comment 1 Frederic Culot freebsd_committer freebsd_triage 2013-06-05 12:49:39 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->culot

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-07-01 15:16:06 UTC 
Author: culot
Date: Mon Jul  1 14:15:59 2013
New Revision: 322126
URL: http://svnweb.freebsd.org/changeset/ports/322126

Log:
  - Fix dependencies (XS portion is now a distinct port)
  
  PR:		ports/179328
  Submitted by:	Evgeniy Kosov <evgeniy@kosov.su>

Modified:
  head/devel/p5-Devel-GlobalDestruction/Makefile
  head/devel/p5-Devel-GlobalDestruction/pkg-plist

Modified: head/devel/p5-Devel-GlobalDestruction/Makefile
==============================================================================
--- head/devel/p5-Devel-GlobalDestruction/Makefile	Mon Jul  1 13:32:56 2013	(r322125)
+++ head/devel/p5-Devel-GlobalDestruction/Makefile	Mon Jul  1 14:15:59 2013	(r322126)
@@ -3,6 +3,7 @@
 
 PORTNAME=	Devel-GlobalDestruction
 PORTVERSION=	0.11
+PORTREVISION=	1
 CATEGORIES=	devel perl5
 MASTER_SITES=	CPAN
 PKGNAMEPREFIX=	p5-
@@ -23,9 +24,8 @@ MAN3=		Devel::GlobalDestruction.3
 .include <bsd.port.pre.mk>
 
 .if ${PERL_LEVEL} < 501400
-PLIST_SUB+=	PP="@comment " XS=""
-.else
-PLIST_SUB+=	PP="" XS="@comment "
+BUILD_DEPENDS+=	p5-Devel-GlobalDestruction-XS>0:${PORTSDIR}/devel/p5-Devel-GlobalDestruction
+RUN_DEPENDS+=	p5-Devel-GlobalDestruction-XS>0:${PORTSDIR}/devel/p5-Devel-GlobalDestruction
 .endif
 
 .include <bsd.port.post.mk>

Modified: head/devel/p5-Devel-GlobalDestruction/pkg-plist
==============================================================================
--- head/devel/p5-Devel-GlobalDestruction/pkg-plist	Mon Jul  1 13:32:56 2013	(r322125)
+++ head/devel/p5-Devel-GlobalDestruction/pkg-plist	Mon Jul  1 14:15:59 2013	(r322126)
@@ -1,10 +1,5 @@
-%%PP%%%%SITE_PERL%%/Devel/GlobalDestruction.pm
-%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction.pm
+%%SITE_PERL%%/Devel/GlobalDestruction.pm
 %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/.packlist
-%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.bs
-%%XS%%%%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction/GlobalDestruction.so
-@dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction
+@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel/GlobalDestruction
 @dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/auto/Devel
-%%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel/GlobalDestruction
-%%XS%%@dirrmtry %%SITE_PERL%%/%%PERL_ARCH%%/Devel
-%%PP%%@dirrmtry %%SITE_PERL%%/Devel
+@dirrmtry %%SITE_PERL%%/Devel
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Frederic Culot freebsd_committer freebsd_triage 2013-07-01 15:16:32 UTC 
State Changed
From-To: open->closed

Fixed, using your solution. Thanks!