Bug 179398 - audio/mpg123.el isn't broken
Summary: audio/mpg123.el isn't broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 12:30 UTC by Lowell Gilbert
Modified: 2013-06-07 16:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lowell Gilbert 2013-06-07 12:30:00 UTC
audio/mpg123.el is marked broken for failing to fetch.

It fetches fine at the moment.

Fix: 

Just remove the BROKEN line from the makefile.
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2013-06-07 15:24:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-06-07 16:23:34 UTC
Author: wg
Date: Fri Jun  7 15:23:26 2013
New Revision: 320212
URL: http://svnweb.freebsd.org/changeset/ports/320212

Log:
  - Unmark as BROKEN [1]
  - Change DISTFILES and do-fetch to cache the file
  
  PR:		ports/179398 [1]
  Submitted by:	Lowell Gilbert <freebsd-bugs-local@be-well.ilk.org>
  Approved by:	culot / jpaetzel (mentors, implicit)

Modified:
  head/audio/mpg123.el/Makefile
  head/audio/mpg123.el/distinfo

Modified: head/audio/mpg123.el/Makefile
==============================================================================
--- head/audio/mpg123.el/Makefile	Fri Jun  7 15:23:01 2013	(r320211)
+++ head/audio/mpg123.el/Makefile	Fri Jun  7 15:23:26 2013	(r320212)
@@ -7,6 +7,7 @@ CATEGORIES=	audio elisp
 MASTER_SITES=	http://www.gentei.org/~yuuji/software/mpg123el/
 EXTRACT_SUFX=	# empty
 EXTRACT_ONLY=	# empty
+DISTFILES=	mpg123el.cgi?${PORTVERSION}
 
 MAINTAINER=	ports@FreeBSD.org
 COMMENT=	Front-end to mpg123/ogg123 audio player for Emacsen
@@ -20,16 +21,12 @@ NO_BUILD=	yes
 ELISPDIR=	${PREFIX}/share/emacs/site-lisp
 XELISPDIR=	${PREFIX}/lib/xemacs/site-lisp
 
-myFETCH_CMD=	${FETCH_CMD} -AR
-
-BROKEN=		fails to fetch
-
-do-fetch:
-	${myFETCH_CMD} ${FETCH_BEFORE_ARGS} ${MASTER_SITES}/mpg123el.cgi?${PORTVERSION}
+FETCH_ARGS=	-AR
+FETCH_BEFORE_ARGS=	-o mpg123el.cgi?${PORTVERSION}
 
 do-install:
 	${MKDIR} ${ELISPDIR}
-	${INSTALL_DATA} ${DISTDIR}/${DISTNAME} ${ELISPDIR}/${PORTNAME}
+	${INSTALL_DATA} ${DISTDIR}/mpg123el.cgi?${PORTVERSION} ${ELISPDIR}/${PORTNAME}
 # For XEmacs
 	${MKDIR} ${XELISPDIR}
 	${LN} -sf ${ELISPDIR}/${PORTNAME} ${XELISPDIR}/${PORTNAME}

Modified: head/audio/mpg123.el/distinfo
==============================================================================
--- head/audio/mpg123.el/distinfo	Fri Jun  7 15:23:01 2013	(r320211)
+++ head/audio/mpg123.el/distinfo	Fri Jun  7 15:23:26 2013	(r320212)
@@ -1,2 +1,2 @@
-SHA256 (mpg123.el-1.52) = 408e163771949bc3eb0b9758b825fdd80f894381f9ecc1f0181f5668fc82a92f
-SIZE (mpg123.el-1.52) = 110508
+SHA256 (mpg123el.cgi?1.52) = 408e163771949bc3eb0b9758b825fdd80f894381f9ecc1f0181f5668fc82a92f
+SIZE (mpg123el.cgi?1.52) = 110508
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-06-07 16:30:22 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!