Bug 179439 - ftp/rexx-curl: probable fix provided
Summary: ftp/rexx-curl: probable fix provided
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrej Zverev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-09 11:20 UTC by John Marino
Modified: 2013-06-10 13:30 UTC (History)
0 users

See Also:


Attachments
file.diff (340 bytes, patch)
2013-06-09 11:20 UTC, John Marino
no flags Details | Diff
rexx-curl.diff.txt (1.12 KB, text/plain; charset=windows-1252)
2013-06-10 12:44 UTC, John Marino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino 2013-06-09 11:20:00 UTC
I was surprised that rexx-curl got marked broken.  It built fine on dragonfly.
Looking at our patch-configure and the errors freebsd is seeing on this port, I think freebsd needs the value of LD_RXLIB1 that DragonFly has.

I suggest that somebody create a patch for configure that updates LD_RXLIB1 to the same value as shown for DragonFly in the attached patch and see if that fixes the port for FreeBSD.

Fix: Patch attached with submission follows:
Comment 1 John Marino 2013-06-10 12:44:52 UTC
I just signed up for redports account.
The attached patch passed 6 times (8.3, 9.1, 10 for amd64 & i386)

Regards,
John
Comment 2 Andrej Zverev freebsd_committer freebsd_triage 2013-06-10 13:03:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->az

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-06-10 13:26:31 UTC
Author: az
Date: Mon Jun 10 12:26:23 2013
New Revision: 320466
URL: http://svnweb.freebsd.org/changeset/ports/320466

Log:
  - Fix build
  - Trim Makefile
  - NOPORTDOCS -> PORT_OPTIONS:MDOCS
  
  PR:		ports/179439
  Submitted by:	John Marino <draco@marino.st>

Added:
  head/ftp/rexx-curl/files/patch-configure   (contents, props changed)
Modified:
  head/ftp/rexx-curl/Makefile

Modified: head/ftp/rexx-curl/Makefile
==============================================================================
--- head/ftp/rexx-curl/Makefile	Mon Jun 10 12:12:21 2013	(r320465)
+++ head/ftp/rexx-curl/Makefile	Mon Jun 10 12:26:23 2013	(r320466)
@@ -1,10 +1,5 @@
-# ex:ts=8
-# Ports collection makefile for:	rexx-curl
-# Date created:			Nov 11, 2003
-# Whom:	      			ijliao
-#
+# Created by: ijliao
 # $FreeBSD$
-#
 
 PORTNAME=	curl
 PORTVERSION=	1.4
@@ -18,10 +13,9 @@ MAINTAINER=	ports@FreeBSD.org
 COMMENT=	External function package providing an interface to the cURL package
 
 BUILD_DEPENDS=	rexx:${PORTSDIR}/lang/rexx-regina
-LIB_DEPENDS=	curl.6:${PORTSDIR}/ftp/curl
+LIB_DEPENDS=	curl:${PORTSDIR}/ftp/curl
 RUN_DEPENDS=	rexx:${PORTSDIR}/lang/rexx-regina
 
-BROKEN=		fails to build
 USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
 CPPFLAGS+=	${PTHREAD_CFLAGS}
@@ -32,12 +26,14 @@ USE_LDCONFIG=	yes
 DOCSDIR=	${PREFIX}/share/doc/rexx${PORTNAME}
 DATADIR=	${PREFIX}/share/rexx${PORTNAME}
 
+.include <bsd.port.options.mk>
+
 post-patch:
 	@${REINPLACE_CMD} -e "s| -lc | |g" -e "/\$(sharedir)\/images/d" \
 		-e "/index.html/d" -e "/rxcurl64.png/d" ${WRKSRC}/Makefile.in
 
 post-install:
-.if !defined(NOPORTDOCS)
+.if ${PORT_OPTIONS:MDOCS}
 	@${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/doc/index.html ${DOCSDIR}
 	@${MKDIR} ${DOCSDIR}/images

Added: head/ftp/rexx-curl/files/patch-configure
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/ftp/rexx-curl/files/patch-configure	Mon Jun 10 12:26:23 2013	(r320466)
@@ -0,0 +1,16 @@
+--- configure.orig	2005-07-28 11:01:07.000000000 +0000
++++ configure
+@@ -6240,8 +6240,12 @@ case "$target" in
+ 		LD_RXLIB1="${CC} -shared"
+ 		LD_RXTRANSLIB1="$LD_RXLIB1"
+ 		;;
++	*dragonfly*)
++		LD_RXLIB1="${CC} -shared"
++		LD_RXTRANSLIB1="$LD_RXLIB1"
++		;;
+ 	*freebsd*)
+-		LD_RXLIB1="ld -Bdynamic -Bshareable"
++		LD_RXLIB1="${CC} -shared"
+ 		LD_RXTRANSLIB1="$LD_RXLIB1"
+ 		;;
+ 	*pc-sco*)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Andrej Zverev freebsd_committer freebsd_triage 2013-06-10 13:29:28 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!