Bug 179489 - [patch] math/algotutor
Summary: [patch] math/algotutor
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Kevin Lo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-11 14:40 UTC by javad.kouhi
Modified: 2013-06-13 07:20 UTC (History)
0 users

See Also:


Attachments
file.diff (890 bytes, patch)
2013-06-11 14:40 UTC, javad.kouhi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description javad.kouhi 2013-06-11 14:40:00 UTC
The perl version is hard coded into files/patch-algotutor. More informations:

http://forums.freebsd.org/showthread.php?t=40209

How-To-Repeat: 1. Update the ports tree
2. Install math/algotutor
3. Try running the program, the following error message will be shown:

% algotutor
Can't locate utilalgo in @INC (@INC contains: /usr/local/lib/perl5/site_perl/5.8.8/algotutor /usr/local/lib/perl5/5.14.2/BSDPAN /usr/local/lib/perl5/site_perl/5.14.2/mach /usr/local/lib/perl5/site_perl/5.14.2 /usr/local/lib/perl5/5.14.2/mach /usr/local/lib/perl5/5.14.2 . /usr/local/bin/) at /usr/local/bin/algotutor line 28.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-11 14:40:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kevlo

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-06-13 07:11:48 UTC
Author: kevlo
Date: Thu Jun 13 06:11:34 2013
New Revision: 320734
URL: http://svnweb.freebsd.org/changeset/ports/320734

Log:
  Don't hard code the perl version. While here, fix MASTER_SITES.
  
  PR:	ports/179489
  Submitted by:	Javad Kouhi <javad dot kouhi at gmail.com>

Modified:
  head/math/algotutor/Makefile
  head/math/algotutor/files/patch-algotutor
  head/math/algotutor/pkg-descr

Modified: head/math/algotutor/Makefile
==============================================================================
--- head/math/algotutor/Makefile	Thu Jun 13 05:54:33 2013	(r320733)
+++ head/math/algotutor/Makefile	Thu Jun 13 06:11:34 2013	(r320734)
@@ -1,19 +1,14 @@
-# New ports collection makefile for:	algotutor
-# Date created:		19 January 2005
-# Whom:			Kevin Lo <kevlo@FreeBSD.org>
-#
 # $FreeBSD$
-#
 
 PORTNAME=	algotutor
 PORTVERSION=	0.8.6
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	math
-MASTER_SITES=	http://saturn.stu.edu.tw/~ckhung/dl/
+MASTER_SITES=	http://www.cyut.edu.tw/~ckhung/dl/
 EXTRACT_SUFX=	.tgz
 
 MAINTAINER=	kevlo@FreeBSD.org
-COMMENT=	An interactive tutorial for algorithms and data structures
+COMMENT=	Interactive tutorial for algorithms and data structures
 
 BUILD_DEPENDS=	p5-Tk>=0:${PORTSDIR}/x11-toolkits/p5-Tk
 RUN_DEPENDS:=	${BUILD_DEPENDS}
@@ -31,6 +26,8 @@ LIBFILES=	BST.pm Board.pm Collection.pm 
 post-patch:
 	${REINPLACE_CMD}  -e 's,#!/usr/bin/perl,#!${PERL},' ${WRKSRC}/algotutor
 	${PERL} -pi -e "s'!!PREFIX!!'${PREFIX}'g" ${WRKSRC}/algotutor
+	${REINPLACE_CMD} -e 's,!!PERL_VERSION!!,${PERL_VERSION},' \
+		${WRKSRC}/algotutor
 
 do-install:
 	${MKDIR} ${SITE_PERL}/algotutor

Modified: head/math/algotutor/files/patch-algotutor
==============================================================================
--- head/math/algotutor/files/patch-algotutor	Thu Jun 13 05:54:33 2013	(r320733)
+++ head/math/algotutor/files/patch-algotutor	Thu Jun 13 06:11:34 2013	(r320734)
@@ -5,7 +5,7 @@
  use strict;
  use Getopt::Std;
 -use lib '/usr/share/perl5/algotutor';
-+use lib '!!PREFIX!!/lib/perl5/site_perl/5.8.8/algotutor';
++use lib '!!PREFIX!!/lib/perl5/site_perl/!!PERL_VERSION!!/algotutor';
  
  BEGIN {
      my ($path) = $0 =~ m#(.*/)#;

Modified: head/math/algotutor/pkg-descr
==============================================================================
--- head/math/algotutor/pkg-descr	Thu Jun 13 05:54:33 2013	(r320733)
+++ head/math/algotutor/pkg-descr	Thu Jun 13 06:11:34 2013	(r320734)
@@ -2,4 +2,4 @@ Algotutor is an interactive program for 
 steps of algorithms. The target audience is computer science students 
 and/or anyone who studies algorithms and/or data structures. 
 
-WWW:	http://www.cyut.edu.tw/~ckhung/p/algotutor/
+WWW: http://www.cyut.edu.tw/~ckhung/p/algotutor/
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Kevin Lo freebsd_committer freebsd_triage 2013-06-13 07:11:53 UTC
State Changed
From-To: open->closed

Committed, thanks.