Bug 179775 - [PATCH] audio/lxmusic: modernize Makefile, add license
Summary: [PATCH] audio/lxmusic: modernize Makefile, add license
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 17:00 UTC by nemysis
Modified: 2013-06-20 22:20 UTC (History)
1 user (show)

See Also:


Attachments
lxmusic-0.4.5.patch (6.57 KB, patch)
2013-06-20 17:00 UTC, nemysis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nemysis 2013-06-20 17:00:00 UTC
- Trim Makefile header
- Add license (MIT GPLv2)
- Add desktop dependency
- Add docs
- Add NLS Option
- Fix NLS
- Trim pkg-plist

Port maintainer (ericturgeon@ghostbsd.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)

How-To-Repeat: 
Build log

https://redports.org/buildarchive/20130620145100-63721/
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-20 17:00:08 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-20 17:00:08 UTC
Maintainer of audio/lxmusic,

Please note that PR ports/179775 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179775

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Eric Turgeon 2013-06-20 20:20:43 UTC
I approve the patch for audio/lxmusic.


On Thu, Jun 20, 2013 at 1:00 PM, Edwin Groothuis <edwin@freebsd.org> wrote:

> Maintainer of audio/lxmusic,
>
> Please note that PR ports/179775 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179775
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>



-- 
*Eric Turgeon
**GhostBSD project*
Office location:
1-11 connaught
Moncton NB Canada
www.ghostbsd.org <http://www.ghostbsd.org/>
Comment 4 William Grzybowski freebsd_committer freebsd_triage 2013-06-20 21:27:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2013-06-20 21:40:19 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 dfilter service freebsd_committer freebsd_triage 2013-06-20 22:13:02 UTC
Author: wg
Date: Thu Jun 20 21:12:54 2013
New Revision: 321425
URL: http://svnweb.freebsd.org/changeset/ports/321425

Log:
  audio/lxmusic: minor fixes
  
  - Add LICENSE (MIT GPLv2)
  - Use desktop-file-utils
  - Add NLS and DOCS options
  - Add Created by in Makefile header
  
  PR:		ports/179775
  Submitted by:	nemysis <nemysis@gmx.ch>
  Approved by:	maintainer

Modified:
  head/audio/lxmusic/Makefile
  head/audio/lxmusic/pkg-plist

Modified: head/audio/lxmusic/Makefile
==============================================================================
--- head/audio/lxmusic/Makefile	Thu Jun 20 20:40:29 2013	(r321424)
+++ head/audio/lxmusic/Makefile	Thu Jun 20 21:12:54 2013	(r321425)
@@ -1,3 +1,4 @@
+# Created by: Eric Turgeon <ericturgeon.bsd at gmail.com>
 # $FreeBSD$
 
 PORTNAME=	lxmusic
@@ -8,18 +9,46 @@ MASTER_SITES=	SF/ghostbsdproject/package
 MAINTAINER=	ericturgeon@ghostbsd.org
 COMMENT=	LXDE music player based on xmms2
 
+LICENSE=	MIT GPLv2
+LICENSE_COMB=	dual
+
 LIB_DEPENDS=	xmmsclient:${PORTSDIR}/audio/xmms2 \
 		notify:${PORTSDIR}/devel/libnotify
 
+USES=		desktop-file-utils
 USE_GNOME=	gtk20
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-USES=		gettext
+USE_GMAKE=	yes
 INSTALLS_ICONS=	yes
+
 CPPFLAGS+=	-I${LOCALBASE}/include ${PTHREAD_CFLAGS}
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 
+PORTDOCS=	AUTHORS README
+
+OPTIONS_DEFINE=	DOCS NLS
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
+USES+=		gettext
+PLIST_SUB+=	NLS=""
+.else
+CONFIGURE_ARGS+=--disable-nls
+PLIST_SUB+=	NLS="@comment "
+.endif
+
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|data po|data|' \
+		${WRKSRC}/Makefile.in
+
+.endif
+
 post-install:
-	@-${LOCALBASE}/bin/update-desktop-database > /dev/null
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>

Modified: head/audio/lxmusic/pkg-plist
==============================================================================
--- head/audio/lxmusic/pkg-plist	Thu Jun 20 20:40:29 2013	(r321424)
+++ head/audio/lxmusic/pkg-plist	Thu Jun 20 21:12:54 2013	(r321425)
@@ -1,64 +1,62 @@
 bin/lxmusic
 share/applications/lxmusic.desktop
-share/locale/af/LC_MESSAGES/lxmusic.mo
-share/locale/ar/LC_MESSAGES/lxmusic.mo
-share/locale/bg/LC_MESSAGES/lxmusic.mo
-share/locale/bn_IN/LC_MESSAGES/lxmusic.mo
-share/locale/ca/LC_MESSAGES/lxmusic.mo
-share/locale/cs/LC_MESSAGES/lxmusic.mo
-share/locale/da/LC_MESSAGES/lxmusic.mo
-share/locale/de/LC_MESSAGES/lxmusic.mo
-share/locale/el/LC_MESSAGES/lxmusic.mo
-share/locale/es/LC_MESSAGES/lxmusic.mo
-share/locale/es_VE/LC_MESSAGES/lxmusic.mo
-share/locale/et/LC_MESSAGES/lxmusic.mo
-share/locale/eu/LC_MESSAGES/lxmusic.mo
-share/locale/fa/LC_MESSAGES/lxmusic.mo
-share/locale/fi/LC_MESSAGES/lxmusic.mo
-share/locale/fr/LC_MESSAGES/lxmusic.mo
-share/locale/frp/LC_MESSAGES/lxmusic.mo
-share/locale/gl/LC_MESSAGES/lxmusic.mo
-share/locale/he/LC_MESSAGES/lxmusic.mo
-share/locale/hr/LC_MESSAGES/lxmusic.mo
-share/locale/hu/LC_MESSAGES/lxmusic.mo
-share/locale/id/LC_MESSAGES/lxmusic.mo
-share/locale/it/LC_MESSAGES/lxmusic.mo
-share/locale/ja/LC_MESSAGES/lxmusic.mo
-share/locale/ko/LC_MESSAGES/lxmusic.mo
-share/locale/lt/LC_MESSAGES/lxmusic.mo
-share/locale/ml/LC_MESSAGES/lxmusic.mo
-share/locale/ms/LC_MESSAGES/lxmusic.mo
-share/locale/nb/LC_MESSAGES/lxmusic.mo
-share/locale/nl/LC_MESSAGES/lxmusic.mo
-share/locale/nn/LC_MESSAGES/lxmusic.mo
-share/locale/pl/LC_MESSAGES/lxmusic.mo
-share/locale/ps/LC_MESSAGES/lxmusic.mo
-share/locale/pt/LC_MESSAGES/lxmusic.mo
-share/locale/pt_BR/LC_MESSAGES/lxmusic.mo
-share/locale/ru/LC_MESSAGES/lxmusic.mo
-share/locale/sk/LC_MESSAGES/lxmusic.mo
-share/locale/sl/LC_MESSAGES/lxmusic.mo
-share/locale/sr/LC_MESSAGES/lxmusic.mo
-share/locale/sv/LC_MESSAGES/lxmusic.mo
-share/locale/tr/LC_MESSAGES/lxmusic.mo
-share/locale/uk/LC_MESSAGES/lxmusic.mo
-share/locale/ur/LC_MESSAGES/lxmusic.mo
-share/locale/ur_PK/LC_MESSAGES/lxmusic.mo
-share/locale/vi/LC_MESSAGES/lxmusic.mo
-share/locale/zh_CN/LC_MESSAGES/lxmusic.mo
-share/locale/zh_TW/LC_MESSAGES/lxmusic.mo
-share/lxmusic/lxmusic.ui.glade
-share/lxmusic/popup.ui.glade
-share/lxmusic/pref-dlg.ui.glade
-share/lxmusic/track-info.ui.glade
+%%NLS%%share/locale/af/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ar/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/bn_IN/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/da/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/de/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/el/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/es/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/es_VE/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/et/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/eu/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fa/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/frp/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/gl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/he/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/hr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/hu/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/id/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/it/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ko/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/lt/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ml/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ms/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nb/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nn/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ps/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pt/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pt_BR/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sk/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/tr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ur/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ur_PK/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/vi/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/zh_TW/LC_MESSAGES/lxmusic.mo
+%%DATADIR%%/lxmusic.ui.glade
+%%DATADIR%%/popup.ui.glade
+%%DATADIR%%/pref-dlg.ui.glade
+%%DATADIR%%/track-info.ui.glade
 share/pixmaps/lxmusic.png
-@dirrm share/lxmusic
-@dirrmtry share/locale/ur_PK/LC_MESSAGES
-@dirrmtry share/locale/ur_PK
-@dirrmtry share/locale/frp/LC_MESSAGES
-@dirrmtry share/locale/frp
-@dirrmtry share/locale/es_VE/LC_MESSAGES
-@dirrmtry share/locale/es_VE
+@dirrm %%DATADIR%%
+%%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
 @dirrmtry share/applications
-@exec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
-@unexec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 7 William Grzybowski freebsd_committer freebsd_triage 2013-06-20 22:13:04 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!