Bug 179791 - devel/subversion: pkg-plist assumes new non-default option TOOLS is on
Summary: devel/subversion: pkg-plist assumes new non-default option TOOLS is on
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 23:30 UTC by Lawrence Chen
Modified: 2013-06-21 17:41 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lawrence Chen 2013-06-20 23:30:00 UTC
	Package creation from devel/subversion ports fails, because pkg-plist
	can't find mod_dontdothat.la which is controlled by new option
	TOOLS which is not set as default.

Fix: 

The line should probably be conditional on whether subversion is built
	with the TOOLS option or not.
How-To-Repeat: 	make package
	
	===>>> Creating a package for new version subversion-1.8.0_1
	tar: share/subversion/server-side/mod_dontdothat/mod_dontdothat.la: Cannot stat: No such file or directory
	tar: Error exit delayed from previous errors.
	pkg_create: make_dist: tar command failed with code 256
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-20 23:30:09 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lev

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-06-21 17:39:22 UTC
Author: lev
Date: Fri Jun 21 16:39:15 2013
New Revision: 321477
URL: http://svnweb.freebsd.org/changeset/ports/321477

Log:
    Don't copy *.la files to tools directory.
  
  PR:		ports/179791
  Submitted by:	Lawrence Chen <beastie@tardisi.com>

Modified:
  head/devel/subversion/Makefile
  head/devel/subversion/pkg-plist

Modified: head/devel/subversion/Makefile
==============================================================================
--- head/devel/subversion/Makefile	Fri Jun 21 15:27:01 2013	(r321476)
+++ head/devel/subversion/Makefile	Fri Jun 21 16:39:15 2013	(r321477)
@@ -256,7 +256,7 @@ post-install:	${MKREPOS_TARGET}
 .endif
 	@${MKDIR} ${DATADIR}
 	cd ${WRKSRC}/tools ; \
-	  ${TAR} --exclude '*.in' --exclude '.libs' --exclude '*.o' --exclude '*.lo' --exclude='*.slo' -cf - * | ${TAR} -C ${DATADIR} -xf -
+	  ${TAR} --exclude '*.in' --exclude '.libs' --exclude '*.o' --exclude '*.lo' --exclude '*.la' --exclude='*.slo' -cf - * | ${TAR} -C ${DATADIR} -xf -
 # ugly hack to remove libtool scripts ...
 	@${GREP} -R ${WRKSRC} ${DATADIR} | ${CUT} -d\: -f 1 | ${XARGS} ${RM} -f
 	@${CHMOD} -R a-st,o+rX ${DATADIR}

Modified: head/devel/subversion/pkg-plist
==============================================================================
--- head/devel/subversion/pkg-plist	Fri Jun 21 15:27:01 2013	(r321476)
+++ head/devel/subversion/pkg-plist	Fri Jun 21 16:39:15 2013	(r321477)
@@ -202,7 +202,6 @@ lib/libsvn_wc-1.la
 %%DATADIR%%/hook-scripts/validate-files.conf.example
 %%DATADIR%%/hook-scripts/validate-files.py
 %%DATADIR%%/server-side/fsfs-stats.c
-%%DATADIR%%/server-side/mod_dontdothat/mod_dontdothat.la
 %%DATADIR%%/server-side/svnauthz.c
 %%DATADIR%%/server-side/svnpredumpfilter.py
 %%DATADIR%%/server-side/svnpubsub/README.txt
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Lev A. Serebryakov freebsd_committer freebsd_triage 2013-06-21 17:41:25 UTC
State Changed
From-To: open->closed


Fixed, thanks!