Bug 179809 - [PATCH] devel/libtool: Add support for lang/clang33
Summary: [PATCH] devel/libtool: Add support for lang/clang33
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bernhard Froehlich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 14:30 UTC by Bernhard Froehlich
Modified: 2013-09-01 14:10 UTC (History)
0 users

See Also:


Attachments
file.diff (1.25 KB, patch)
2013-06-21 14:30 UTC, Bernhard Froehlich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Froehlich freebsd_committer freebsd_triage 2013-06-21 14:30:00 UTC
The new lang/clang33 port installs it's binaries as clang33 and clang++33 which causes libtool to fail for various ports and ask for a "--tag" flag because it seems to detect tag based on the binary name it was called with. We already have a patch in our libtool port for that but it does not honor clang33 yet so I streamlined the patch to be similar to gcc also support further clang versions.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-21 14:30:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->autotools

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2013-08-30 19:47:56 UTC
Responsible Changed
From-To: autotools->decke

maintainer timeout
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-09-01 14:03:08 UTC
Author: decke
Date: Sun Sep  1 13:02:56 2013
New Revision: 325855
URL: http://svnweb.freebsd.org/changeset/ports/325855

Log:
  - Add support for lang/clang33 from ports which installs it's binaries as
  clang33 and clang++33. Right now libtool fails for various ports and aks
  for a "--tag" flag because it tries to detect tag based on the binary name
  but doesn't know about clang33.
  
  PR:		ports/179809
  Submitted by:	myself
  Approved by:	maintainer timeout (9 weeks)

Modified:
  head/devel/libtool/Makefile   (contents, props changed)
  head/devel/libtool/files/patch-libltdl_config_ltmain.sh   (contents, props changed)

Modified: head/devel/libtool/Makefile
==============================================================================
--- head/devel/libtool/Makefile	Sun Sep  1 12:58:10 2013	(r325854)
+++ head/devel/libtool/Makefile	Sun Sep  1 13:02:56 2013	(r325855)
@@ -7,6 +7,7 @@
 
 PORTNAME?=	libtool
 PORTVERSION=	2.4.2
+PORTREVISION=	1
 CATEGORIES=	devel
 MASTER_SITES=	${MASTER_SITE_GNU}
 MASTER_SITE_SUBDIR=	libtool

Modified: head/devel/libtool/files/patch-libltdl_config_ltmain.sh
==============================================================================
--- head/devel/libtool/files/patch-libltdl_config_ltmain.sh	Sun Sep  1 12:58:10 2013	(r325854)
+++ head/devel/libtool/files/patch-libltdl_config_ltmain.sh	Sun Sep  1 13:02:56 2013	(r325855)
@@ -4,8 +4,8 @@
      $opt_debug
 +
 +    # FreeBSD-specific: where we install compilers with non-standard names
-+    tag_compilers_CC="*cc cc* *gcc gcc* clang"
-+    tag_compilers_CXX="*c++ c++* *g++ g++* clang++"
++    tag_compilers_CC="*cc cc* *gcc gcc* clang*"
++    tag_compilers_CXX="*c++ c++* *g++ g++* clang++*"
 +    base_compiler=`set -- "$@"; echo $1`
 +
 +    # If $tagname isn't set, then try to infer if the default "CC" tag applies
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Bernhard Froehlich freebsd_committer freebsd_triage 2013-09-01 14:03:56 UTC
State Changed
From-To: open->closed

Committed. Thanks!