Bug 179925 - Fix for ports/mail/majordomo/Makefile dialog
Summary: Fix for ports/mail/majordomo/Makefile dialog
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Anders Nordby
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 12:20 UTC by jhs
Modified: 2013-09-04 21:41 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (970 bytes, patch)
2013-06-24 12:20 UTC, jhs
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jhs 2013-06-24 12:20:01 UTC
Fix for broken ports/mail/majordomo/Makefile dialog.

	
The dialog line previously worked in 8.2 but broke in 9.1 with:
        Error: Expected no more than 3 tokens for --yesno, have 4.
Reason: dialog syntax changed, man dialog:
        8.2 --yesno text height width [ yes | no ]
        9.1 --yesno text height width
Alternatives:
- 9.1 has --defaultno but 8.2 does not have --defaultno.
- a multi line .if depending on variants of uname -r would be bulky,
  & I don't need it.  When I cd majordomo I want it !

Fix: Apply fix appended.
----------------
http://www.berklix.com/~jhs/public_html/src/bsd/fixes/FreeBSD/ports/gen/mail/majordomo/Makefile.REL=9.1-RELEASE.diff

Fix for broken majordomo.
The dialog line previously worked in 8.2 but broke in 9.1 with:
	Error: Expected no more than 3 tokens for --yesno, have 4.
Reason: dialog syntax changed, man dialog:
	8.2 --yesno text height width [ yes | no ]
	9.1 --yesno text height width
Alternatives:
- 9.1 has --defaultno but 8.2 does not have --defaultno.
- a multi line .if depending on variants of uname -r would be bulky,
  & I don't need it.  When I cd majordomo I want it !

How-To-Repeat: 	
cd /usr/ports/mail/majordomo ; make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-24 12:20:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->anders

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-09-04 21:27:21 UTC
Author: anders
Date: Wed Sep  4 20:27:13 2013
New Revision: 326319
URL: http://svnweb.freebsd.org/changeset/ports/326319

Log:
  Remove no parameter for --yesno which does not work in 9.x
  
  Submitted by:	jhs@FreeBSD.ORG
  PR:		179925

Modified:
  head/mail/majordomo/Makefile

Modified: head/mail/majordomo/Makefile
==============================================================================
--- head/mail/majordomo/Makefile	Wed Sep  4 20:13:49 2013	(r326318)
+++ head/mail/majordomo/Makefile	Wed Sep  4 20:27:13 2013	(r326319)
@@ -30,7 +30,7 @@ DOCSDIR=	${PREFIX}/${PORTNAME}/doc
 
 pre-fetch:
 .if !defined(BATCH) && !defined(PACKAGE_BUILDING)
-	${DIALOG} --yesno "WARNING: Majordomo is a really old mail list manager. The last version was released in january 2000, and there does not seem to be any updates coming. You might want to consider using mailman instead. Are you sure you want to install majordomo?" 8 70 no || ${FALSE}
+	${DIALOG} --yesno "WARNING: Majordomo is a really old mail list manager. The last version was released in january 2000, and there does not seem to be any updates coming. You might want to consider using mailman instead. Are you sure you want to install majordomo?" 8 70 || ${FALSE}
 .endif
 
 post-patch:
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Anders Nordby freebsd_committer freebsd_triage 2013-09-04 21:40:55 UTC
State Changed
From-To: open->closed

Fix committed, thanks.