Bug 179930 - math/parmetis installs libmetis.a but not associated metis.h file
Summary: math/parmetis installs libmetis.a but not associated metis.h file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 16:30 UTC by Thomas Russo
Modified: 2013-12-27 23:41 UTC (History)
0 users

See Also:


Attachments
file.diff (787 bytes, patch)
2013-06-24 16:30 UTC, Thomas Russo
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Russo 2013-06-24 16:30:01 UTC
The math/parmetis port installs libmetis.a, but does not install the associated metis.h file.

Software that requires both metis and parmetis (such as the Trilinos package, http://trilinos.sandia.gov/) could build just fine with only the parmetis port if the port would install metis.h as well as libmetis.a.

Fix: Apply the attached patch.  It merely adds an install of the metis.h file to the existing build system.

Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-06-24 16:30:13 UTC
Responsible Changed
From-To: freebsd-ports-bugs->bf

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 John Marino freebsd_committer freebsd_triage 2013-12-27 23:18:34 UTC
Responsible Changed
From-To: bf->marino

I'll overtake it (timeout)
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-12-27 23:33:42 UTC
Author: marino
Date: Fri Dec 27 23:33:34 2013
New Revision: 337824
URL: http://svnweb.freebsd.org/changeset/ports/337824

Log:
  math/parmetis: Add metis.h file, support stage
  
  Install metis.h file in order to support software that requires both
  metis and parmetis such as Trilino <http://trilinos.org>.  While here,
  support stage.
  
  PR:		ports/179930
  Approved by:	maintainer timeout (6 months)

Modified:
  head/math/parmetis/Makefile

Modified: head/math/parmetis/Makefile
==============================================================================
--- head/math/parmetis/Makefile	Fri Dec 27 23:08:02 2013	(r337823)
+++ head/math/parmetis/Makefile	Fri Dec 27 23:33:34 2013	(r337824)
@@ -3,7 +3,7 @@
 
 PORTNAME=	ParMetis
 PORTVERSION=	4.0
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	math parallel
 MASTER_SITES=	http://glaros.dtc.umn.edu/gkhome/fetch/sw/parmetis/%SUBDIR%/
 MASTER_SITE_SUBDIR=	. OLD
@@ -23,12 +23,15 @@ OPENMPI_DESC=	Use openmpi instead of mpi
 USES=		cmake gmake
 
 MAKE_ARGS+=	MAKEFLAGS=MAKE=${GMAKE}
-PORTDOCS=	manual.pdf
-PLIST_FILES=	include/parmetis/parmetis.h \
-		lib/parmetis/libmetis.a lib/parmetis/libparmetis.a
-PLIST_DIRS=	include/parmetis lib/parmetis
+PLIST_FILES=	include/parmetis/metis.h \
+		include/parmetis/parmetis.h \
+		lib/parmetis/libmetis.a \
+		lib/parmetis/libparmetis.a \
+		${DOCSDIR}/manual.pdf
+PLIST_DIRS=	include/parmetis \
+		lib/parmetis \
+		${DOCSDIR}
 
-NO_STAGE=	yes
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MOPENMPI}
@@ -53,14 +56,16 @@ do-configure:
 		${MAKEFILE} config prefix="${PREFIX}" cc="${MPICC}"
 
 do-install:
-	@${MKDIR} ${PREFIX}/include/parmetis
-	${INSTALL_DATA} ${WRKSRC}/include/parmetis.h ${PREFIX}/include/parmetis
-	@${MKDIR} ${PREFIX}/lib/parmetis
-	${INSTALL_DATA} ${WRKSRC}/build/libmetis/libmetis.a ${PREFIX}/lib/parmetis
-	${INSTALL_DATA} ${WRKSRC}/build/libparmetis/libparmetis.a ${PREFIX}/lib/parmetis
-.if ${PORT_OPTIONS:MDOCS}
-	@${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${WRKSRC}/manual/manual.pdf ${DOCSDIR}
-.endif
+	@${MKDIR} ${STAGEDIR}${PREFIX}/include/parmetis \
+		${STAGEDIR}${PREFIX}/lib/parmetis \
+		${STAGEDIR}${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/include/parmetis.h \
+		${WRKSRC}/metis/include/metis.h \
+		${STAGEDIR}${PREFIX}/include/parmetis
+	${INSTALL_DATA} ${WRKSRC}/build/libmetis/libmetis.a \
+		${STAGEDIR}${PREFIX}/lib/parmetis
+	${INSTALL_DATA} ${WRKSRC}/build/libparmetis/libparmetis.a \
+		${STAGEDIR}${PREFIX}/lib/parmetis
+	${INSTALL_DATA} ${WRKSRC}/manual/manual.pdf ${STAGEDIR}${DOCSDIR}
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 John Marino freebsd_committer freebsd_triage 2013-12-27 23:40:59 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!