This port won't build with the non-default pgsql 92 client. slony1_funcs.c: In function '_Slony_I_logTrigger': slony1_funcs.c:515: error: dereferencing pointer to incomplete type slony1_funcs.c:537: error: dereferencing pointer to incomplete type slony1_funcs.c:586: error: too few arguments to function 'set_config_option' slony1_funcs.c:587: error: dereferencing pointer to incomplete type slony1_funcs.c:626: error: too few arguments to function 'set_config_option' slony1_funcs.c:640: error: dereferencing pointer to incomplete type slony1_funcs.c:664: error: dereferencing pointer to incomplete type slony1_funcs.c:750: error: too few arguments to function 'set_config_option' slony1_funcs.c:752: error: too few arguments to function 'set_config_option' slony1_funcs.c:783: error: dereferencing pointer to incomplete type slony1_funcs.c:823: error: dereferencing pointer to incomplete type slony1_funcs.c:838: error: dereferencing pointer to incomplete type slony1_funcs.c:877: error: dereferencing pointer to incomplete type slony1_funcs.c:893: error: dereferencing pointer to incomplete type slony1_funcs.c:905: error: dereferencing pointer to incomplete type slony1_funcs.c: In function '_Slony_I_denyAccess': slony1_funcs.c:1012: error: dereferencing pointer to incomplete type slony1_funcs.c: In function '_Slony_I_lockedSet': slony1_funcs.c:1052: error: dereferencing pointer to incomplete type slony1_funcs.c: In function 'slon_quote_literal': slony1_funcs.c:1114: warning: pointer targets in passing argument 1 of 'pg_mblen' differ in signedness Fix: This looks like the last version of Slony1. Suggest adding makefile directives to indicate that pgsql 92 not supported, e.g. WANT_PGSQL_VERSION= 91- How-To-Repeat: Set the default pgsql version to 92, then rebuild everything including this port
Maintainer of databases/slony1, Please note that PR ports/179958 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/179958 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I agree. slony1 v 1.2 hasn't bee updated in over a year. I don't know = for sure what maximum version of postgres it supports. I do not think it = is actively maintained anymore, but exists for historical installations = of older postgres. If the proposed patch will disallow building slony1 against versions of = postgres newer than 9.1, then go for it. I don't know what other = solutions there are. Personally, I've moved on to slony1 version 2.1.=
On 6/25/2013 16:10, Vick Khera wrote: > If the proposed patch will disallow building slony1 against versions > of postgres newer than 9.1, then go for it. I don't know what other > solutions there are. To be clear, it was just an example. Obviously pgsql 90 is supported, but I don't know if 91 is. To do this right, that would have be determined. To do it not so well, mark 90 as the latest because that's known. Regards, John
State Changed From-To: feedback->open Maintainer has approved.
Responsible Changed From-To: freebsd-ports-bugs->marino It is open and nobody else took it.
Author: marino Date: Sun Jul 21 12:57:10 2013 New Revision: 323379 URL: http://svnweb.freebsd.org/changeset/ports/323379 Log: databases/slony1: Limit to pgsql version 9.1 and below Slony1 will not build on PostgreSQL 9.2, so indicate this in the makefile. Users should migrate to version 2 (databases/slonyIv2) as version 1.2 is no longer maintained. PR: ports/179958 Submitted by: marino Approved by: bapt (mentor), maintainer Modified: head/databases/slony1/Makefile Modified: head/databases/slony1/Makefile ============================================================================== --- head/databases/slony1/Makefile Sun Jul 21 12:41:29 2013 (r323378) +++ head/databases/slony1/Makefile Sun Jul 21 12:57:10 2013 (r323379) @@ -14,11 +14,11 @@ COMMENT= PostgreSQL master to multiple r BUILD_DEPENDS= ${LOCALBASE}/bin/postmaster:${PORTSDIR}/databases/postgresql${PGSQL_VER}-server GNU_CONFIGURE= yes -USES= bison +USES= bison gmake USE_PGSQL= yes -USE_GMAKE= yes USE_BZIP2= yes USE_RC_SUBR= slon +WANT_PGSQL_VER= 91- SUB_FILES= pkg-message slon-mkservice.sh SUB_LIST+= NAME=slon _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks!