A: broken linking (if VirtualBox linked against OpenSSL from ports)
	the port links against OpenSSL's libcrypto, 
	but doesn't honor WITH_OPENSSL_PORT=yes

  	At the same time it links to virtualbox/VBoxRT.so 
        which is linked to either base's or port's 
	OpenSSL's libcrypto

	if VBoxRT is linked to port's OpenSSL then
	istgt binary become linked to 
	both BASE's and PORT's libcrypto

	It may cause program malfunction because of overlapping 
        symbols and structures with identical name

B: broken cast
	There are so many places with the construct like:

	ISTGT_WARNLOG("Connection reset by peer (%s,time=%d)\n",
		conn->initiator_name, (int)difftime(now, start));

	cast from double to int is invalid 
	althougth it raise warning only, resulting code may not 
	work on some architectures at all

C: broken compilation (just for completeness)
	it doesn't compile with VBOXVD option turned on at all
	firing error:
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.2.14/include/VBox/vd.h:182: 
error: expected specifier-qualifier-list before 'PARTITIONING_TYPE'

Fix: A: 1. the libcrypto is used just for the purpose of calculation of MD5 digest.
   istgt needs to be linked against same version (base/ports) of libcrypto
   as virtualbox/VBoxRT.so has been linked to

   2. dependency to port's OpenSSL should be recorded 
      if istgt become linked to it

   Even if we modify the port to link against appropriate 
   libcrypto and record dependency if necesarry, then 
   administrator need to identify what version of libcrypto
   should be used or a complex autodetection logic needs 
   to be implemented

   So I suggest different approach to avoid conflict.
   I replaced libcrypto's MD5_*() by libmd's MD5*(). 
   No conflict may occur, no dependency needs to be recorded,
   no administrator decision nor autodetection logic necesarry 
   at all.

   Required changes are small:
   a)  MD5_Init/MD5_Update/MD5_Final functions 
       are replaced by 
       MD5Init/MD5Update/MD5Final
   b)  openssl/md5.h header reference replaced by reference 
       to sys/types.h and md5.h 
   c)  references to libcrypto replaced by reference to libmd.

   See patch-DAN-replacecrypto

B: printf double as true double not int
   using %.0f format

   As construct in question are used for error logging only,
   not in casual code paths, such change should not affect 
   the performance nor CPU utilisation

   See patch-DAN-invalidcast

C: this bug is not in istgt code but bug in virtualbox header.
   But it doesn't affect compilation of VirtualBox itself.
   I include it just for completeness as istgt is only affected
   software known to me.

   Error is caused by PARTITIONING_TYPE symbol declared as enum in 
   header file but referenced without enum keyword, e.g. 
   like typedef's type. The symbol is not referenced as 'enum' 
   in any place of istgt. Even VirtualBox code (not used during
   standard compilation of VirtualBox) references symbol 
   without 'enum' keyword.

   I added typedef wrapper around it's declaration. It's conform to 
   style of declaration of other enums and structures. I assume
   the wrapper has been forgotten here.

   See emulators/virtualbox-ose/files/patch-DAN-include-VBox-vd.h
   patch

--- emulators/virtualbox-ose/files/patch-DAN-include-VBox-vd.h begins here ---
How-To-Repeat: A: compile VirtualBox with WITH_OPENSSL_PORT=yes, then compile istgt
	see warning past linking command:
	cc -Wl,-rpath,/usr/local/lib/virtualbox -o istgtcontrol istgtcontrol.o istgt_conf.o istgt_log.o istgt_sock.o istgt_misc.o istgt_md5.o -lcam -lcrypto -lpthread  /usr/local/lib/virtualbox/VBoxDDU.so /usr/local/lib/virtualbox/VBoxRT.so

B: see several warnings during compilation:
	cast from function call of type 'double' to non-matching type 'int'

C: turn VBOXVD option on. Compilation will abort with error mentioned 
   in "Description"