Bug 180005 - [bsd.port.mk] [patch] USE_DOS2UNIX doesn't print out the files it's converting
Summary: [bsd.port.mk] [patch] USE_DOS2UNIX doesn't print out the files it's converting
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 18:20 UTC by Greg Lewis
Modified: 2013-10-09 12:40 UTC (History)
0 users

See Also:


Attachments
file.diff (496 bytes, patch)
2013-06-26 18:20 UTC, Greg Lewis
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Lewis freebsd_committer freebsd_triage 2013-06-26 18:20:02 UTC
	When using the USE_DOS2UNIX macro, the message printed out doesn't
	include the file name.  The intention of the code appears to be
	that the file name should be included.

How-To-Repeat: 	Build java/openjdk7.  Near the start of the build you'll see the
	output:

	===>   Converting DOS text file to UNIX text file:

	Note the lack of anything after the colon.
Comment 1 Greg Lewis freebsd_committer freebsd_triage 2013-06-26 21:53:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr-ports-bugs

. Fix up the synopsis a bit and reassign to portmgr.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2013-06-27 00:17:40 UTC
Responsible Changed
From-To: portmgr-ports-bugs->portmgr

fix assignment.
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-10-09 12:30:49 UTC
Author: bdrewery
Date: Wed Oct  9 11:30:42 2013
New Revision: 329882
URL: http://svnweb.freebsd.org/changeset/ports/329882

Log:
  - Fix 'USE_DOS2UNIX= file list' not printing file names since r183768
  
  PR:		ports/180005
  Submitted by:	glewis
  With hat:	portmgr

Modified:
  head/Mk/bsd.port.mk

Modified: head/Mk/bsd.port.mk
==============================================================================
--- head/Mk/bsd.port.mk	Wed Oct  9 10:08:19 2013	(r329881)
+++ head/Mk/bsd.port.mk	Wed Oct  9 11:30:42 2013	(r329882)
@@ -3583,9 +3583,9 @@ patch-dos2unix:
 	@${FIND} -E ${WRKSRC} -type f -iregex '${DOS2UNIX_REGEX}' -print0 | \
 			${XARGS} -0 ${REINPLACE_CMD} -i '' -e 's/
$$//'
 .else
-	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 .if ${USE_DOS2UNIX:M*/*}
 .for f in ${USE_DOS2UNIX}
+	@${ECHO_MSG} "===>   Converting DOS text file to UNIX text file: ${f}"
 	@${REINPLACE_CMD} -i '' -e 's/
$$//' ${WRKSRC}/${f}
 .endfor
 .else
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Bryan Drewery freebsd_committer freebsd_triage 2013-10-09 12:30:50 UTC
State Changed
From-To: open->closed

Committed. Thanks!