Bug 180352 - [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow
Summary: [maintainer-update] Trim/cleanup/convert for games/netrek-client-cow
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-06 20:00 UTC by Kevin Zheng
Modified: 2013-07-06 20:30 UTC (History)
0 users

See Also:


Attachments
file.diff (1.35 KB, patch)
2013-07-06 20:00 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2013-07-06 20:00:00 UTC
Do some cleanup work on my port. This entails:
 - Trim the Makefile header
 - Remove indefinite article
 - Switch from USE_GMAKE to USES= gmake
 - Correctly use ${PREFIX} for sound files
 - Add patch in preparation for sound support that comes with port

I don't plan to bump PORTREVISION just yet; there are no functional changes as sound support doesn't come with the port anyways.

Fix: Apply the attached patch.

Patch attached with submission follows:
Comment 1 Wesley Shields freebsd_committer freebsd_triage 2013-07-06 20:21:20 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2013-07-06 20:29:43 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2013-07-06 20:29:45 UTC
Author: wxs
Date: Sat Jul  6 19:29:38 2013
New Revision: 322408
URL: http://svnweb.freebsd.org/changeset/ports/322408

Log:
  Trim header.
  Remove indefinite article.
  Switch to USES for gmake.
  Use ${PREFIX} for sound files.
  
  PR:		ports/180352
  Submitted by:	Kevin Zheng <kevinz5000@gmail.com> (maintainer)

Modified:
  head/games/netrek-client-cow/Makefile

Modified: head/games/netrek-client-cow/Makefile
==============================================================================
--- head/games/netrek-client-cow/Makefile	Sat Jul  6 19:24:51 2013	(r322407)
+++ head/games/netrek-client-cow/Makefile	Sat Jul  6 19:29:38 2013	(r322408)
@@ -1,9 +1,5 @@
-# New ports collection makefile for:	netrek-client-cow
-# Date created:	20 April 2012
-# Whom:	Kevin Zheng <kevinz5000@gmail.com>
-#
+# Created by: Kevin Zheng <kevinz5000@gmail.com>
 # $FreeBSD$
-#
 
 PORTNAME=	netrek-client-cow
 PORTVERSION=	3.3.1
@@ -13,13 +9,14 @@ MASTER_SITES=	http://www.netrek.org/file
 		http://quozl.us.netrek.org/netrek/
 
 MAINTAINER=	kevinz5000@gmail.com
-COMMENT=	A multi-player battle simulation with a Star Trek theme
+COMMENT=	Multi-player battle simulation with a Star Trek theme
 
 LIB_DEPENDS=	Imlib2:${PORTSDIR}/graphics/imlib2
 
 GNU_CONFIGURE=	yes
-USE_GMAKE=	yes
+USES=		gmake
 USE_SDL=	sdl mixer
+
 CONFIGURE_ARGS+=	NORSA='\#'
 
 post-patch:
@@ -28,7 +25,11 @@ post-patch:
 	${REINPLACE_CMD} -e 's|inline void|void|' \
 		${WRKSRC}/local.[ch]
 	${REINPLACE_CMD} -e 's|/usr|${PREFIX}|' \
-		${WRKSRC}/x11sprite.c ${WRKSRC}/netrek-client-cow.desktop
+		${WRKSRC}/netrek-client-cow.desktop \
+		${WRKSRC}/sound.c \
+		${WRKSRC}/x11sprite.c
+	${REINPLACE_CMD} -e 's|8000, AUDIO_U8, 1|22050, AUDIO_U8, 2|' \
+		${WRKSRC}/sound.c
 	${REINPLACE_CMD} -e 's|games|bin|' \
 		${WRKSRC}/netrek-client-cow.desktop
 
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"