audio/lmms changes : Maintainance release of the 0.4.x series It only contains fixes for bugs and regressions in the previous release.
Responsible Changed From-To: freebsd-ports-bugs->madpilot
Hi! While testing this update I noticed the port fails to build with clang. Here's a full poudriere log from 10-CURRENT on amd64: http://www.madpilot.net/~mad/lmms-0.4.15,2.log The problem is at the end of the log: /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/src/Fl_x.cxx:1861:31: error: 'FORCE_POSITION' is a protected member of 'Fl_Widget' if (w->flags() & Fl_Widget::FORCE_POSITION) { ^ /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/FL/Fl_Widget.H:168:9: note: declared protected here FORCE_POSITION = 1<<4, ///< don't let the window manager position the window (Fl_Window) ^ 4 warnings and 1 error generated. *** Error code 1 It looks like they're trying to use a protected member of a class and the oldish gcc on FreeBSD <10 allows this, clang correctly does not. Maybe just moving the declaration in the public part of the class could solve the problem. Can you investigate this and submit a fix? Thanks! -- Guido Falsi <madpilot@FreeBSD.org>
State Changed From-To: open->feedback Ask for maintainer fix.
On 07/13/13 11:55, Guido Falsi wrote: > Hi! > > While testing this update I noticed the port fails to build with > clang. Here's a full poudriere log from 10-CURRENT on amd64: > > http://www.madpilot.net/~mad/lmms-0.4.15,2.log > > The problem is at the end of the log: > > /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/src/Fl_x.cxx:1861:31: > error: 'FORCE_POSITION' is a protected member of 'Fl_Widget' > if (w->flags() & Fl_Widget::FORCE_POSITION) { > ^ > /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/FL/Fl_Widget.H:168:9: > note: declared protected here > FORCE_POSITION = 1<<4, ///< don't let the window manager > position the window (Fl_Window) > ^ > 4 warnings and 1 error generated. > *** Error code 1 > > It looks like they're trying to use a protected member of a class and > the oldish gcc on FreeBSD <10 allows this, clang correctly does not. > > Maybe just moving the declaration in the public part of the class > could solve the problem. Can you investigate this and submit a fix? > > Thanks! > clang and 10 are problems I should address for my ports in the next weeks, but that's ok, I will fix the issue then resubmit a fix for that. regards - rodrigo
On 07/13/13 11:55, Guido Falsi wrote: > Hi! > > While testing this update I noticed the port fails to build with > clang. Here's a full poudriere log from 10-CURRENT on amd64: > > http://www.madpilot.net/~mad/lmms-0.4.15,2.log > > The problem is at the end of the log: > > /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/src/Fl_x.cxx:1861:31: > error: 'FORCE_POSITION' is a protected member of 'Fl_Widget' > if (w->flags() & Fl_Widget::FORCE_POSITION) { > ^ > /wrkdirs/usr/ports/audio/lmms/work/lmms-0.4.15/plugins/zynaddsubfx/fltk/FL/Fl_Widget.H:168:9: > note: declared protected here > FORCE_POSITION = 1<<4, ///< don't let the window manager > position the window (Fl_Window) > ^ > 4 warnings and 1 error generated. > *** Error code 1 > > It looks like they're trying to use a protected member of a class and > the oldish gcc on FreeBSD <10 allows this, clang correctly does not. > > Maybe just moving the declaration in the public part of the class > could solve the problem. Can you investigate this and submit a fix? > > Thanks! > Hi, I think the issue making Fl_Widget and Fl_x classes friends. It compiles for me in current and redports agree with CLANG Let me know if you find any problem with my changes. regards - rodrigo
State Changed From-To: feedback->open Maintainer has fixed.
Author: madpilot Date: Fri Jul 19 21:38:37 2013 New Revision: 323329 URL: http://svnweb.freebsd.org/changeset/ports/323329 Log: - Update to 0.4.15 - Fix build with clang PR: ports/180455 Submitted by: Rodrigo OSORIO <rodrigo@bebik.net> (maintainer) Added: head/audio/lmms/files/patch-plugins_zynaddsubfx_fltk_FL_Fl_Widget.H (contents, props changed) Modified: head/audio/lmms/Makefile head/audio/lmms/distinfo (contents, props changed) Modified: head/audio/lmms/Makefile ============================================================================== --- head/audio/lmms/Makefile Fri Jul 19 20:57:59 2013 (r323328) +++ head/audio/lmms/Makefile Fri Jul 19 21:38:37 2013 (r323329) @@ -2,7 +2,7 @@ # $FreeBSD$ PORTNAME= lmms -PORTVERSION= 0.4.14 +PORTVERSION= 0.4.15 PORTEPOCH= 2 CATEGORIES= audio MASTER_SITES= SF Modified: head/audio/lmms/distinfo ============================================================================== --- head/audio/lmms/distinfo Fri Jul 19 20:57:59 2013 (r323328) +++ head/audio/lmms/distinfo Fri Jul 19 21:38:37 2013 (r323329) @@ -1,2 +1,2 @@ -SHA256 (lmms-0.4.14.tar.bz2) = 2cdf65009682112107270be09e030fc9db4a467838b2ec39669cc39ade66ec69 -SIZE (lmms-0.4.14.tar.bz2) = 14213318 +SHA256 (lmms-0.4.15.tar.bz2) = 0104caaea8adf7b51b0fc4ff2ab26364d1da5751a8fcbf6772704c8ef57a020b +SIZE (lmms-0.4.15.tar.bz2) = 14211150 Added: head/audio/lmms/files/patch-plugins_zynaddsubfx_fltk_FL_Fl_Widget.H ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/audio/lmms/files/patch-plugins_zynaddsubfx_fltk_FL_Fl_Widget.H Fri Jul 19 21:38:37 2013 (r323329) @@ -0,0 +1,10 @@ +--- plugins/zynaddsubfx/fltk/FL/Fl_Widget.H 2013-06-11 22:57:16.000000000 +0200 ++++ plugins/zynaddsubfx/fltk/FL/Fl_Widget.H 2013-07-19 13:58:16.000000000 +0200 +@@ -108,6 +108,7 @@ + */ + class FL_EXPORT Fl_Widget { + friend class Fl_Group; ++ friend class Fl_X; + + Fl_Group* parent_; + Fl_Callback* callback_; _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!