Bug 180681 - [patch] textproc/urlview fix compiler warnings
Summary: [patch] textproc/urlview fix compiler warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Danilo Egea Gondolfo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-20 18:30 UTC by Anton Shterenlikht
Modified: 2013-11-25 15:10 UTC (History)
0 users

See Also:


Attachments
patch-urlview.c (703 bytes, text/plain)
2013-07-20 18:30 UTC, Anton Shterenlikht
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Shterenlikht 2013-07-20 18:30:00 UTC
This patch must be used *instead of* the current files/patch-urlview.c

Tested on redports
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2013-07-20 19:58:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 2 Bryan Drewery freebsd_committer freebsd_triage 2013-09-22 15:10:24 UTC
Responsible Changed
From-To: miwi->freebsd-ports-bugs

Back to the heap due to timeout
Comment 3 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2013-11-25 15:04:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->danilo

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2013-11-25 15:07:06 UTC
Author: danilo
Date: Mon Nov 25 15:06:59 2013
New Revision: 334855
URL: http://svnweb.freebsd.org/changeset/ports/334855

Log:
  - Fix warnings in urlview.c [1]
  - Add LICENSE
  - Add stage support
  
  PR:		ports/180681
  Submitted by:	Anton Shterenlikht <mexas@bris.ac.uk> (maintainer) [1]

Modified:
  head/textproc/urlview/Makefile
  head/textproc/urlview/files/patch-urlview.c

Modified: head/textproc/urlview/Makefile
==============================================================================
--- head/textproc/urlview/Makefile	Mon Nov 25 14:45:37 2013	(r334854)
+++ head/textproc/urlview/Makefile	Mon Nov 25 15:06:59 2013	(r334855)
@@ -15,19 +15,23 @@ MASTER_SITES=	ftp://ftp.mutt.org/mutt/co
 MAINTAINER=	mexas@bris.ac.uk
 COMMENT=	URL extractor/launcher
 
+LICENSE=	GPLv2
+
 GNU_CONFIGURE=	yes
-MAN1=		urlview.1
 PLIST_FILES=	bin/urlview \
-		etc/urlview.conf.sample
+		etc/urlview.conf.sample \
+		man/man1/urlview.1.gz
+MAKE_ENV=	DESTDIR=${STAGEDIR}
 
-NO_STAGE=	yes
 post-patch:
 	@${REINPLACE_CMD} -e 's,/etc,${PREFIX}&,' \
 		-e 's/url_handler.sh/firefox/' \
 		${WRKSRC}/*
 
-post-install:
+do-install:
+	${INSTALL_PROGRAM} ${WRKSRC}/urlview ${STAGEDIR}${PREFIX}/bin
+	${INSTALL_MAN} ${WRKSRC}/urlview.man ${STAGEDIR}${MAN1PREFIX}/man/man1/urlview.1
 	${INSTALL_DATA} ${WRKSRC}/sample.urlview \
-		${PREFIX}/etc/urlview.conf.sample
+		${STAGEDIR}${PREFIX}/etc/urlview.conf.sample
 
 .include <bsd.port.mk>

Modified: head/textproc/urlview/files/patch-urlview.c
==============================================================================
--- head/textproc/urlview/files/patch-urlview.c	Mon Nov 25 14:45:37 2013	(r334854)
+++ head/textproc/urlview/files/patch-urlview.c	Mon Nov 25 15:06:59 2013	(r334855)
@@ -1,5 +1,5 @@
---- urlview.c.orig	Wed Nov  9 15:34:39 2005
-+++ urlview.c	Wed Nov  9 15:35:06 2005
+--- urlview.c.orig	2013-07-19 22:44:59.000000000 +0100
++++ urlview.c	2013-07-19 22:45:22.000000000 +0100
 @@ -46,6 +46,8 @@
  #include <rx/rxposix.h>
  #endif
@@ -7,5 +7,14 @@
 +#include "quote.h"
 +
  #define DEFAULT_REGEXP "(((https?|ftp|gopher)://|(mailto|file|news):)[^' \t<>\"]+|(www|web|w3)\\.[-a-z0-9.]+)[^' \t.,;<>\"\\):]"
- #define DEFAULT_COMMAND "url_handler.sh %s"
+ #define DEFAULT_COMMAND "firefox %s"
  #define SYSTEM_INITFILE "/usr/local/etc/urlview.conf"
+@@ -61,7 +63,7 @@
+   MOTION
+ };
+ 
+-extern int mutt_enter_string (unsigned char *buf, size_t buflen, int y, int x,
++extern int mutt_enter_string (char *buf, size_t buflen, int y, int x,
+ 		int flags);
+ 
+ void search_forward (char *search, int urlcount, char **url, int *redraw, int *current, int *top)
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Danilo Egea Gondolfo freebsd_committer freebsd_triage 2013-11-25 15:07:11 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!