Bug 180753 - [PATCH] devel/ocaml-opam: fix build error of util.ml
Summary: [PATCH] devel/ocaml-opam: fix build error of util.ml
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-23 07:00 UTC by Jyun-Yan You
Modified: 2014-01-20 14:51 UTC (History)
1 user (show)

See Also:


Attachments
ocaml-opam-1.0.0.patch (484 bytes, patch)
2013-07-23 07:00 UTC, Jyun-Yan You
no flags Details | Diff
opam.patch (2.15 KB, patch)
2014-01-20 14:02 UTC, joris
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jyun-Yan You 2013-07-23 07:00:00 UTC
This patch fixes the build error of util.ml when we use system-optimized ocaml binaries by default.

Port maintainer (joris.gio@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.99_8 (mode: change, diff: ports)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-23 07:00:08 UTC
Maintainer of devel/ocaml-opam,

Please note that PR ports/180753 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180753

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-23 07:00:09 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-01-19 14:46:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marino

I'll take it.
Comment 4 joris 2014-01-20 14:02:36 UTC
Hi,

I see why the issue could happen here, but this sounds like a hack. I've
not been able to reproduce the issue, but i've updated the ports to the
new major version. Since the new version also has a new build system, it
might be fixed by configure/build system magic.
Comment 5 dfilter service freebsd_committer freebsd_triage 2014-01-20 14:48:14 UTC
Author: marino
Date: Mon Jan 20 14:48:06 2014
New Revision: 340403
URL: http://svnweb.freebsd.org/changeset/ports/340403
QAT: https://qat.redports.org/buildarchive/r340403/

Log:
  devel/ocaml-opam: Update to versions from 1.0 to 1.1
  
  This also has benefit of fixing the problem where a .conf file was
  created in ${HOME} which is illegal and the reason ocaml-opam never
  made it into dports.  The original complaint of the PR could not be
  reproduced, however.
  
  PR:		ports/180753
  Fixed by:	maintainer (Joris G.)

Added:
  head/devel/ocaml-opam/pkg-plist   (contents, props changed)
Modified:
  head/devel/ocaml-opam/Makefile
  head/devel/ocaml-opam/distinfo

Modified: head/devel/ocaml-opam/Makefile
==============================================================================
--- head/devel/ocaml-opam/Makefile	Mon Jan 20 14:35:09 2014	(r340402)
+++ head/devel/ocaml-opam/Makefile	Mon Jan 20 14:48:06 2014	(r340403)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	opam
-PORTVERSION=	1.0.0
+PORTVERSION=	1.1.0
 CATEGORIES=	devel
 MASTER_SITES=	http://www.ocamlpro.com/pub/
 PKGNAMEPREFIX=	ocaml-
@@ -15,31 +15,8 @@ LICENSE=	GPLv3
 
 BUILD_DEPENDS=	curl:${PORTSDIR}/ftp/curl
 
-USE_GMAKE=	yes
+USES=		gmake
 USE_OCAML=	yes
 GNU_CONFIGURE=	yes
 
-PLIST_FILES=	bin/opam bin/opam-mk-repo
-
-MAN1=	opam-check.1 \
-	opam-remote.1 \
-	opam-config.1 \
-	opam-remove.1 \
-	opam-help.1 \
-	opam-repository.1 \
-	opam-info.1 \
-	opam-search.1 \
-	opam-init.1 \
-	opam-switch.1 \
-	opam-install.1 \
-	opam-update.1 \
-	opam-list.1 \
-	opam-upgrade.1 \
-	opam-mk-repo.1 \
-	opam-upload.1 \
-	opam-pin.1 \
-	opam.1 \
-	opam-reinstall.1
-
-NO_STAGE=	yes
 .include <bsd.port.mk>

Modified: head/devel/ocaml-opam/distinfo
==============================================================================
--- head/devel/ocaml-opam/distinfo	Mon Jan 20 14:35:09 2014	(r340402)
+++ head/devel/ocaml-opam/distinfo	Mon Jan 20 14:48:06 2014	(r340403)
@@ -1,2 +1,2 @@
-SHA256 (opam-full-1.0.0.tar.gz) = e2504c044fb730451f2d728e2b24810798b1f1b0153917b21524ad807fbf8709
-SIZE (opam-full-1.0.0.tar.gz) = 2304000
+SHA256 (opam-full-1.1.0.tar.gz) = c0ab5e85b6cd26e533a40686e08aea173387d15bead817026f5b08f264642583
+SIZE (opam-full-1.1.0.tar.gz) = 2271477

Added: head/devel/ocaml-opam/pkg-plist
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/ocaml-opam/pkg-plist	Mon Jan 20 14:48:06 2014	(r340403)
@@ -0,0 +1,22 @@
+bin/opam
+bin/opam-admin
+man/man1/opam-admin-check.1.gz
+man/man1/opam-admin-make.1.gz
+man/man1/opam-admin.1.gz
+man/man1/opam-check.1.gz
+man/man1/opam-config.1.gz
+man/man1/opam-help.1.gz
+man/man1/opam-info.1.gz
+man/man1/opam-init.1.gz
+man/man1/opam-install.1.gz
+man/man1/opam-list.1.gz
+man/man1/opam-pin.1.gz
+man/man1/opam-reinstall.1.gz
+man/man1/opam-remote.1.gz
+man/man1/opam-remove.1.gz
+man/man1/opam-repository.1.gz
+man/man1/opam-search.1.gz
+man/man1/opam-switch.1.gz
+man/man1/opam-update.1.gz
+man/man1/opam-upgrade.1.gz
+man/man1/opam.1.gz
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 John Marino freebsd_committer freebsd_triage 2014-01-20 14:51:00 UTC
State Changed
From-To: feedback->closed

Updated to version 1.1 instead