Bug 180838 - [PATCH] net-mgmt/collectd5: fix PYTHON option
Summary: [PATCH] net-mgmt/collectd5: fix PYTHON option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-25 14:10 UTC by William Grzybowski
Modified: 2013-08-04 14:10 UTC (History)
0 users

See Also:


Attachments
collectd5.patch (1.24 KB, patch)
2013-07-25 14:10 UTC, William Grzybowski
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description William Grzybowski freebsd_committer freebsd_triage 2013-07-25 14:10:02 UTC
	Fix PYTHON option (wont build), add NOTIFYEMAIL missing in OPTIONS_DEFINE

Fix: See attached patch
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-25 14:10:15 UTC
Maintainer of net-mgmt/collectd5,

Please note that PR ports/180838 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180838

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2013-07-25 14:10:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2013-07-26 14:03:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wg

I'll take it.
Comment 4 Krzysztof 2013-08-03 22:07:39 UTC
Hello,

On Thu, Jul 25, 2013 at 01:10:15PM +0000, Edwin Groothuis wrote:
> Maintainer of net-mgmt/collectd5,
> 
> Please note that PR ports/180838 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/180838
> 
> -- 
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
> 
Yes, I approve this patch. Sorry for delay, but I was on vacation :-)))

Greetings,
-- 
Krzysztof Stryjek
UNIX administrator/Juniper Networks Specialist
email: wtp (at) bsdserwis (dot) com
http://www.linkedin.com/in/KrzysztofStryjek
GPG fingerprint: 8BD7 40CE 8994 0BBE CE6C  91CD 1292 8959 DC61 0E76

In theory, there is no difference between theory and practice.
In practice, there is.
Comment 5 dfilter service freebsd_committer freebsd_triage 2013-08-04 14:05:57 UTC
Author: wg
Date: Sun Aug  4 13:05:44 2013
New Revision: 324229
URL: http://svnweb.freebsd.org/changeset/ports/324229

Log:
  net-mgmt/collectd5: fix PYTHON option
  
  - Fix PYTHON option (use ${PYTHON_CMD})
  
  PR:		ports/180838
  Submitted by:	wg (myself)
  Approved by:	maintainer

Modified:
  head/net-mgmt/collectd5/Makefile

Modified: head/net-mgmt/collectd5/Makefile
==============================================================================
--- head/net-mgmt/collectd5/Makefile	Sun Aug  4 13:04:54 2013	(r324228)
+++ head/net-mgmt/collectd5/Makefile	Sun Aug  4 13:05:44 2013	(r324229)
@@ -3,7 +3,7 @@
 
 PORTNAME=	collectd
 PORTVERSION=	5.3.0
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	net-mgmt
 MASTER_SITES=	http://collectd.org/files/
 
@@ -17,7 +17,7 @@ USE_AUTOTOOLS=	autoconf autoheader autom
 
 LATEST_LINK=	collectd5
 
-OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
+OPTIONS_DEFINE=		CGI CURL DEBUG DBI GCRYPT JSON MEMCACHEC MODBUS MYSQL NOTIFYEMAIL NUTUPS PGSQL PING PYTHON REDIS ROUTEROS RRDTOOL SNMP STATGRAB TOKYOTYRANT VIRT XML XMMS
 
 CGI_DESC=		Install collection.cgi (requires rrdtool)
 CURL_DESC=		Enable curl-based plugins (apache, nginx, etc)
@@ -99,7 +99,6 @@ CONFIGURE_ARGS=	--localstatedir=/var \
 		--without-libyajl \
 		--without-oracle \
 		--without-perl-bindings \
-		--without-python
 
 # NOTE: Plugins without external dependencies
 CONFIGURE_ARGS+=	\
@@ -275,12 +274,12 @@ PLIST_SUB+=	PING="@comment "
 
 .if ${PORT_OPTIONS:MPYTHON}
 USE_PYTHON=	yes
-CONFIGURE_ARGS+=--with-python=${LOCALBASE} --enable-python
+CONFIGURE_ARGS+=--with-python=${PYTHON_CMD} --enable-python
 PLIST_SUB+=	PYTHON=""
 .else
+CONFIGURE_ARGS+=--without-python
 PLIST_SUB+=	PYTHON="@comment "
 .endif
-
 .if ${PORT_OPTIONS:MREDIS}
 LIB_DEPENDS+=	credis:${PORTSDIR}/databases/credis
 CONFIGURE_ARGS+=--with-libcredis=${LOCALBASE} \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 William Grzybowski freebsd_committer freebsd_triage 2013-08-04 14:10:40 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!