Bug 180843 - [PATCH] desktop-file-utils.mk really make update-desktop-database silent
Summary: [PATCH] desktop-file-utils.mk really make update-desktop-database silent
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-25 16:10 UTC by Pawel Pekala
Modified: 2013-07-25 20:10 UTC (History)
0 users

See Also:


Attachments
file.diff (762 bytes, patch)
2013-07-25 16:10 UTC, Pawel Pekala
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2013-07-25 16:10:00 UTC
Silencing of update-desktop-database does not work, error messages
go to stderr and showup on pacakge installation/deinstallation:

# /usr/local/bin/update-desktop-database > /dev/null
Error in file "/usr/local/share/applications/kde/printers.desktop": "print/manager" is an invalid MIME type ("print" is an unregistered media type)
Error in file "/usr/local/share/applications/kde/kfontview.desktop": "fonts/package" is an invalid MIME type ("fonts" is an unregistered media type)

I propose using -q option instead.

Fix: Patch attached with submission follows:
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2013-07-25 18:29:47 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2013-07-25 20:07:44 UTC
Author: kwm
Date: Thu Jul 25 19:07:37 2013
New Revision: 323663
URL: http://svnweb.freebsd.org/changeset/ports/323663

Log:
  Quiet update-desktop-database output, like when it complaining about invalid
  MIME types in .desktop files. It all non-fatal, and ugly to boot.
  
  PR:		ports/180843
  Submitted by:	pawel@

Modified:
  head/Mk/Uses/desktop-file-utils.mk

Modified: head/Mk/Uses/desktop-file-utils.mk
==============================================================================
--- head/Mk/Uses/desktop-file-utils.mk	Thu Jul 25 18:55:01 2013	(r323662)
+++ head/Mk/Uses/desktop-file-utils.mk	Thu Jul 25 19:07:37 2013	(r323663)
@@ -24,11 +24,11 @@ post-install: desktop-file-post-install
 
 desktop-file-post-install:
 # run for port post-install
-	@-update-desktop-database
+	@-update-desktop-database -q
 # plist entries for packages.
-	@${ECHO_CMD} "@exec ${LOCALBASE}/bin/update-desktop-database > /dev/null || /usr/bin/true" \
+	@${ECHO_CMD} "@exec ${LOCALBASE}/bin/update-desktop-database -q > /dev/null || /usr/bin/true" \
 		>> ${TMPPLIST}; \
-	${ECHO_CMD} "@unexec ${LOCALBASE}/bin/update-desktop-database > /dev/null || /usr/bin/true" \
+	${ECHO_CMD} "@unexec ${LOCALBASE}/bin/update-desktop-database -q > /dev/null || /usr/bin/true" \
 		>> ${TMPPLIST}
 
 .endif
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Koop Mast freebsd_committer freebsd_triage 2013-07-25 20:08:00 UTC
State Changed
From-To: open->closed

Committed thanks!